From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id AC8F1C433F5 for ; Tue, 8 Feb 2022 10:06:14 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id BC40D6B0078; Tue, 8 Feb 2022 05:06:13 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id B4D286B007B; Tue, 8 Feb 2022 05:06:13 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 9ED356B007D; Tue, 8 Feb 2022 05:06:13 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 8CCC46B0078 for ; Tue, 8 Feb 2022 05:06:13 -0500 (EST) Received: from smtpin24.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id 4124596765 for ; Tue, 8 Feb 2022 10:06:13 +0000 (UTC) X-FDA: 79119182226.24.A2C1377 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by imf25.hostedemail.com (Postfix) with ESMTP id DA2D4A0002 for ; Tue, 8 Feb 2022 10:06:12 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 777D1210F0; Tue, 8 Feb 2022 10:06:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1644314771; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=tYrORe3vbzcD89PzHSw+5HK7RMII1r7ziVJYHhpEbvY=; b=1G97zkUeMoUg2asgGtkKTpcfWDbflaeBjia6xc6toNB3usuLthmDrzmslwlNFDcp3oeajy a/CZ4wv+1Axgc0UL23uKPu9gl3y8o9C6oRPqacVZ1cw7Ek2vQutdsydcbSoANblhvK/Lsc 3UgYFGtuHddoAXHJcsaHpB2nJfDRCvU= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1644314771; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=tYrORe3vbzcD89PzHSw+5HK7RMII1r7ziVJYHhpEbvY=; b=BLDJBR5kBFT2606T2KG/4nXiSiOkRNicBmCdSRXn6G+O0k8joXqf3lxJaYSAI3TgAwYQ6n n0viQfq9FopNdADw== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 1580D13BF9; Tue, 8 Feb 2022 10:06:11 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id C7R6ApNAAmJUbwAAMHmgww (envelope-from ); Tue, 08 Feb 2022 10:06:11 +0000 Date: Tue, 8 Feb 2022 11:06:08 +0100 From: Oscar Salvador To: Miaohe Lin Cc: akpm@linux-foundation.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/4] mm/memory_hotplug: avoid calling zone_intersects() for ZONE_NORMAL Message-ID: References: <20220207133643.23427-1-linmiaohe@huawei.com> <20220207133643.23427-3-linmiaohe@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220207133643.23427-3-linmiaohe@huawei.com> X-Rspamd-Queue-Id: DA2D4A0002 X-Stat-Signature: w9xk87jdujzopzq8iy4odgd8whoj5rnu X-Rspam-User: Authentication-Results: imf25.hostedemail.com; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=1G97zkUe; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=BLDJBR5k; spf=pass (imf25.hostedemail.com: domain of osalvador@suse.de designates 195.135.220.28 as permitted sender) smtp.mailfrom=osalvador@suse.de; dmarc=pass (policy=none) header.from=suse.de X-Rspamd-Server: rspam05 X-HE-Tag: 1644314772-492404 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Feb 07, 2022 at 09:36:41PM +0800, Miaohe Lin wrote: > If zid reaches ZONE_NORMAL, the caller will always get the NORMAL zone no > matter what zone_intersects() returns. So we can save some possible cpu > cycles by avoid calling zone_intersects() for ZONE_NORMAL. > > Signed-off-by: Miaohe Lin Reviewed-by: Oscar Salvador > --- > mm/memory_hotplug.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/mm/memory_hotplug.c b/mm/memory_hotplug.c > index cbc67c27e0dd..140809e60e9a 100644 > --- a/mm/memory_hotplug.c > +++ b/mm/memory_hotplug.c > @@ -826,7 +826,7 @@ static struct zone *default_kernel_zone_for_pfn(int nid, unsigned long start_pfn > struct pglist_data *pgdat = NODE_DATA(nid); > int zid; > > - for (zid = 0; zid <= ZONE_NORMAL; zid++) { > + for (zid = 0; zid < ZONE_NORMAL; zid++) { > struct zone *zone = &pgdat->node_zones[zid]; > > if (zone_intersects(zone, start_pfn, nr_pages)) > -- > 2.23.0 > > -- Oscar Salvador SUSE Labs