From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id CF973C433F5 for ; Sat, 12 Feb 2022 01:49:26 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 4F1286B0075; Fri, 11 Feb 2022 20:49:26 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 4A0456B007B; Fri, 11 Feb 2022 20:49:26 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 38F376B007D; Fri, 11 Feb 2022 20:49:26 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0209.hostedemail.com [216.40.44.209]) by kanga.kvack.org (Postfix) with ESMTP id 289046B0075 for ; Fri, 11 Feb 2022 20:49:26 -0500 (EST) Received: from smtpin26.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id CEC40181AC9C6 for ; Sat, 12 Feb 2022 01:49:25 +0000 (UTC) X-FDA: 79132445490.26.0A9A0B9 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf27.hostedemail.com (Postfix) with ESMTP id D869340004 for ; Sat, 12 Feb 2022 01:49:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=ioyl46v/RncsoetIf9/GZiz5iMAc8fsJjCsfw/rRoqs=; b=tCQwBYQswc/aiVmvIQQ/dGaf5I fTMc2ARQ3Iu1urMPU0Ai1AmqGnM7WqS66CpjqV/3gwqULlA8jw1UbfsO+JdgRuVMQKJZ+JWj7RZ+g ogVheOaRImtrC+02f0BA4WnqN4bwc3SOP9Az6D+cmvSz4BuvKLhxeTGVlpwyLV3NsrPgUDHzmy6UF Bb3Drind7CmDXOOUtL5vdYFNRxbY2FYOAq5Sl3xAb6tqIEPnVbyC5uQgPSESzNpTLv66Tq6OoDJ9u z5+RL2wWAfao0cQq0iSKYrmfVRJefu3ywmOdbF2LfoN+ldFTbdPEv22Sn1B96BMIWt3iHyPSBXhXa 2rm5379g==; Received: from willy by casper.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1nIhXN-00Atng-BT; Sat, 12 Feb 2022 01:49:21 +0000 Date: Sat, 12 Feb 2022 01:49:21 +0000 From: Matthew Wilcox To: Christoph Hellwig Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 34/75] mm/vmscan: Turn page_check_dirty_writeback() into folio_check_dirty_writeback() Message-ID: References: <20220204195852.1751729-1-willy@infradead.org> <20220204195852.1751729-35-willy@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Stat-Signature: pm688a41tphgbztgw74t8fef8czqi9iy X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: D869340004 Authentication-Results: imf27.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=tCQwBYQs; dmarc=none; spf=none (imf27.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org X-Rspam-User: X-HE-Tag: 1644630564-438628 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Sun, Feb 06, 2022 at 11:51:54PM -0800, Christoph Hellwig wrote: > > - mapping = page_mapping(page); > > + mapping = folio_mapping(folio); > > if (mapping && mapping->a_ops->is_dirty_writeback) > > - mapping->a_ops->is_dirty_writeback(page, dirty, writeback); > > + mapping->a_ops->is_dirty_writeback(&folio->page, dirty, writeback); > > This adds an overly long line. Yeah, I'm planning on taking care of it in 5.19 by switching is_dirty_writeback() to take a folio. > Otherwise looks good: > > Reviewed-by: Christoph Hellwig >