From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 37A1AC433EF for ; Mon, 14 Feb 2022 13:28:46 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 9875B6B0071; Mon, 14 Feb 2022 08:28:45 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 936BB6B0073; Mon, 14 Feb 2022 08:28:45 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 7FE236B0078; Mon, 14 Feb 2022 08:28:45 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0095.hostedemail.com [216.40.44.95]) by kanga.kvack.org (Postfix) with ESMTP id 6C33A6B0071 for ; Mon, 14 Feb 2022 08:28:45 -0500 (EST) Received: from smtpin24.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id 1861D181AC9C6 for ; Mon, 14 Feb 2022 13:28:45 +0000 (UTC) X-FDA: 79141465410.24.168176C Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by imf20.hostedemail.com (Postfix) with ESMTP id 1A2781C000A for ; Mon, 14 Feb 2022 13:28:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1644845324; x=1676381324; h=date:from:to:cc:subject:message-id:references: mime-version:content-transfer-encoding:in-reply-to; bh=cpE53zPYsgnAtHEd4CoAcPikuiFHGkKcAGfRT7j/UY0=; b=nZbFCYNBfKnsgF1GizblYdLiZVa6snkLTejhfLcYPM8CcL5O+0ha3HS6 Sy0X8ELuOhk/pLwZTKFWbQ+9OLoep/gch6kVNRIdejaMNzzySqMGl9f4x BQCOm6PSC54A//Gtr6xbsRUqQYjLOE8so47N2IHTgUjwgnfqHctIcS22p nFEVeV6Ojk/v43DR5vNXUxYnGZ50PnAMZoLpTfkUHNTaM5RzCnXi8Qfzs 1TF2W4SUzlr4qt6H05fwyQ3sBcw8MIdsZNzc0kzo6CM29xmcbwFLo0SSW D68VBOMzBUQK3agIObnd7zjIH/ZBCQu2q3vRH9bEY22k10kr30F537Tmd A==; X-IronPort-AV: E=McAfee;i="6200,9189,10257"; a="237497182" X-IronPort-AV: E=Sophos;i="5.88,367,1635231600"; d="scan'208";a="237497182" Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 14 Feb 2022 05:28:42 -0800 X-IronPort-AV: E=Sophos;i="5.88,367,1635231600"; d="scan'208";a="632145467" Received: from unknown (HELO smile.fi.intel.com) ([10.237.72.59]) by fmsmga002-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 14 Feb 2022 05:28:40 -0800 Received: from andy by smile.fi.intel.com with local (Exim 4.95) (envelope-from ) id 1nJbOL-004Y6a-6C; Mon, 14 Feb 2022 15:27:45 +0200 Date: Mon, 14 Feb 2022 15:27:40 +0200 From: Andy Shevchenko To: Jan =?utf-8?B?RMSFYnJvxZs=?= Cc: kernel test robot , kbuild-all@lists.01.org, Linux Memory Management List , Wolfram Sang Subject: Re: [linux-next:master 4897/5417] drivers/i2c/busses/i2c-designware-amdpsp.c:165:25: sparse: sparse: incorrect type in argument 1 (different address spaces) Message-ID: References: <202202120520.NbWJGvF2-lkp@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: 1A2781C000A X-Stat-Signature: 7bqpwzo1gboon3wiij5g16gi5aty4qcp X-Rspam-User: Authentication-Results: imf20.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=nZbFCYNB; spf=none (imf20.hostedemail.com: domain of andriy.shevchenko@linux.intel.com has no SPF policy when checking 134.134.136.20) smtp.mailfrom=andriy.shevchenko@linux.intel.com; dmarc=pass (policy=none) header.from=intel.com X-HE-Tag: 1644845323-781944 Content-Transfer-Encoding: quoted-printable X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Feb 14, 2022 at 01:27:35PM +0100, Jan D=C4=85bro=C5=9B wrote: > pt., 11 lut 2022 o 22:24 kernel test robot napisa=C5=82= (a): > > 159 > > 160 /* Helper to verify status returned by PSP */ > > 161 static int check_i2c_req_sts(struct psp_i2c_req *req) > > 162 { > > 163 int status; > > 164 > > > 165 status =3D readl(&req->hdr.status); >=20 > Actually the above error points to something hidden but important - > for reading from command-response buffer, we shouldn't use __iomem > specifier (nor readl() family of functions) since this is normal > memory - however updated by PSP. Thus I will refactor this to use > 'volatile u32 *' and reading status by de-referencing pointer. Not sure volatile is a good idea. Perhaps READ_ONCE() is what you need. Is this a system memory? --=20 With Best Regards, Andy Shevchenko