From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 64313C433F5 for ; Mon, 14 Feb 2022 15:05:41 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id D5E5F6B0075; Mon, 14 Feb 2022 10:05:40 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id D0D436B007B; Mon, 14 Feb 2022 10:05:40 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id BD6276B007D; Mon, 14 Feb 2022 10:05:40 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0042.hostedemail.com [216.40.44.42]) by kanga.kvack.org (Postfix) with ESMTP id AD9B06B0075 for ; Mon, 14 Feb 2022 10:05:40 -0500 (EST) Received: from smtpin19.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id 6FD688F6E7 for ; Mon, 14 Feb 2022 15:05:40 +0000 (UTC) X-FDA: 79141709640.19.B8536DF Received: from mail-qk1-f176.google.com (mail-qk1-f176.google.com [209.85.222.176]) by imf17.hostedemail.com (Postfix) with ESMTP id C154F40003 for ; Mon, 14 Feb 2022 15:05:39 +0000 (UTC) Received: by mail-qk1-f176.google.com with SMTP id o25so14552176qkj.7 for ; Mon, 14 Feb 2022 07:05:39 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cmpxchg-org.20210112.gappssmtp.com; s=20210112; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=rwVAodOL1EH3E2Lb+JFjMWVXe7YxW9eI5axnQQxt+8s=; b=Blcmsc5N/kIb5n3TBW2qeHMOmRpQxeJLgz/718gzF5QOwt1Joo0UUjQrTiHTfXLwpx mHtQjpUOy3MUi7I8xet5mgQMQZMVzKylhTzcyZp+na2TPRPZDnnsJRkFgdqjqYsY3CqX uBxCoaMyFc2YKDn5I5BZrEHHgZAVtgyutMVV4wwdrkEoxL2HArIbXDzl5eqC6b9B7ti9 fZFU/jIv4MaYGqxX9KX35TOZ+z64y8kiVPoRDNdSnK3EzMcgFkXun7peHhMnlGNuz1fi U8ll9bnwJrAqvMnjoH5EBpE1VJO/lOsAHb2RKjBjbJGIzMVX/7JnydEOaqIHfBIKvigT a1Gg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=rwVAodOL1EH3E2Lb+JFjMWVXe7YxW9eI5axnQQxt+8s=; b=w9SlAvn7yBVQBr+PP/h3XObKRvHYsB+K5ZTA+/iP87LzY03hspN71IMlsKU3kEDXQF 5IXJ4LmzxENpcZVg+CaEBKdehpuMT1nVM9z1DT3vJZ3ewKQB7gKaY8j0Xo8yOvAoYDBG 5VHCwApqCMKE47CgZdFKqtG+x1uVvyXEi5VeaCQaYt2B2GgLfEucrons1UMkFz2xQkMe n6BOwFDUJsTV0fRU/DumCdtdWbI4W13lG1SKFTzqR+3FEhzOzoeWjbtzjihqUQXOtwr4 DX+kDH2OCJvOOmOY1o1PrndgjzFYacj/iKj7aSvAWgODOFHUdkIgLGMrLI3pA7p3gHUN yURA== X-Gm-Message-State: AOAM533UKUxfcopIWbucAz4Z2W46esJmfr1ExQil/DpMsL+xt+Fl4C8+ QY7JnjyCgqNiefJ0Eb4nv4fviw== X-Google-Smtp-Source: ABdhPJyFnvLhA5jRRIY4FmCW9aMreqDmbqNG5v6+fa6ZHTUrPL6DsVol9AFQPkuDA59hPq3Yhq/7cg== X-Received: by 2002:a37:a987:: with SMTP id s129mr7341056qke.681.1644851138994; Mon, 14 Feb 2022 07:05:38 -0800 (PST) Received: from localhost (cpe-98-15-154-102.hvc.res.rr.com. [98.15.154.102]) by smtp.gmail.com with ESMTPSA id y15sm15842513qko.95.2022.02.14.07.05.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 14 Feb 2022 07:05:38 -0800 (PST) Date: Mon, 14 Feb 2022 10:05:37 -0500 From: Johannes Weiner To: Peter Zijlstra Cc: Suren Baghdasaryan , Huangzhaoyang , Zhaoyang Huang , Ingo Molnar , linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCHv4] psi: fix possible trigger missing in the window Message-ID: References: <1643093818-19835-1-git-send-email-huangzhaoyang@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1643093818-19835-1-git-send-email-huangzhaoyang@gmail.com> Authentication-Results: imf17.hostedemail.com; dkim=pass header.d=cmpxchg-org.20210112.gappssmtp.com header.s=20210112 header.b=Blcmsc5N; spf=pass (imf17.hostedemail.com: domain of hannes@cmpxchg.org designates 209.85.222.176 as permitted sender) smtp.mailfrom=hannes@cmpxchg.org; dmarc=pass (policy=none) header.from=cmpxchg.org X-Rspamd-Server: rspam07 X-Rspam-User: X-Rspamd-Queue-Id: C154F40003 X-Stat-Signature: 94c5cdytuzhzathta6npx9ko7tjtbg5f X-HE-Tag: 1644851139-118122 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Jan 25, 2022 at 02:56:58PM +0800, Huangzhaoyang wrote: > From: Zhaoyang Huang > > When a new threshold breaching stall happens after a psi event was > generated and within the window duration, the new event is not > generated because the events are rate-limited to one per window. If > after that no new stall is recorded then the event will not be > generated even after rate-limiting duration has passed. This is > happening because with no new stall, window_update will not be called > even though threshold was previously breached. To fix this, record > threshold breaching occurrence and generate the event once window > duration is passed. > > Suggested-by: Suren Baghdasaryan > Signed-off-by: Zhaoyang Huang Hey Peter, would you mind taking this through the scheduler tree? It's got my and Suren's acks. It's not a recent regression so I'm thinking for 5.18 is fine. Thanks!