From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 18C28C433EF for ; Tue, 15 Feb 2022 20:33:57 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 749946B0078; Tue, 15 Feb 2022 15:33:57 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 6F50F6B007B; Tue, 15 Feb 2022 15:33:57 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 5BD126B007D; Tue, 15 Feb 2022 15:33:57 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0196.hostedemail.com [216.40.44.196]) by kanga.kvack.org (Postfix) with ESMTP id 4E4186B0078 for ; Tue, 15 Feb 2022 15:33:57 -0500 (EST) Received: from smtpin23.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id 074E992DE8 for ; Tue, 15 Feb 2022 20:33:57 +0000 (UTC) X-FDA: 79146165714.23.BADEF27 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf24.hostedemail.com (Postfix) with ESMTP id 2EDD118000A for ; Tue, 15 Feb 2022 20:33:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=XmAUCxdK9LP0XThgfZLTCMmPMdPVyUIqZsFQoqqvxRE=; b=vPsQ6kNlZdAwkzJfvvGZ5nbXbO 2AuHORN7nSKwlHsctx0qj5b3w6owNRBDf2Zqg4P0J/eZQkKSx2aVFW2NQj0vzACacGA2wdB2cfxBm VJlQb+Hy2yuFSgcDTTmNtHg0ln0tTfWSpIzdH/bR1u9xUYjPH75WZbd/jPE/+Y8g8vNp1NMHhl7wB Eft00HLESsOKVsBiy6HPkdAx8TdZX1TdW2yImEN/YVDrW8eTdTClvLnhEL9ZK7C3OZs7bCdTEED9o zWA91uC30L+GVW2s7Q5FrneXMZo3wMfC9we+fNCRRbjrP1eLGjH7D64oH89OCqyEh+UkuGICIbS21 HU/f+a3w==; Received: from willy by casper.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1nK4WF-00E9mq-Sk; Tue, 15 Feb 2022 20:33:51 +0000 Date: Tue, 15 Feb 2022 20:33:51 +0000 From: Matthew Wilcox To: Miaohe Lin Cc: linux-fsdevel@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH 08/10] mm: Turn deactivate_file_page() into deactivate_file_folio() Message-ID: References: <20220214200017.3150590-1-willy@infradead.org> <20220214200017.3150590-9-willy@infradead.org> <56e09280-c1dd-6bdb-81f0-524af99c5f4f@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <56e09280-c1dd-6bdb-81f0-524af99c5f4f@huawei.com> Authentication-Results: imf24.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=vPsQ6kNl; spf=none (imf24.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none X-Rspamd-Server: rspam07 X-Rspam-User: X-Rspamd-Queue-Id: 2EDD118000A X-Stat-Signature: ezhn5pm1dp8tmn6pqnj33p9ewrrukp8x X-HE-Tag: 1644957236-956000 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Feb 15, 2022 at 04:26:22PM +0800, Miaohe Lin wrote: > > + folio_get(folio); > > Should we comment the assumption that caller already hold the refcnt? Added to the kernel-doc: + * Context: Caller holds a reference on the page. > Anyway, this patch looks good to me. Thanks. > > Reviewed-by: Miaohe Lin > > > + local_lock(&lru_pvecs.lock); > > + pvec = this_cpu_ptr(&lru_pvecs.lru_deactivate_file); > > > > - if (pagevec_add_and_need_flush(pvec, page)) > > - pagevec_lru_move_fn(pvec, lru_deactivate_file_fn); > > - local_unlock(&lru_pvecs.lock); > > - } > > + if (pagevec_add_and_need_flush(pvec, &folio->page)) > > + pagevec_lru_move_fn(pvec, lru_deactivate_file_fn); > > + local_unlock(&lru_pvecs.lock); > > } > > > > /* > > diff --git a/mm/truncate.c b/mm/truncate.c > > index 567557c36d45..14486e75ec28 100644 > > --- a/mm/truncate.c > > +++ b/mm/truncate.c > > @@ -525,7 +525,7 @@ static unsigned long __invalidate_mapping_pages(struct address_space *mapping, > > * of interest and try to speed up its reclaim. > > */ > > if (!ret) { > > - deactivate_file_page(&folio->page); > > + deactivate_file_folio(folio); > > /* It is likely on the pagevec of a remote CPU */ > > if (nr_pagevec) > > (*nr_pagevec)++; > > > >