From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 52B27C433EF for ; Tue, 15 Feb 2022 22:57:02 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id D34456B007B; Tue, 15 Feb 2022 17:57:01 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id CE6FE6B007D; Tue, 15 Feb 2022 17:57:01 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id BAD056B007E; Tue, 15 Feb 2022 17:57:01 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0208.hostedemail.com [216.40.44.208]) by kanga.kvack.org (Postfix) with ESMTP id ACD3E6B007B for ; Tue, 15 Feb 2022 17:57:01 -0500 (EST) Received: from smtpin27.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id 6297A95295 for ; Tue, 15 Feb 2022 22:57:01 +0000 (UTC) X-FDA: 79146526242.27.AB083D9 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf24.hostedemail.com (Postfix) with ESMTP id 7A0B1180002 for ; Tue, 15 Feb 2022 22:57:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=lxDxiH7YdaguzLVLUSqqsB5d4iEpIHEpukWCHc1REm0=; b=EelEfSfmJZSj7jPR8xdrytLvOv vvUegttSQBNXTCISxTbXxPrmJ3ijUCphVHjWXzE5fzvUSjXjgspgCUuw/AooGJM3x20gIF2JvPJCV Gr7jF/6+VPXHTn5p6oQYvOOdahT4NrKPvmxVpYH9NobncBN9rut7BziYG9r9sb8oOrGxy9XBaXXIw lopSMV62eX5PhZgVOKfGsWjasY9ZBEuxFoA9uyQ5zoLd3Yw2uPBDcikP8sjKIweQuXrki7JmYHalt vJCwUxPIlS2v6dDqrKb0d4JKpxhOoVKrCGPHuRudPQBuWKe6sTGs3YVuOVr8AS7BIFdxRsIWKQdW/ hq8pA/JQ==; Received: from willy by casper.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1nK6kL-00EEoo-QD; Tue, 15 Feb 2022 22:56:33 +0000 Date: Tue, 15 Feb 2022 22:56:33 +0000 From: Matthew Wilcox To: Hugh Dickins Cc: Andrew Morton , Michal Hocko , Vlastimil Babka , "Kirill A. Shutemov" , David Hildenbrand , Alistair Popple , Johannes Weiner , Rik van Riel , Suren Baghdasaryan , Yu Zhao , Greg Thelen , Shakeel Butt , Yang Li , SeongJae Park , Geert Uytterhoeven , linux-kernel@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH v2 10/13] mm/munlock: mlock_page() munlock_page() batch by pagevec Message-ID: References: <55a49083-37f9-3766-1de9-9feea7428ac@google.com> <1abb94ee-fe72-dba9-3eb0-d1e576d148e6@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Authentication-Results: imf24.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=EelEfSfm; dmarc=none; spf=none (imf24.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org X-Rspam-User: X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: 7A0B1180002 X-Stat-Signature: dngaupmgpy1qrm1mdri9zijgx6tji8tj X-HE-Tag: 1644965820-703793 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Feb 15, 2022 at 01:02:30PM -0800, Hugh Dickins wrote: > On Tue, 15 Feb 2022, Matthew Wilcox wrote: > > > +#define mlock_new(page) ((struct page *)((unsigned long)page + NEW_PAGE)) > > > > I'm going to change this to: > > > > static inline struct page *mlock_lru(struct page *page) > > { > > return (struct page *)((unsigned long)page + LRU_PAGE); > > } > > > > (mutatis mutandi for mlock_new) > > Okay, thanks. (You're not naming your folio "page" :-?) Worse, I tried passing it '&folio->page'. That produced some ... interesting compiler error messages.