From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 979C0C433F5 for ; Tue, 1 Mar 2022 21:32:07 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 0865B8D0002; Tue, 1 Mar 2022 16:32:07 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 00CC18D0001; Tue, 1 Mar 2022 16:32:06 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id DEF528D0002; Tue, 1 Mar 2022 16:32:06 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0179.hostedemail.com [216.40.44.179]) by kanga.kvack.org (Postfix) with ESMTP id CE0F08D0001 for ; Tue, 1 Mar 2022 16:32:06 -0500 (EST) Received: from smtpin21.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id 7B671181CB2C7 for ; Tue, 1 Mar 2022 21:32:06 +0000 (UTC) X-FDA: 79197115452.21.A81E7D1 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) by imf22.hostedemail.com (Postfix) with ESMTP id 1D41EC0014 for ; Tue, 1 Mar 2022 21:31:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=Sender:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=5VVuLOyzVojFtdlB1wdXu5nu6vPydR5gopX9RTl4ymY=; b=hzHwr/X84crorF5eqeeLqMG9h0 8LdN1r0CUxK5OhHZJsKcqS4ut++icTOMJ/PjT8hnPOWsG133TDvYyNtY9qzdxcZtFA7ZHHvbXFeXp LWduIdbEN4fCsup6Io73V7hKDAGPcqZ20fAim9GmOmSC1lg03UgsDCAABTY2BiAM4pnYTaWE35Pmw CtJepFr99HGihM7nUoyJ2gICUJjdtkCKLsy2vEerFGML6tLQTB301uh/SBSfSOFF92Ig/IqWdc3ax nV521LwOTFx7jzMNoonpPUABoLOliEKFruuxE50hMt4zv2TTLbygsnAIIcbodwzUNFKdoLd1ZnzOV PS5oyBGg==; Received: from mcgrof by bombadil.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1nPA5Y-000dS7-1r; Tue, 01 Mar 2022 21:31:20 +0000 Date: Tue, 1 Mar 2022 13:31:20 -0800 From: Luis Chamberlain To: "Eric W. Biederman" Cc: Shakeel Butt , Colin Ian King , NeilBrown , Vasily Averin , Vlastimil Babka , Michal Hocko , Roman Gushchin , Linux MM , netdev@vger.kernel.org, "David S. Miller" , Jakub Kicinski , Tejun Heo , Greg Kroah-Hartman , Eric Dumazet , Kees Cook , Hideaki YOSHIFUJI , David Ahern , linux-kernel@vger.kernel.org, kernel@openvz.org Subject: Re: [PATCH RFC] net: memcg accounting for veth devices Message-ID: References: <20220301180917.tkibx7zpcz2faoxy@google.com> <87wnhdwg75.fsf@email.froward.int.ebiederm.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspamd-Server: rspam11 X-Rspamd-Queue-Id: 1D41EC0014 X-Rspam-User: Authentication-Results: imf22.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b="hzHwr/X8"; dmarc=fail reason="No valid SPF, DKIM not aligned (relaxed)" header.from=kernel.org (policy=none); spf=none (imf22.hostedemail.com: domain of mcgrof@infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=mcgrof@infradead.org X-Stat-Signature: tw4k1mfbwex3scyahuu6187h76qb18m9 X-HE-Tag: 1646170296-273422 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Mar 01, 2022 at 01:25:16PM -0800, Luis Chamberlain wrote: > diff --git a/kernel/ucount.c b/kernel/ucount.c > index 4f5613dac227..980ffaba1ac5 100644 > --- a/kernel/ucount.c > +++ b/kernel/ucount.c > @@ -238,6 +238,8 @@ struct ucounts *inc_ucount(struct user_namespace *ns, kuid_t uid, > long max; > tns = iter->ns; > max = READ_ONCE(tns->ucount_max[type]); > + if (atomic_long_read(&iter->ucount[type]) > max/16) > + cond_resched(); > if (!atomic_long_inc_below(&iter->ucount[type], max)) > goto fail; You can of course ignore this, it was just a hack to try to avoid a soft lockup on the workqueues. Luis