From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id BA829C433EF for ; Wed, 23 Mar 2022 13:02:38 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 3E8996B0072; Wed, 23 Mar 2022 09:02:38 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 3975E6B0073; Wed, 23 Mar 2022 09:02:38 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 237A06B0074; Wed, 23 Mar 2022 09:02:38 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (relay.hostedemail.com [64.99.140.27]) by kanga.kvack.org (Postfix) with ESMTP id 123F86B0072 for ; Wed, 23 Mar 2022 09:02:38 -0400 (EDT) Received: from smtpin04.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay13.hostedemail.com (Postfix) with ESMTP id 7D95261A90 for ; Wed, 23 Mar 2022 13:02:37 +0000 (UTC) X-FDA: 79275665154.04.86E71EC Received: from galois.linutronix.de (Galois.linutronix.de [193.142.43.55]) by imf19.hostedemail.com (Postfix) with ESMTP id 2C2FC1A0039 for ; Wed, 23 Mar 2022 13:02:37 +0000 (UTC) Date: Wed, 23 Mar 2022 14:02:33 +0100 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020; t=1648040554; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=fbCwVVRphwKFhHFjdgqzv4b5jAPDrPw5EXg1eflzqcM=; b=lTyix5maivfLw8E8Po9Y8v0iZkkEthoVdWxUAkacnuW0EcVIUXUU/gXp86tc8gzJW1L/9d IE1sZhoeNDz/df5gmlbGLLgOMTkZ7b0Yhuv+nx3cNEniAygTwrvIyC5v8oJZ+oBJdZeEGh eJ+CIs/Un9nFcO9gJcTYcTsVa2IBBjBC9hb8oc1PTPzF333H+1LoX0mqXANdTWMhr2sCG9 WtR1y5ljZeyMxVkZEXbLcOHnuqZtIqFtcbSVpB/Jwdl5jjlEHi60d+fg4LteatHl3lNSrA wnMrsAbczhw5//ay4CFJisdm3qQh3CXF9MZ0xzyihH1ZU+FEqdBJcVYSf7p+vg== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020e; t=1648040554; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=fbCwVVRphwKFhHFjdgqzv4b5jAPDrPw5EXg1eflzqcM=; b=VOsTdu5ZLZW0Wq76l4BUB69GXQpUMxEHlRDyF0Lcl3AtX6x/7peY+Wd+sltN7+9itzrpzd Dlkn6n4Th6PRY5Dw== From: Sebastian Andrzej Siewior To: Vlastimil Babka Cc: andrey.konovalov@linux.dev, Andrew Morton , Andrey Konovalov , Marco Elver , Alexander Potapenko , Dmitry Vyukov , Andrey Ryabinin , kasan-dev@googlegroups.com, linux-mm@kvack.org, Vincenzo Frascino , Catalin Marinas , Will Deacon , Mark Rutland , linux-arm-kernel@lists.infradead.org, Peter Collingbourne , Evgenii Stepanov , linux-kernel@vger.kernel.org, Andrey Konovalov Subject: Re: [PATCH v6 27/39] kasan, mm: only define ___GFP_SKIP_KASAN_POISON with HW_TAGS Message-ID: References: <44e5738a584c11801b2b8f1231898918efc8634a.1643047180.git.andreyknvl@google.com> <63704e10-18cf-9a82-cffb-052c6046ba7d@suse.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <63704e10-18cf-9a82-cffb-052c6046ba7d@suse.cz> X-Rspam-User: Authentication-Results: imf19.hostedemail.com; dkim=pass header.d=linutronix.de header.s=2020 header.b=lTyix5ma; dkim=pass header.d=linutronix.de header.s=2020e header.b=VOsTdu5Z; spf=pass (imf19.hostedemail.com: domain of bigeasy@linutronix.de designates 193.142.43.55 as permitted sender) smtp.mailfrom=bigeasy@linutronix.de; dmarc=pass (policy=none) header.from=linutronix.de X-Rspamd-Server: rspam03 X-Rspamd-Queue-Id: 2C2FC1A0039 X-Stat-Signature: bu3mm4bjxgx37spe4b6567ht1kzq4igb X-HE-Tag: 1648040557-193535 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 2022-03-23 12:48:29 [+0100], Vlastimil Babka wrote: > > +#ifdef CONFIG_KASAN_HW_TAGS > > #define ___GFP_SKIP_KASAN_POISON 0x1000000u > > +#else > > +#define ___GFP_SKIP_KASAN_POISON 0 > > +#endif > > #ifdef CONFIG_LOCKDEP > > #define ___GFP_NOLOCKDEP 0x2000000u > > #else > > @@ -251,7 +255,9 @@ struct vm_area_struct; > > #define __GFP_NOLOCKDEP ((__force gfp_t)___GFP_NOLOCKDEP) > > > > /* Room for N __GFP_FOO bits */ > > -#define __GFP_BITS_SHIFT (25 + IS_ENABLED(CONFIG_LOCKDEP)) > > +#define __GFP_BITS_SHIFT (24 + \ > > + IS_ENABLED(CONFIG_KASAN_HW_TAGS) + \ > > + IS_ENABLED(CONFIG_LOCKDEP)) > > This breaks __GFP_NOLOCKDEP, see: > https://lore.kernel.org/all/YjoJ4CzB3yfWSV1F@linutronix.de/ This could work because ___GFP_NOLOCKDEP is still 0x2000000u. In ("kasan, page_alloc: allow skipping memory init for HW_TAGS") https://lore.kernel.org/all/0d53efeff345de7d708e0baa0d8829167772521e.1643047180.git.andreyknvl@google.com/ This is replaced with 0x8000000u which breaks lockdep. Sebastian