From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 36F39C433F5 for ; Thu, 7 Apr 2022 03:14:26 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 93DC76B0071; Wed, 6 Apr 2022 23:14:15 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 8C5A66B0073; Wed, 6 Apr 2022 23:14:15 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 78DC86B0074; Wed, 6 Apr 2022 23:14:15 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (relay.hostedemail.com [64.99.140.27]) by kanga.kvack.org (Postfix) with ESMTP id 6863C6B0071 for ; Wed, 6 Apr 2022 23:14:15 -0400 (EDT) Received: from smtpin01.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay12.hostedemail.com (Postfix) with ESMTP id 385F4122BDD for ; Thu, 7 Apr 2022 03:14:05 +0000 (UTC) X-FDA: 79328614050.01.9530AE0 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf24.hostedemail.com (Postfix) with ESMTP id 57776180002 for ; Thu, 7 Apr 2022 03:14:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=a+/6IHa8J2ibYiY7PsEo03ecQN3sZog+lPT2RUEfmQU=; b=XiY2rlMpWwSz+W6TCaFdXuEU90 B3wVZ3teCDo6niE97uSEv6VN/Qn4+b6hZs4HHpREIo3Z1ADoaKyVeipKQhZGjheHUZqQuhGNUy02y 44vMr3KV6IqI7w08utLuSRafzs8CygGmbGyhCSRgdauKwspKoEO46Uo3X3ot3sD2csuGq6oaOD49j HPGRctd+JHA1gfUiqu8yAVIbmCaqThOUuVlph+TEtdjwe80lbFuJVm1LQ6wtJQbToNmjs4OUioz4F oHs093V9QAbVKXbJmR0qFp6K2ISohuumBm09EShIuplcqcyVGxf5wrk6Y8rZCasfhTsJLVc7dtDuc 7xIGki7g==; Received: from willy by casper.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1ncIah-008Qzd-Fd; Thu, 07 Apr 2022 03:13:47 +0000 Date: Thu, 7 Apr 2022 04:13:47 +0100 From: Matthew Wilcox To: David Howells Cc: linux-cachefs@redhat.com, Rohith Surabattula , Steve French , Shyam Prasad N , linux-cifs@vger.kernel.org, Jeff Layton , linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH 14/14] mm, netfs, fscache: Stop read optimisation when folio removed from pagecache Message-ID: References: <164928615045.457102.10607899252434268982.stgit@warthog.procyon.org.uk> <164928630577.457102.8519251179327601178.stgit@warthog.procyon.org.uk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <164928630577.457102.8519251179327601178.stgit@warthog.procyon.org.uk> X-Rspam-User: X-Stat-Signature: wa5s669jfsq8jet4tijr5yhz7arc6mdk Authentication-Results: imf24.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=XiY2rlMp; spf=none (imf24.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none X-Rspamd-Server: rspam01 X-Rspamd-Queue-Id: 57776180002 X-HE-Tag: 1649301244-468278 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Apr 07, 2022 at 12:05:05AM +0100, David Howells wrote: > Fix this by adding an extra address_space operation, ->removing folio(), > and flag, AS_NOTIFY_REMOVING_FOLIO. The operation is called if the flag is > set when a folio is removed from the pagecache. The flag should be set if > a non-NULL cookie is obtained from fscache and cleared in ->evict_inode() > before truncate_inode_pages_final() is called. What's wrong with ->freepage?