From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id ED362C433F5 for ; Tue, 29 Mar 2022 00:04:23 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 5FCAE8D0002; Mon, 28 Mar 2022 20:04:23 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 5ABBA8D0001; Mon, 28 Mar 2022 20:04:23 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 4261B8D0002; Mon, 28 Mar 2022 20:04:23 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (relay.a.hostedemail.com [64.99.140.24]) by kanga.kvack.org (Postfix) with ESMTP id 32DF38D0001 for ; Mon, 28 Mar 2022 20:04:23 -0400 (EDT) Received: from smtpin10.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 0C00C231FA for ; Tue, 29 Mar 2022 00:04:23 +0000 (UTC) X-FDA: 79295476806.10.628EFA4 Received: from mail-pf1-f172.google.com (mail-pf1-f172.google.com [209.85.210.172]) by imf19.hostedemail.com (Postfix) with ESMTP id 39F911A0009 for ; Tue, 29 Mar 2022 00:04:22 +0000 (UTC) Received: by mail-pf1-f172.google.com with SMTP id s11so14308393pfu.13 for ; Mon, 28 Mar 2022 17:04:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to; bh=etgjqyAwbvR6Km5d+2cDKN373f0iHJRr9ymO9u+KgK4=; b=G5YIvVl22ePZITTXQy7vowBlWgCkZizGIGOI6pI2XX9x6vtJv/N8rYqMnVC1NBJmDl Xi+sHsYUIN+SJvKP8OhZ+TiWYKsB4cnA6blgTh8kV07ztljdTDT58Zz7wNd5brW8jMKi MeGC0zhst3Ze45rOieg8y/L1qR1ehb0uYXPOVkW1do58sPgFqUFnszIPRO9ZxP9E/VDu Hg6Vj8ktwcYNsYL0mPC653HM7uXxVOtZT2l2L6hyenJnUzEd16GnIxOc9EHXvkyvvGnf OmD5GfIZ3n5oGbfX95H+OgOqSCiAjQRN+aczvRBQ7z8EFIt+C0RkUgE4xiw6oc4aMGhH c2MQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=etgjqyAwbvR6Km5d+2cDKN373f0iHJRr9ymO9u+KgK4=; b=eoFX2+w60qzWDY57UUTqJ+ydLndghFXzJd6kzABmz67zficCtFpOKH6f46yYfW0sTm 9E9YKGQZVr7/ZpVTQFGuqb8qIuQVsJ/XV3n/d9rvs9ywD1g1bTegZVlxj/Brrliut7Rx 4ALx2wc/povZxKYL9RCu1IqSZYQFZwXBOpsPNNzVf/Xyy2z8VYIgcU1Slg62vLUUtV9z lM6dQzvCbYNzf9nibst1AUk1HqgLXd7i+/HU8M6xUEibyq4RlCYkFutUt5/I2o7TpkJb Bbgcv/9En4P2924qWIXZ44Q36aPtl8NdRD3nYVC6HSUg4gcYhy/SeT8DHc1uQ2rP6CJn htow== X-Gm-Message-State: AOAM533gm3mVAfM0JcAGM/it9m1k8jJW/sYOKGKVkmtLnuOKfSm0gX0X Pn9XmeKWiBX2kIEObUQNDZz/zA== X-Google-Smtp-Source: ABdhPJx8yKtkbTnvKDhEF6CrTpFMthUus1w5B4uh8qOQh+zUkITN5OLbQQgaCn3E+3ynmkMH71yJkQ== X-Received: by 2002:a63:e545:0:b0:382:8dd9:a870 with SMTP id z5-20020a63e545000000b003828dd9a870mr11790668pgj.621.1648512260958; Mon, 28 Mar 2022 17:04:20 -0700 (PDT) Received: from google.com (157.214.185.35.bc.googleusercontent.com. [35.185.214.157]) by smtp.gmail.com with ESMTPSA id 204-20020a6302d5000000b00385f29b02b2sm14336170pgc.50.2022.03.28.17.04.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 28 Mar 2022 17:04:20 -0700 (PDT) Date: Tue, 29 Mar 2022 00:04:16 +0000 From: Sean Christopherson To: "Nakajima, Jun" Cc: "Lutomirski, Andy" , Chao Peng , KVM list , LKML , Linux Memory Management List , "linux-fsdevel@vger.kernel.org" , "linux-api@vger.kernel.org" , "qemu-devel@nongnu.org" , Paolo Bonzini , Jonathan Corbet , Vitaly Kuznetsov , Wanpeng Li , Jim Mattson , Joerg Roedel , Thomas Gleixner , Ingo Molnar , Borislav Petkov , "x86@kernel.org" , "H . Peter Anvin" , Hugh Dickins , Jeff Layton , "J . Bruce Fields" , Andrew Morton , Mike Rapoport , Steven Price , "Maciej S . Szmigiero" , Vlastimil Babka , Vishal Annapurve , Yu Zhang , "Kirill A . Shutemov" , "Hansen, Dave" , "ak@linux.intel.com" , "david@redhat.com" Subject: Re: [PATCH v5 00/13] KVM: mm: fd-based approach for supporting KVM guest private memory Message-ID: References: <20220310140911.50924-1-chao.p.peng@linux.intel.com> <7CCE5220-0ACF-48EE-9366-93CABDA91065@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <7CCE5220-0ACF-48EE-9366-93CABDA91065@intel.com> Authentication-Results: imf19.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b=G5YIvVl2; spf=pass (imf19.hostedemail.com: domain of seanjc@google.com designates 209.85.210.172 as permitted sender) smtp.mailfrom=seanjc@google.com; dmarc=pass (policy=reject) header.from=google.com X-Stat-Signature: 8ww5yyw9knkgo5uf9f4z6yccs5fzztng X-Rspam-User: X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: 39F911A0009 X-HE-Tag: 1648512262-846604 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Mar 28, 2022, Nakajima, Jun wrote: > > On Mar 28, 2022, at 1:16 PM, Andy Lutomirski wrote: > > > > On Thu, Mar 10, 2022 at 6:09 AM Chao Peng wrote: > >> > >> This is the v5 of this series which tries to implement the fd-based KVM > >> guest private memory. The patches are based on latest kvm/queue branch > >> commit: > >> > >> d5089416b7fb KVM: x86: Introduce KVM_CAP_DISABLE_QUIRKS2 > > > > Can this series be run and a VM booted without TDX? A feature like > > that might help push it forward. > > > > —Andy > > Since the userspace VMM (e.g. QEMU) loses direct access to private memory of > the VM, the guest needs to avoid using the private memory for (virtual) DMA > buffers, for example. Otherwise, it would need to use bounce buffers, i.e. we > would need changes to the VM. I think we can try that (i.e. add only bounce > buffer changes). What do you think? I would love to be able to test this series and run full-blown VMs without TDX or SEV hardware. The other option for getting test coverage is KVM selftests, which don't have an existing guest that needs to be enlightened. Vishal is doing work on that front, though I think it's still in early stages. Long term, selftests will also be great for negative testing.