From: Christoph Hellwig <hch@infradead.org>
To: Shiyang Ruan <ruansy.fnst@fujitsu.com>
Cc: Christoph Hellwig <hch@infradead.org>,
linux-kernel@vger.kernel.org, linux-xfs@vger.kernel.org,
nvdimm@lists.linux.dev, linux-mm@kvack.org,
linux-fsdevel@vger.kernel.org, djwong@kernel.org,
dan.j.williams@intel.com, david@fromorbit.com,
jane.chu@oracle.com
Subject: Re: [PATCH v11 7/8] xfs: Implement ->notify_failure() for XFS
Date: Wed, 30 Mar 2022 08:52:21 -0700 [thread overview]
Message-ID: <YkR8tfSn+M51fbff@infradead.org> (raw)
In-Reply-To: <894ed00b-b174-6a10-ee45-320007957ea4@fujitsu.com>
On Wed, Mar 30, 2022 at 11:16:10PM +0800, Shiyang Ruan wrote:
> > > +#if IS_ENABLED(CONFIG_MEMORY_FAILURE) && IS_ENABLED(CONFIG_FS_DAX)
> >
> > No real need for the IS_ENABLED. Also any reason to even build this
> > file if the options are not set? It seems like
> > xfs_dax_holder_operations should just be defined to NULL and the
> > whole file not supported if we can't support the functionality.
>
> Got it. These two CONFIG seem not related for now. So, I think I should
> wrap these code with #ifdef CONFIG_MEMORY_FAILURE here, and add
> `xfs-$(CONFIG_FS_DAX) += xfs_notify_failure.o` in the makefile.
I'd do
ifeq ($(CONFIG_MEMORY_FAILURE),y)
xfs-$(CONFIG_FS_DAX) += xfs_notify_failure.o
endif
in the makefile and keep it out of the actual source file entirely.
> > > +
> > > + /* Ignore the range out of filesystem area */
> > > + if ((offset + len) < ddev_start)
> >
> > No need for the inner braces.
> >
> > > + if ((offset + len) > ddev_end)
> >
> > No need for the braces either.
>
> Really no need? It is to make sure the range to be handled won't out of the
> filesystem area. And make sure the @offset and @len are valid and correct
> after subtract the bbdev_start.
Yes, but there is no need for the braces per the precedence rules in
C. So these could be:
if (offset + len < ddev_start)
and
if (offset + len > ddev_end)
next prev parent reply other threads:[~2022-03-30 15:52 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-27 12:07 [PATCH v11 0/8] fsdax: introduce fs query to support reflink Shiyang Ruan
2022-02-27 12:07 ` [PATCH v11 1/8] dax: Introduce holder for dax_device Shiyang Ruan
2022-03-11 23:35 ` Dan Williams
2022-03-16 13:46 ` Shiyang Ruan
2022-03-30 5:41 ` Christoph Hellwig
2022-03-30 10:03 ` Shiyang Ruan
2022-03-30 10:13 ` Christoph Hellwig
2022-03-30 10:58 ` Shiyang Ruan
2022-03-30 15:49 ` Christoph Hellwig
2022-03-30 16:18 ` Darrick J. Wong
2022-04-06 0:55 ` Jane Chu
2022-04-06 1:22 ` Dan Williams
2022-04-06 20:39 ` Darrick J. Wong
2022-04-08 1:38 ` Dan Williams
2022-04-08 5:59 ` Shiyang Ruan
2022-03-30 5:41 ` Christoph Hellwig
2022-02-27 12:07 ` [PATCH v11 2/8] mm: factor helpers for memory_failure_dev_pagemap Shiyang Ruan
2022-02-27 12:07 ` [PATCH v11 3/8] pagemap,pmem: Introduce ->memory_failure() Shiyang Ruan
2022-02-27 12:07 ` [PATCH v11 4/8] fsdax: Introduce dax_lock_mapping_entry() Shiyang Ruan
2022-02-27 12:07 ` [PATCH v11 5/8] mm: move pgoff_address() to vma_pgoff_address() Shiyang Ruan
2022-03-30 5:46 ` Christoph Hellwig
2022-03-30 6:49 ` Shiyang Ruan
2022-02-27 12:07 ` [PATCH v11 6/8] mm: Introduce mf_dax_kill_procs() for fsdax case Shiyang Ruan
2022-03-30 5:51 ` Christoph Hellwig
2022-02-27 12:07 ` [PATCH v11 7/8] xfs: Implement ->notify_failure() for XFS Shiyang Ruan
2022-02-27 14:05 ` kernel test robot
2022-02-27 15:36 ` kernel test robot
2022-02-27 15:46 ` kernel test robot
2022-03-30 6:00 ` Christoph Hellwig
2022-03-30 15:16 ` Shiyang Ruan
2022-03-30 15:52 ` Christoph Hellwig [this message]
2022-04-08 6:04 ` Shiyang Ruan
2022-04-08 6:26 ` Dan Williams
2022-04-08 6:25 ` Dan Williams
2022-02-27 12:07 ` [PATCH v11 8/8] fsdax: set a CoW flag when associate reflink mappings Shiyang Ruan
2022-02-27 15:57 ` kernel test robot
2022-03-10 13:08 ` [PATCH v11 0/8] fsdax: introduce fs query to support reflink Shiyang Ruan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YkR8tfSn+M51fbff@infradead.org \
--to=hch@infradead.org \
--cc=dan.j.williams@intel.com \
--cc=david@fromorbit.com \
--cc=djwong@kernel.org \
--cc=jane.chu@oracle.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-xfs@vger.kernel.org \
--cc=nvdimm@lists.linux.dev \
--cc=ruansy.fnst@fujitsu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).