From: Matthew Wilcox <willy@infradead.org>
To: David Hildenbrand <david@redhat.com>
Cc: Miaohe Lin <linmiaohe@huawei.com>,
akpm@linux-foundation.org, linux-mm@kvack.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mm/swapfile: unuse_pte can map random data if swap read fails
Date: Mon, 4 Apr 2022 15:11:35 +0100 [thread overview]
Message-ID: <Ykr8l0sUOtAa3yUY@casper.infradead.org> (raw)
In-Reply-To: <ac13a529-5000-19c9-bbd8-3ee634a923cc@redhat.com>
On Mon, Apr 04, 2022 at 03:37:36PM +0200, David Hildenbrand wrote:
> On 01.04.22 09:29, Miaohe Lin wrote:
> > There is a bug in unuse_pte(): when swap page happens to be unreadable,
> > page filled with random data is mapped into user address space. The fix
> > is to check for PageUptodate and fail swapoff in case of error.
> >
> > Signed-off-by: Miaohe Lin <linmiaohe@huawei.com>
> > ---
> > mm/swapfile.c | 4 ++++
> > 1 file changed, 4 insertions(+)
> >
> > diff --git a/mm/swapfile.c b/mm/swapfile.c
> > index 63c61f8b2611..e72a35de7a0f 100644
> > --- a/mm/swapfile.c
> > +++ b/mm/swapfile.c
> > @@ -1795,6 +1795,10 @@ static int unuse_pte(struct vm_area_struct *vma, pmd_t *pmd,
> > ret = 0;
> > goto out;
> > }
> > + if (unlikely(!PageUptodate(page))) {
> > + ret = -EIO;
> > + goto out;
> > + }
>
> Yeah, we have the same handling in do_swap_page(), whereby we send a
> SIGBUS because we're dealing with an actual access.
>
> Interestingly, folio_test_uptodate() states:
>
> "Anonymous and CoW folios are always uptodate."
>
> @Willy, is that true or is the swapin case not documented there?
Why do we keep a !Uptodate page in the swap cache? If it can't be
read in from swap, I thought we just freed the page. Since Miaohe
has observed that not happening, I guess it doesn't work that way,
but why not make it work that way?
next prev parent reply other threads:[~2022-04-04 14:12 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-01 7:29 [PATCH] mm/swapfile: unuse_pte can map random data if swap read fails Miaohe Lin
2022-04-04 13:37 ` David Hildenbrand
2022-04-04 14:11 ` Matthew Wilcox [this message]
2022-04-06 8:47 ` Miaohe Lin
2022-04-04 22:53 ` Andrew Morton
2022-04-06 8:44 ` Miaohe Lin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Ykr8l0sUOtAa3yUY@casper.infradead.org \
--to=willy@infradead.org \
--cc=akpm@linux-foundation.org \
--cc=david@redhat.com \
--cc=linmiaohe@huawei.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).