From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 52C79C433F5 for ; Tue, 5 Apr 2022 18:45:21 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id B16486B0072; Tue, 5 Apr 2022 14:45:10 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id AC5076B0073; Tue, 5 Apr 2022 14:45:10 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 9662D6B0074; Tue, 5 Apr 2022 14:45:10 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0179.hostedemail.com [216.40.44.179]) by kanga.kvack.org (Postfix) with ESMTP id 8814F6B0072 for ; Tue, 5 Apr 2022 14:45:10 -0400 (EDT) Received: from smtpin19.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id 3D0F9183D9830 for ; Tue, 5 Apr 2022 18:45:00 +0000 (UTC) X-FDA: 79323702360.19.47E96B7 Received: from mail-pf1-f182.google.com (mail-pf1-f182.google.com [209.85.210.182]) by imf19.hostedemail.com (Postfix) with ESMTP id B0E1A1A0005 for ; Tue, 5 Apr 2022 18:44:59 +0000 (UTC) Received: by mail-pf1-f182.google.com with SMTP id b13so331223pfv.0 for ; Tue, 05 Apr 2022 11:44:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=BSTfu4XeI/ClhpJnOxug8bNrs6bcd1vbhIByuk9Td5A=; b=FZ7CzdGv5IqR9igsKF5aVHLB8MfCD2UE6mGhWdabuDVB/PY75CERc0oW45pyoiFFsx HLCOiljgUTbziKvTX7wZRoZqJ+RJ1Dea8AguoZhgeta2AWxRKKUV2iRUL0l0yDbf+TTN ZiAbWnMeeHTkwk1JvBEs7xviif99t4lQdP3rhF94xjjOWUyQ5IYn9ZUuKyguEbSTvM9X MpsV3tSkSRKbWT/1P6uf6AhXj04ePeO0yF7csRuDTu6ucoAxMuJ3t81XHgVFCM4FFTG+ SjX4Baa/CoEtOFP/F5srI+LydtG/vNCqkGlkcYX/sxjcplhmbQiJkxNjpWBgFSDO+Pmx Gc4Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=BSTfu4XeI/ClhpJnOxug8bNrs6bcd1vbhIByuk9Td5A=; b=FfFtLPFYkdmi8JKPmv/9LVVXgbEkIUozinc2DYUIgswxDOQrj9EMhJ8LC7oig2RHLd fqbVMRxC8X365U26ssPbD2fxNFSA3xHPZ4G9VnjYxZlwFmFSt3yY7MKuczJWZwEiKmxh 7hW3q0wofz6EARkMcfEo7ZX1HJrobeR1Xxd8vNZSLPnrkx5ErH5AEaVQBWLoe1wqHV8r Yy1q/UL/f/wC+Y9ClCEgrihw1ql4aMB9f9299a5n0+DHWR3npOQ/aGxrAWQiSRvb6xog NgumqKvOSWZ0X3i8KF9ayj3du9gaznHylPhsm86WoG2DFSpznPoTZdNtDDVaF6z8phfz v/7w== X-Gm-Message-State: AOAM533RIQQ6CNSZAp4t5RxJRpgTO3ySMiJT9jzpZEDAw7EQNafSg9ks WdjjgkOqjv3i24YuAZSRBUmLDQ== X-Google-Smtp-Source: ABdhPJxqBsHYYYQ3r6tsKfeQNVI4VssdMtHw5QBcT84h3Z9HkLEDAYYEQ3XVRsYGURacbMDknChXvg== X-Received: by 2002:a65:57ca:0:b0:381:ea8d:4d1f with SMTP id q10-20020a6557ca000000b00381ea8d4d1fmr4102933pgr.143.1649184298506; Tue, 05 Apr 2022 11:44:58 -0700 (PDT) Received: from google.com (157.214.185.35.bc.googleusercontent.com. [35.185.214.157]) by smtp.gmail.com with ESMTPSA id j70-20020a638b49000000b003985b5ddaa1sm13887990pge.49.2022.04.05.11.44.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 05 Apr 2022 11:44:57 -0700 (PDT) Date: Tue, 5 Apr 2022 18:44:54 +0000 From: Sean Christopherson To: Yosry Ahmed Cc: Huacai Chen , Aleksandar Markovic , Anup Patel , Atish Patra , Paolo Bonzini , Vitaly Kuznetsov , Wanpeng Li , Jim Mattson , Joerg Roedel , mizhang@google.com, David Matlack , kvm@vger.kernel.org, kvm-riscv@lists.infradead.org, linux-mips@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, Shakeel Butt , Andrew Morton Subject: Re: [PATCH v2 0/5] KVM: mm: count KVM page table pages in pagetable stats Message-ID: References: <20220404234154.1251388-1-yosryahmed@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220404234154.1251388-1-yosryahmed@google.com> X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: B0E1A1A0005 X-Rspam-User: Authentication-Results: imf19.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b=FZ7CzdGv; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf19.hostedemail.com: domain of seanjc@google.com designates 209.85.210.182 as permitted sender) smtp.mailfrom=seanjc@google.com X-Stat-Signature: 1aoryfruyjk7jmrdwmqy5pfs7t9ckk5x X-HE-Tag: 1649184299-105583 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000002, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Apr 04, 2022, Yosry Ahmed wrote: > We keep track of several kernel memory stats (total kernel memory, page > tables, stack, vmalloc, etc) on multiple levels (global, per-node, > per-memcg, etc). These stats give insights to users to how much memory > is used by the kernel and for what purposes. > > Currently, memory used by kvm for its page tables is not accounted in > the pagetable stats. This patch series accounts the memory pages used by > KVM for page tables in those stats. It's still not obvious to me that piggybacking NR_PAGETABLE is desirable, probably because I am quite clueless as to how these stats are used on the backend. E.g. why not have a NR_SECONDARY_PAGETABLE entry to track pages used for secondary MMU page tables?