From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4BF2DC433F5 for ; Fri, 8 Apr 2022 14:56:01 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 774126B0072; Fri, 8 Apr 2022 10:56:00 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 6D5D86B0073; Fri, 8 Apr 2022 10:56:00 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 528666B0074; Fri, 8 Apr 2022 10:56:00 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (relay.a.hostedemail.com [64.99.140.24]) by kanga.kvack.org (Postfix) with ESMTP id 3C0BA6B0072 for ; Fri, 8 Apr 2022 10:56:00 -0400 (EDT) Received: from smtpin13.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay11.hostedemail.com (Postfix) with ESMTP id 0B60382B96 for ; Fri, 8 Apr 2022 14:56:00 +0000 (UTC) X-FDA: 79334011680.13.4C5D1FC Received: from mail-qt1-f175.google.com (mail-qt1-f175.google.com [209.85.160.175]) by imf28.hostedemail.com (Postfix) with ESMTP id 8ADD4C0009 for ; Fri, 8 Apr 2022 14:55:59 +0000 (UTC) Received: by mail-qt1-f175.google.com with SMTP id o15so10810434qtv.8 for ; Fri, 08 Apr 2022 07:55:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=RkQdhzMDs8tUm3hby//Hd4ev3pWtbOp3xvInpobyZS4=; b=lrvPVCsfGDkCGwWe+RqJphGmx2SiDaJ/okIVXFr8qJJlv4iQ0V5JkRw7+guRP5MaZw mSDnFKo0tUG8SHb/7TwFtprWvMIxR8/ouU0ZIgADO7mnBVZmIqpXtIXqhxOLaBkQG8Lf MXzCgZYkcqy/gIIW0fdXxdV/4AmvuSD1c0L9oQyKOoAgESKgyuvDqrC3xLPjHwcs6kSI 3gBvM9nBKrAH4VCbo0mws7lAb+6OwhEpHeKM2Q2ymtjm+DXvVzPOBR/r5P1dnjBUVIDL e97dBtSrb3+S3OvirDjNe8NRRCKOtTA52lXeSjeZj+y3RaXdT5vClJ5bg0/IR9EuISIP /wPg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=RkQdhzMDs8tUm3hby//Hd4ev3pWtbOp3xvInpobyZS4=; b=CgI6qzzx9ZQXpitWvgMq+3idSPR254YcgqspVgUg4srcf/0hoQoVgQDZf1E0Z/QmHB /V+lJ56M3m2uaQ27kZ0XkIc9EFOURQPvlZwSvSxwnMAfM0yqgcvR0CHc+BSfj3QWAArD 6Az2RHyPldp411f5e0t1hjTA9Fy92ImtZzUG/7PHhJl0FnBbRz1mdjusQmqtYfAFM6NE 03nm96rLTabIyooTyNVcmxWjeNNBI21QR2lEyN8CfqilMqUSIeHI7DMEbjk1EE7GXpKn y1OEy3Yzho2e9OgjgprybXI7j6czhagpzCO1GuAKiR2sAFM05W/K4MxzKzmLbdMbQS6W Rp0Q== X-Gm-Message-State: AOAM530wO2srzQ5MfSJ+GyQ9H6wXNyL3CUJ8Y+w3YgGjkGCY7HdwRX7D aImvPbsXcux0qfolUlqexmQ= X-Google-Smtp-Source: ABdhPJyFh17N7vhka55fTsXg+zkueUtsdgIx6jfkxsIhhuLZCq7xKih5mgpoDbLVzGhrMIqUs0yCdg== X-Received: by 2002:ac8:7083:0:b0:2eb:b6b9:acec with SMTP id y3-20020ac87083000000b002ebb6b9acecmr16426324qto.465.1649429758703; Fri, 08 Apr 2022 07:55:58 -0700 (PDT) Received: from dschatzberg-fedora-PC0Y6AEN.dhcp.thefacebook.com ([2620:10d:c091:500::2:77ef]) by smtp.gmail.com with ESMTPSA id x82-20020a376355000000b0069b971c58c1sm1411203qkb.60.2022.04.08.07.55.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 08 Apr 2022 07:55:58 -0700 (PDT) Date: Fri, 8 Apr 2022 10:55:56 -0400 From: Dan Schatzberg To: Michal Hocko Cc: Yosry Ahmed , Johannes Weiner , Shakeel Butt , Andrew Morton , Roman Gushchin , David Rientjes , Tejun Heo , Zefan Li , Jonathan Corbet , Shuah Khan , Yu Zhao , Dave Hansen , Wei Xu , Greg Thelen , Chen Wandun , Vaibhav Jain , Michal =?iso-8859-1?Q?Koutn=FD?= , Tim Chen , cgroups@vger.kernel.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-kselftest@vger.kernel.org Subject: Re: [PATCH v3 1/4] memcg: introduce per-memcg reclaim interface Message-ID: References: <20220408045743.1432968-1-yosryahmed@google.com> <20220408045743.1432968-2-yosryahmed@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Stat-Signature: q84pma7mb4i5adcdhccuyz791jxwwy7m X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: 8ADD4C0009 Authentication-Results: imf28.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=lrvPVCsf; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf28.hostedemail.com: domain of schatzberg.dan@gmail.com designates 209.85.160.175 as permitted sender) smtp.mailfrom=schatzberg.dan@gmail.com X-Rspam-User: X-HE-Tag: 1649429759-642962 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, Apr 08, 2022 at 04:11:05PM +0200, Michal Hocko wrote: > Regarding "max" as a possible input. I am not really sure to be honest. > I can imagine that it could be legit to simply reclaim all the charges > (e.g. before removing the memcg) which should be achieveable by > reclaiming the reported consumption. Or what exactly should be the > semantic? Yeah, it just allows you to avoid reading memory.current to just reclaim everything if you can specify "max" - you're still protected by nretries to eventually bail out. Mostly, though I just feel like supporting "max" makes memory.reclaim semetric with a lot of the cgroup memory control files which tend to support "max".