From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6017AC433F5 for ; Sat, 9 Apr 2022 05:30:03 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C7A0C6B0071; Sat, 9 Apr 2022 01:30:02 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id C297D6B0073; Sat, 9 Apr 2022 01:30:02 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id AF09D6B0074; Sat, 9 Apr 2022 01:30:02 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0241.hostedemail.com [216.40.44.241]) by kanga.kvack.org (Postfix) with ESMTP id A06196B0071 for ; Sat, 9 Apr 2022 01:30:02 -0400 (EDT) Received: from smtpin27.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id 4B7E5A943F for ; Sat, 9 Apr 2022 05:30:02 +0000 (UTC) X-FDA: 79336214244.27.0C004C7 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) by imf19.hostedemail.com (Postfix) with ESMTP id AFED61A0002 for ; Sat, 9 Apr 2022 05:30:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=uEG2MKXQ98jQrWXToE6ot4EvMQfzWhFTcG5zPELpfkw=; b=i/DfEgfFWLhtkNMcAC7OtyYMi0 lQXlSJ9z2iM8Q3MH9/OzRDsa0nau7wmeuOmahHu9176dNhJinpDIZeOlMN+IQr834zo+bBBJ3LzS7 ealAt3ZOfUPvDynJNB22ChhLCdg3FEWCfunBX2hX6uelUoY6ptJRqg+PYIT45pwwonHNhV1Tzo1sG y2Ful07FjqabyBLg/C+kZoZaM1ee/Sw3pjcAKF5aEZWAHmnsvQ7yxizu3dyVBuHqL7GR9bl36yaVn nMwVs40au193qTFmD5aeZ+3Ii1+DHBb6fKJXDxWRLd34YGovI3NL6yAX9Iw5av4M5xT0q0/UQQPAc qrZnBvMw==; Received: from hch by bombadil.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1nd3fb-002JpG-EJ; Sat, 09 Apr 2022 05:29:59 +0000 Date: Fri, 8 Apr 2022 22:29:59 -0700 From: Christoph Hellwig To: Song Liu Cc: bpf@vger.kernel.org, netdev@vger.kernel.org, linux-mm@kvack.org, ast@kernel.org, daniel@iogearbox.net, andrii@kernel.org, kernel-team@fb.com, akpm@linux-foundation.org, rick.p.edgecombe@intel.com, hch@infradead.org, imbrenda@linux.ibm.com Subject: Re: [PATCH bpf 2/2] bpf: use vmalloc with VM_ALLOW_HUGE_VMAP for bpf_prog_pack Message-ID: References: <20220408223443.3303509-1-song@kernel.org> <20220408223443.3303509-3-song@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220408223443.3303509-3-song@kernel.org> X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html X-Stat-Signature: t9p5bsqkwxsjnnod84rhhi5kf8wqwjod Authentication-Results: imf19.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b="i/DfEgfF"; dmarc=none; spf=none (imf19.hostedemail.com: domain of BATV+43fc5532e856fea764d1+6803+infradead.org+hch@bombadil.srs.infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=BATV+43fc5532e856fea764d1+6803+infradead.org+hch@bombadil.srs.infradead.org X-Rspam-User: X-Rspamd-Server: rspam11 X-Rspamd-Queue-Id: AFED61A0002 X-HE-Tag: 1649482201-765724 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, Apr 08, 2022 at 03:34:43PM -0700, Song Liu wrote: > +static void *bpf_prog_pack_vmalloc(unsigned long size) > +{ > +#if defined(MODULES_VADDR) > + unsigned long start = MODULES_VADDR; > + unsigned long end = MODULES_END; > +#else > + unsigned long start = VMALLOC_START; > + unsigned long end = VMALLOC_END; > +#endif > + > + return __vmalloc_node_range(size, PAGE_SIZE, start, end, GFP_KERNEL, PAGE_KERNEL, > + VM_DEFER_KMEMLEAK | VM_ALLOW_HUGE_VMAP, > + NUMA_NO_NODE, __builtin_return_address(0)); > +} Instead of having this magic in bpf I think a module_alloc_large would seems like the better interface here.