From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 33D9EC433EF for ; Sun, 10 Apr 2022 07:42:21 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 6EF236B0071; Sun, 10 Apr 2022 03:42:20 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 69CE26B0073; Sun, 10 Apr 2022 03:42:20 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 564A96B0074; Sun, 10 Apr 2022 03:42:20 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0064.hostedemail.com [216.40.44.64]) by kanga.kvack.org (Postfix) with ESMTP id 476236B0071 for ; Sun, 10 Apr 2022 03:42:20 -0400 (EDT) Received: from smtpin21.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id EF727AA23B for ; Sun, 10 Apr 2022 07:42:19 +0000 (UTC) X-FDA: 79340176398.21.A79BC71 Received: from mail-pl1-f170.google.com (mail-pl1-f170.google.com [209.85.214.170]) by imf28.hostedemail.com (Postfix) with ESMTP id 772E0C0008 for ; Sun, 10 Apr 2022 07:42:19 +0000 (UTC) Received: by mail-pl1-f170.google.com with SMTP id n8so11433351plh.1 for ; Sun, 10 Apr 2022 00:42:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=cSXw+XVYOoX2G7IopQ/sIWz/YQYFoZXQ3ZmEBf6FWSM=; b=HpxHKRU2aoHfoFqFL83nSo0hUqwoFOEviIl5QHGVndY2acZcZC1lvJiuQkznBuSY6y R2c1aZV7JW3jZB4kmcRDqXiJGkYhHb2wTFvltgURNixUpkLQ6wF701ibEmM118PD+w6i EEcMjqFqkGLTRDqEL3X7eATLmFbiy9rZE0UK2IslN50mYTzAcz2eyjcVn6L6GQqub96N VIg4wL+2KLzlMFJNLhTl6tVsoICvejpW8/QeA88BpqNLPbq5x6epmOITXgwUS4r2DlNx 3c2byneqiiiDt+MYO7p6twH9+3Ghz2TN4EvwTDWh3JQX4QFhfYtqVvOWJGLgcbLcJ+Qi wzNw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=cSXw+XVYOoX2G7IopQ/sIWz/YQYFoZXQ3ZmEBf6FWSM=; b=UUTj8epBhFxU2+hjCvJ5kJCjzbdyk37596ZWfHvLQuRxIYcuZkew7/q0v6ZINfEHHd ICUpFxeyjk7AequGQf8zmHdif9jps29Dn/QgDgNARrdoUiwdsawd/tWjdJSkegc06ICX TxkUESXKEfymNY5IfP5LIyOM80Cc2OsuOsCKhDdVwxU4/HqTH4VTDRqZSN/QXUE8igIc Z+kE27DdCfByKOUj9ldZnscEJS9npWA/DPVMl08/htlPz+BLH1GedEjcmbWwhawHnX2r 4UkUGv6uc54TVw8zztavSIf45IKvdZ/3sVVyA+JyuVjT0OoaKTUVknp2RwfyozeLW6jV 1mJw== X-Gm-Message-State: AOAM532dEosyXDZS1RFIKMkxlsggqC/D+oKRWuOQx+2TmDo0dLUWdtCb Q2KN0m95RxxvSwmTaht221U= X-Google-Smtp-Source: ABdhPJz1R7lcKspCAXdSnT/AtJp8Obuzx7gzxJj0iY67kpevyLxwvwEzljeNPVcvLWpn2/znIyjXlg== X-Received: by 2002:a17:902:a710:b0:156:5650:f94a with SMTP id w16-20020a170902a71000b001565650f94amr26471202plq.86.1649576538467; Sun, 10 Apr 2022 00:42:18 -0700 (PDT) Received: from hyeyoo ([114.29.24.243]) by smtp.gmail.com with ESMTPSA id z10-20020a17090a8b8a00b001ca7bafba51sm15750166pjn.0.2022.04.10.00.42.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 10 Apr 2022 00:42:17 -0700 (PDT) Date: Sun, 10 Apr 2022 16:42:08 +0900 From: Hyeonggon Yoo <42.hyeyoo@gmail.com> To: Jiyoup Kim Cc: Christoph Lameter , Pekka Enberg , David Rientjes , Joonsoo Kim , Andrew Morton , Vlastimil Babka , Ohhoon Kwon , JaeSang Yoo , Wonhyuk Yang , Donghyeok Kim , linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] mm/slub: remove duplicate flag in allocate_slab() Message-ID: References: <20220409150538.1264-1-lakroforce@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220409150538.1264-1-lakroforce@gmail.com> X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: 772E0C0008 X-Stat-Signature: npwshdt9jxgmikwgnpp8crpw79grchqb Authentication-Results: imf28.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=HpxHKRU2; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf28.hostedemail.com: domain of 42.hyeyoo@gmail.com designates 209.85.214.170 as permitted sender) smtp.mailfrom=42.hyeyoo@gmail.com X-Rspam-User: X-HE-Tag: 1649576539-661014 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Sun, Apr 10, 2022 at 12:05:37AM +0900, Jiyoup Kim wrote: > In allocate_slab(), __GFP_NOFAIL flag is removed twice when trying > higher-order allocation. Remove it. > > Signed-off-by: Jiyoup Kim > --- > mm/slub.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/mm/slub.c b/mm/slub.c > index 74d92aa4a3a2..a0e605ab3036 100644 > --- a/mm/slub.c > +++ b/mm/slub.c > @@ -1939,7 +1939,7 @@ static struct slab *allocate_slab(struct kmem_cache *s, gfp_t flags, int node) > */ > alloc_gfp = (flags | __GFP_NOWARN | __GFP_NORETRY) & ~__GFP_NOFAIL; > if ((alloc_gfp & __GFP_DIRECT_RECLAIM) && oo_order(oo) > oo_order(s->min)) > - alloc_gfp = (alloc_gfp | __GFP_NOMEMALLOC) & ~(__GFP_RECLAIM|__GFP_NOFAIL); > + alloc_gfp = (alloc_gfp | __GFP_NOMEMALLOC) & ~__GFP_RECLAIM; > > slab = alloc_slab_page(alloc_gfp, node, oo); > if (unlikely(!slab)) { Looks good to me. Reviewed-by: Hyeonggon Yoo <42.hyeyoo@gmail.com> Thanks! > -- > 2.25.1 > > -- Thanks, Hyeonggon