linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: Christoph Hellwig <hch@infradead.org>
To: Shiyang Ruan <ruansy.fnst@fujitsu.com>
Cc: linux-kernel@vger.kernel.org, linux-xfs@vger.kernel.org,
	nvdimm@lists.linux.dev, linux-mm@kvack.org,
	linux-fsdevel@vger.kernel.org, djwong@kernel.org,
	dan.j.williams@intel.com, david@fromorbit.com, hch@infradead.org,
	jane.chu@oracle.com, Christoph Hellwig <hch@lst.de>
Subject: Re: [PATCH v12 2/7] mm: factor helpers for memory_failure_dev_pagemap
Date: Sun, 10 Apr 2022 23:37:19 -0700	[thread overview]
Message-ID: <YlPMn2DjbqzAVhrb@infradead.org> (raw)
In-Reply-To: <20220410160904.3758789-3-ruansy.fnst@fujitsu.com>

> +	unmap_and_kill(&to_kill, pfn, page->mapping, page->index, flags);
> +unlock:
> +	dax_unlock_page(page, cookie);
> +	return 0;

As the buildbot points out this should probably be a "return rc".


  parent reply	other threads:[~2022-04-11  6:37 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-04-10 16:08 [PATCH v12 0/7] fsdax: introduce fs query to support reflink Shiyang Ruan
2022-04-10 16:08 ` [PATCH v12 1/7] dax: Introduce holder for dax_device Shiyang Ruan
2022-04-11  6:35   ` Christoph Hellwig
2022-04-12 23:22   ` Dan Williams
2022-04-10 16:08 ` [PATCH v12 2/7] mm: factor helpers for memory_failure_dev_pagemap Shiyang Ruan
2022-04-10 19:48   ` kernel test robot
2022-04-10 20:19   ` kernel test robot
2022-04-11  6:37   ` Christoph Hellwig [this message]
2022-04-11  9:39     ` Shiyang Ruan
2022-04-10 16:09 ` [PATCH v12 3/7] pagemap,pmem: Introduce ->memory_failure() Shiyang Ruan
2022-04-10 16:09 ` [PATCH v12 4/7] fsdax: Introduce dax_lock_mapping_entry() Shiyang Ruan
2022-04-10 16:09 ` [PATCH v12 5/7] mm: Introduce mf_dax_kill_procs() for fsdax case Shiyang Ruan
2022-04-11  6:40   ` wangjianjian (C)
2022-04-11  9:40     ` Shiyang Ruan
2022-04-10 16:09 ` [PATCH v12 6/7] xfs: Implement ->notify_failure() for XFS Shiyang Ruan
2022-04-10 18:58   ` kernel test robot
2022-04-10 23:54   ` kernel test robot
2022-04-11  6:39   ` Christoph Hellwig
2022-04-13  0:04   ` Dave Chinner
2022-04-13  2:06     ` Dan Williams
2022-04-13  6:09       ` Dave Chinner
2022-04-13 17:09         ` Dan Williams
2022-04-13 17:12           ` Christoph Hellwig
2022-04-14 13:22   ` [xfs] bf68be0c39: BUG:KASAN:null-ptr-deref_in_fs_put_dax kernel test robot
2022-04-10 16:09 ` [PATCH v12 7/7] fsdax: set a CoW flag when associate reflink mappings Shiyang Ruan
2022-04-11  6:55   ` Christoph Hellwig

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YlPMn2DjbqzAVhrb@infradead.org \
    --to=hch@infradead.org \
    --cc=dan.j.williams@intel.com \
    --cc=david@fromorbit.com \
    --cc=djwong@kernel.org \
    --cc=hch@lst.de \
    --cc=jane.chu@oracle.com \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=linux-xfs@vger.kernel.org \
    --cc=nvdimm@lists.linux.dev \
    --cc=ruansy.fnst@fujitsu.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).