From: Christoph Hellwig <hch@infradead.org>
To: Shiyang Ruan <ruansy.fnst@fujitsu.com>
Cc: linux-kernel@vger.kernel.org, linux-xfs@vger.kernel.org,
nvdimm@lists.linux.dev, linux-mm@kvack.org,
linux-fsdevel@vger.kernel.org, djwong@kernel.org,
dan.j.williams@intel.com, david@fromorbit.com, hch@infradead.org,
jane.chu@oracle.com
Subject: Re: [RFC PATCH] mm, pmem, xfs: Introduce MF_MEM_REMOVE for unbind
Date: Mon, 11 Apr 2022 00:06:17 -0700 [thread overview]
Message-ID: <YlPTaexutZrus1kQ@infradead.org> (raw)
In-Reply-To: <20220410171623.3788004-1-ruansy.fnst@fujitsu.com>
On Mon, Apr 11, 2022 at 01:16:23AM +0800, Shiyang Ruan wrote:
> diff --git a/drivers/nvdimm/pmem.c b/drivers/nvdimm/pmem.c
> index bd502957cfdf..72d9e69aea98 100644
> --- a/drivers/nvdimm/pmem.c
> +++ b/drivers/nvdimm/pmem.c
> @@ -359,7 +359,6 @@ static void pmem_release_disk(void *__pmem)
> struct pmem_device *pmem = __pmem;
>
> dax_remove_host(pmem->disk);
> - kill_dax(pmem->dax_dev);
> put_dax(pmem->dax_dev);
> del_gendisk(pmem->disk);
>
> @@ -597,6 +596,8 @@ static void nd_pmem_remove(struct device *dev)
> pmem->bb_state = NULL;
> }
> nvdimm_flush(to_nd_region(dev->parent), NULL);
> +
> + kill_dax(pmem->dax_dev);
I think the put_dax will have to move as well.
This part should probably also be a separate, well-documented
cleanup patch.
next prev parent reply other threads:[~2022-04-11 7:06 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-10 17:16 [RFC PATCH] mm, pmem, xfs: Introduce MF_MEM_REMOVE for unbind Shiyang Ruan
2022-04-11 7:06 ` Christoph Hellwig [this message]
2022-05-20 5:18 ` Shiyang Ruan
2022-05-20 5:37 ` [RFC PATCH v2] " Shiyang Ruan
2022-06-15 12:54 ` [RFC PATCH v3] " Shiyang Ruan
2022-06-22 16:49 ` Darrick J. Wong
2022-06-24 1:51 ` Shiyang Ruan
2022-07-03 13:08 ` [RFC PATCH v4] " Shiyang Ruan
2022-07-05 17:26 ` Darrick J. Wong
2022-07-08 5:42 ` [RFC PATCH v5] " ruansy.fnst
2022-07-08 15:28 ` Darrick J. Wong
2022-07-14 10:34 ` [RFC PATCH v6] " ruansy.fnst
2022-07-14 17:54 ` Darrick J. Wong
2022-07-14 18:21 ` Dan Williams
2022-07-18 22:13 ` Darrick J. Wong
2022-07-18 22:56 ` Dan Williams
2022-08-03 2:43 ` ruansy.fnst
2022-08-03 4:33 ` Darrick J. Wong
2022-08-18 11:19 ` Shiyang Ruan
2022-08-18 17:04 ` Darrick J. Wong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YlPTaexutZrus1kQ@infradead.org \
--to=hch@infradead.org \
--cc=dan.j.williams@intel.com \
--cc=david@fromorbit.com \
--cc=djwong@kernel.org \
--cc=jane.chu@oracle.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-xfs@vger.kernel.org \
--cc=nvdimm@lists.linux.dev \
--cc=ruansy.fnst@fujitsu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).