From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id CFF05C433EF for ; Mon, 11 Apr 2022 14:10:20 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 638B86B0073; Mon, 11 Apr 2022 10:10:20 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 5EAAF6B0074; Mon, 11 Apr 2022 10:10:20 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 4D7396B0075; Mon, 11 Apr 2022 10:10:20 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (relay.a.hostedemail.com [64.99.140.24]) by kanga.kvack.org (Postfix) with ESMTP id 3FF1B6B0073 for ; Mon, 11 Apr 2022 10:10:20 -0400 (EDT) Received: from smtpin19.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 1B8392342C for ; Mon, 11 Apr 2022 14:10:20 +0000 (UTC) X-FDA: 79344783000.19.54CDB0D Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) by imf18.hostedemail.com (Postfix) with ESMTP id 917431C0009 for ; Mon, 11 Apr 2022 14:10:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=zSE3hyVO7DFjxq33qgn4/OBAbkzMg5A0QRViTX6+0XQ=; b=UOWQTw7zs/BDaXgkh9KjInv+NC E4AiAtGrvY9b/FNmtWco5EwBkUyi2yjkpnpFCMEmHsmgCGw51ABGXRtyL4ybPLg5WUm1s56tpBFlG /cRzRD15I7MkyRDWeb5+SLiY0SJJaA3+i6R4+p4YBXpTU+esdNDiu8hkOoaFB716WnYyF+/AQyEAs uuHKm22bVICD996LR/QyVemuZ2yvA332g+j64g4ESLz8vJB/CgqnuwdbDX5Mc6LoFxmU/366GjUd6 k3a1ViBZNvR1qGhomBTZRphvvb+0oPXCmvJ/yEXGAKvzgaHYLoT+MQZyv9j3QdU20l2QIc5Tdmwy7 jOONDsQQ==; Received: from hch by bombadil.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1ndujt-009JJB-4a; Mon, 11 Apr 2022 14:09:57 +0000 Date: Mon, 11 Apr 2022 07:09:57 -0700 From: Christoph Hellwig To: Miaohe Lin Cc: akpm@linux-foundation.org, mike.kravetz@oracle.com, shy828301@gmail.com, willy@infradead.org, ying.huang@intel.com, ziy@nvidia.com, minchan@kernel.org, apopple@nvidia.com, dave.hansen@linux.intel.com, o451686892@gmail.com, jhubbard@nvidia.com, peterx@redhat.com, naoya.horiguchi@nec.com, mhocko@suse.com, riel@redhat.com, osalvador@suse.de, david@redhat.com, sfr@canb.auug.org.au, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/4] mm/migration: remove unneeded lock page and PageMovable check Message-ID: References: <20220409073846.22286-1-linmiaohe@huawei.com> <20220409073846.22286-3-linmiaohe@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220409073846.22286-3-linmiaohe@huawei.com> X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html Authentication-Results: imf18.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=UOWQTw7z; spf=none (imf18.hostedemail.com: domain of BATV+28f505242231dd703457+6805+infradead.org+hch@bombadil.srs.infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=BATV+28f505242231dd703457+6805+infradead.org+hch@bombadil.srs.infradead.org; dmarc=none X-Rspam-User: X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: 917431C0009 X-Stat-Signature: izamdqr6ifyqnxco3qkhq7ttpkybfekj X-HE-Tag: 1649686219-837072 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Sat, Apr 09, 2022 at 03:38:44PM +0800, Miaohe Lin wrote: > When non-lru movable page was freed from under us, __ClearPageMovable must > have been done. Even if it's not done, ClearPageIsolated here won't hurt > as page will be freed anyway. So we can thus remove unneeded lock page and > PageMovable check here. > > Signed-off-by: Miaohe Lin Looks good: Reviewed-by: Christoph Hellwig