From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 763C0C433FE for ; Mon, 11 Apr 2022 14:17:06 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id EBD346B0072; Mon, 11 Apr 2022 10:17:05 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id E6D0C6B0073; Mon, 11 Apr 2022 10:17:05 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D33DF6B0074; Mon, 11 Apr 2022 10:17:05 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (relay.hostedemail.com [64.99.140.26]) by kanga.kvack.org (Postfix) with ESMTP id C39396B0072 for ; Mon, 11 Apr 2022 10:17:05 -0400 (EDT) Received: from smtpin16.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay11.hostedemail.com (Postfix) with ESMTP id 8DFCA8107B for ; Mon, 11 Apr 2022 14:17:05 +0000 (UTC) X-FDA: 79344800010.16.3DE2316 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) by imf13.hostedemail.com (Postfix) with ESMTP id 2602920003 for ; Mon, 11 Apr 2022 14:17:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=EoFq52mSAifW7hmuVJnEyfr/qKi5kNzEY/xR+93cmVg=; b=ZYGRV0W++ZoliBjPm8B/gRwIu4 yAha5BgUDGee0KMNCZBqDJOA+BzqF0ms9akjt1wPKXlqpSMGBLVI4icLCVOaijECDLG42o9pwoSXo o0hMZnSSZl3f8HP7oXjaF8INUytI/Y7TV/z6CFTuiWgHcnlOOjj9E87a0rNQMqXkpgz3o0MpldTiC ZIzDNVxdScS0OqZipt3YNOzaUVI7ItPQdX96u7P7w0w058N3KnvSc9BB3VtrVZVgVn+0zqPTuoUaM +EtgkgmNXDrUQ2v3YZbMTJKlgwbSB5U/aWpsktKKjYazh5AsR2WUGg+PIKa6xxIDx50xZrC2pXiRj 0oyLBqtg==; Received: from hch by bombadil.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1nduqg-009Lde-5Y; Mon, 11 Apr 2022 14:16:58 +0000 Date: Mon, 11 Apr 2022 07:16:58 -0700 From: Christoph Hellwig To: Miaohe Lin Cc: akpm@linux-foundation.org, ying.huang@intel.com, songmuchun@bytedance.com, hch@infradead.org, willy@infradead.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 1/9] mm/vmscan: add a comment about MADV_FREE pages check in folio_check_dirty_writeback Message-ID: References: <20220409093500.10329-1-linmiaohe@huawei.com> <20220409093500.10329-2-linmiaohe@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220409093500.10329-2-linmiaohe@huawei.com> X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html X-Stat-Signature: xh4i8wrn7o9tq9g14og8a8usey3xkp7z X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: 2602920003 Authentication-Results: imf13.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=ZYGRV0W+; dmarc=none; spf=none (imf13.hostedemail.com: domain of BATV+28f505242231dd703457+6805+infradead.org+hch@bombadil.srs.infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=BATV+28f505242231dd703457+6805+infradead.org+hch@bombadil.srs.infradead.org X-Rspam-User: X-HE-Tag: 1649686624-931235 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Sat, Apr 09, 2022 at 05:34:52PM +0800, Miaohe Lin wrote: > The MADV_FREE pages check in folio_check_dirty_writeback is a bit hard to > follow. Add a comment to make the code clear. > > Suggested-by: Huang, Ying > Signed-off-by: Miaohe Lin > --- > mm/vmscan.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/mm/vmscan.c b/mm/vmscan.c > index c77d5052f230..4a76be47bed1 100644 > --- a/mm/vmscan.c > +++ b/mm/vmscan.c > @@ -1436,6 +1436,9 @@ static void folio_check_dirty_writeback(struct folio *folio, > /* > * Anonymous pages are not handled by flushers and must be written > * from reclaim context. Do not stall reclaim based on them While you touch this please add a period at the end of the above sentence. Otherwise looks good: Reviewed-by: Christoph Hellwig