From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id DBC22C433EF for ; Tue, 12 Apr 2022 08:44:12 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 327A96B0078; Tue, 12 Apr 2022 04:44:12 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 2D7C96B007B; Tue, 12 Apr 2022 04:44:12 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 179706B007D; Tue, 12 Apr 2022 04:44:12 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (relay.hostedemail.com [64.99.140.28]) by kanga.kvack.org (Postfix) with ESMTP id 04E326B0078 for ; Tue, 12 Apr 2022 04:44:12 -0400 (EDT) Received: from smtpin15.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id D0994246DA for ; Tue, 12 Apr 2022 08:44:11 +0000 (UTC) X-FDA: 79347589902.15.28A1BE9 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by imf25.hostedemail.com (Postfix) with ESMTP id D37FBA0007 for ; Tue, 12 Apr 2022 08:44:10 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id C08A0210E3; Tue, 12 Apr 2022 08:44:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1649753049; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=AQYiTIlabf0XPtoPR35Y9NtmPHuTSnD6Vh/HNYD4peM=; b=hRp7dEi/PsACelp54CQ1OBM6kEU8Gq6Tq7X0cezfJ0+DoyVl5/vae1o9Go+bJo8xo9hW3/ sZEIthWT8iIF3bNQroY/FyUGWNmFFYqrZ2g8rPfPOspll1zvi8v2lrAeupYrCIXzGW+xMr EA7bGKoKu+DS2mtMvDEnbYaT3dWYhsg= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1649753049; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=AQYiTIlabf0XPtoPR35Y9NtmPHuTSnD6Vh/HNYD4peM=; b=ZAqAzxWwTvuJtGRDX6871BgcbJJkKIBnnPUy470p68hDLtvLo5cRLxelCwTP25rlupgOpC R+qqaLav1sRsfJCg== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 28E8E13780; Tue, 12 Apr 2022 08:44:09 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id 31QQBtk7VWIUGwAAMHmgww (envelope-from ); Tue, 12 Apr 2022 08:44:09 +0000 Date: Tue, 12 Apr 2022 10:44:07 +0200 From: Oscar Salvador To: Miaohe Lin Cc: akpm@linux-foundation.org, ying.huang@intel.com, songmuchun@bytedance.com, hch@infradead.org, willy@infradead.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 1/9] mm/vmscan: add a comment about MADV_FREE pages check in folio_check_dirty_writeback Message-ID: References: <20220409093500.10329-1-linmiaohe@huawei.com> <20220409093500.10329-2-linmiaohe@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220409093500.10329-2-linmiaohe@huawei.com> X-Stat-Signature: ner9r9s5xdj1csuqnk53neetydmays1f Authentication-Results: imf25.hostedemail.com; dkim=pass header.d=suse.de header.s=susede2_rsa header.b="hRp7dEi/"; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=ZAqAzxWw; dmarc=pass (policy=none) header.from=suse.de; spf=pass (imf25.hostedemail.com: domain of osalvador@suse.de designates 195.135.220.28 as permitted sender) smtp.mailfrom=osalvador@suse.de X-Rspam-User: X-Rspamd-Server: rspam11 X-Rspamd-Queue-Id: D37FBA0007 X-HE-Tag: 1649753050-489641 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Sat, Apr 09, 2022 at 05:34:52PM +0800, Miaohe Lin wrote: > The MADV_FREE pages check in folio_check_dirty_writeback is a bit hard to > follow. Add a comment to make the code clear. > > Suggested-by: Huang, Ying > Signed-off-by: Miaohe Lin Reviewed-by: Oscar Salvador -- Oscar Salvador SUSE Labs