From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 29906C433EF for ; Fri, 15 Apr 2022 07:52:14 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 5E95A6B0071; Fri, 15 Apr 2022 03:52:13 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 598F96B0073; Fri, 15 Apr 2022 03:52:13 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 460BF6B0074; Fri, 15 Apr 2022 03:52:13 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (relay.hostedemail.com [64.99.140.27]) by kanga.kvack.org (Postfix) with ESMTP id 33A786B0071 for ; Fri, 15 Apr 2022 03:52:13 -0400 (EDT) Received: from smtpin15.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 24AA32625C for ; Fri, 15 Apr 2022 07:52:13 +0000 (UTC) X-FDA: 79358345346.15.900D211 Received: from fornost.hmeau.com (helcar.hmeau.com [216.24.177.18]) by imf10.hostedemail.com (Postfix) with ESMTP id E2828C0006 for ; Fri, 15 Apr 2022 07:52:11 +0000 (UTC) Received: from gwarestrin.arnor.me.apana.org.au ([192.168.103.7]) by fornost.hmeau.com with smtp (Exim 4.94.2 #2 (Debian)) id 1nfGkE-003DzD-BD; Fri, 15 Apr 2022 17:51:55 +1000 Received: by gwarestrin.arnor.me.apana.org.au (sSMTP sendmail emulation); Fri, 15 Apr 2022 15:51:54 +0800 Date: Fri, 15 Apr 2022 15:51:54 +0800 From: Herbert Xu To: Ard Biesheuvel Cc: Catalin Marinas , Will Deacon , Marc Zyngier , Arnd Bergmann , Greg Kroah-Hartman , Andrew Morton , Linus Torvalds , Linux Memory Management List , Linux ARM , Linux Kernel Mailing List , "David S. Miller" Subject: Re: [PATCH 07/10] crypto: Use ARCH_DMA_MINALIGN instead of ARCH_KMALLOC_MINALIGN Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Stat-Signature: tkjb3pmjztizd843u7mwzsb8fz5zzdr7 X-Rspam-User: Authentication-Results: imf10.hostedemail.com; dkim=none; dmarc=none; spf=pass (imf10.hostedemail.com: domain of herbert@gondor.apana.org.au designates 216.24.177.18 as permitted sender) smtp.mailfrom=herbert@gondor.apana.org.au X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: E2828C0006 X-HE-Tag: 1650009131-417210 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, Apr 15, 2022 at 09:49:12AM +0200, Ard Biesheuvel wrote: > > I'm not sure I understand what would go wrong if that assumption no > longer holds. It's very simple, we don't do anything to the pointer returned by kmalloc before returning it as a tfm or other object with an alignment of CRYPTO_MINALIGN. IOW if kmalloc starts returning pointers that are not aligned to CRYPTO_MINALIGN then we'd be lying to the compiler. Cheers, -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt