From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id E74FBC433F5 for ; Sun, 17 Apr 2022 08:58:43 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 5EA036B0072; Sun, 17 Apr 2022 04:58:43 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 599786B0073; Sun, 17 Apr 2022 04:58:43 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 4605E6B0074; Sun, 17 Apr 2022 04:58:43 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (relay.hostedemail.com [64.99.140.25]) by kanga.kvack.org (Postfix) with ESMTP id 329216B0072 for ; Sun, 17 Apr 2022 04:58:43 -0400 (EDT) Received: from smtpin08.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id E9AF2203C5 for ; Sun, 17 Apr 2022 08:58:42 +0000 (UTC) X-FDA: 79365770484.08.CED299A Received: from fornost.hmeau.com (helcar.hmeau.com [216.24.177.18]) by imf15.hostedemail.com (Postfix) with ESMTP id 51C44A0002 for ; Sun, 17 Apr 2022 08:58:42 +0000 (UTC) Received: from gwarestrin.arnor.me.apana.org.au ([192.168.103.7]) by fornost.hmeau.com with smtp (Exim 4.94.2 #2 (Debian)) id 1ng0jk-003jh6-NN; Sun, 17 Apr 2022 18:58:30 +1000 Received: by gwarestrin.arnor.me.apana.org.au (sSMTP sendmail emulation); Sun, 17 Apr 2022 16:58:29 +0800 Date: Sun, 17 Apr 2022 16:58:29 +0800 From: Herbert Xu To: Catalin Marinas Cc: Ard Biesheuvel , Will Deacon , Marc Zyngier , Arnd Bergmann , Greg Kroah-Hartman , Andrew Morton , Linus Torvalds , Linux Memory Management List , Linux ARM , Linux Kernel Mailing List , "David S. Miller" Subject: Re: [PATCH 07/10] crypto: Use ARCH_DMA_MINALIGN instead of ARCH_KMALLOC_MINALIGN Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Authentication-Results: imf15.hostedemail.com; dkim=none; dmarc=none; spf=pass (imf15.hostedemail.com: domain of herbert@gondor.apana.org.au designates 216.24.177.18 as permitted sender) smtp.mailfrom=herbert@gondor.apana.org.au X-Rspam-User: X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: 51C44A0002 X-Stat-Signature: qgt7311fyh8tzhqnj86zk87ss85qth6d X-HE-Tag: 1650185922-439609 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Sun, Apr 17, 2022 at 09:50:50AM +0100, Catalin Marinas wrote: > > Right, if that's what you prefer. Something like: > > diff --git a/include/linux/crypto.h b/include/linux/crypto.h > index 2324ab6f1846..bb645b2f2718 100644 > --- a/include/linux/crypto.h > +++ b/include/linux/crypto.h > @@ -645,7 +645,7 @@ struct crypto_tfm { > > struct crypto_alg *__crt_alg; > > - void *__crt_ctx[] CRYPTO_MINALIGN_ATTR; > + void *__crt_ctx[] __aligned(ARCH_DMA_MINALIGN); > }; > > But once we do that, are there any other CRYPTO_MINALIGN left around? This is still implying the whole structure is aligned to the given value, which it is not. Please just add the padding as needed. Cheers, -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt