From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 86B2CC433F5 for ; Tue, 26 Apr 2022 19:14:58 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 04AE36B0073; Tue, 26 Apr 2022 15:14:58 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id F3B886B0074; Tue, 26 Apr 2022 15:14:57 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E2A8B6B0075; Tue, 26 Apr 2022 15:14:57 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (relay.hostedemail.com [64.99.140.25]) by kanga.kvack.org (Postfix) with ESMTP id CF2006B0073 for ; Tue, 26 Apr 2022 15:14:57 -0400 (EDT) Received: from smtpin22.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id A6B7120CF0 for ; Tue, 26 Apr 2022 19:14:57 +0000 (UTC) X-FDA: 79399982634.22.7B0CEE4 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf11.hostedemail.com (Postfix) with ESMTP id 84A3F4004C for ; Tue, 26 Apr 2022 19:14:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=+rijnMzV1mnbw2T3L6iBdqyAVx2tQONoMYJwvaCPRt4=; b=BJW1QGbJBdtuQ2DD2N2D5LtBHW tNtlVjT+HUsI2U09Vx2M8G3r9E7MaNHVMAJh9a9QwRVqHN6yLNGWUVdvyjKHHUYasTP99r0upmWFc anWu53hjJz1F7AekAZgUlgwdYyKDF2VR3MwJ24ZTOwjEIy7oLSd4IpuRgHYgxaqitxginr7WDiZpU ginnp936bH2Yy2zLiRrk5PCYr1DE1xgo3xztNaS2WFuzmh7Y8t96OHW38zfvECx8oFmJdS3/ZBlXV pm3S1wabFKAIh9ScTpO8ZDMAe3vr5I+NRvj/2+aIKJSdKpJPMVGChOOvyosZwMCc5oO52R5yr0TrG NT8QE6OA==; Received: from willy by casper.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1njQe8-009vx4-3r; Tue, 26 Apr 2022 19:14:48 +0000 Date: Tue, 26 Apr 2022 20:14:48 +0100 From: Matthew Wilcox To: Jagdish Gediya Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, ying.huang@intel.com, dave.hansen@intel.com, Jonathan.Cameron@huawei.com, adobriyan@gmail.com, akpm@linux-foundation.org, andriy.shevchenko@linux.intel.com, rf@opensource.cirrus.com, pmladek@suse.com Subject: Re: [PATCH v3 1/2] lib/kstrtox.c: Add "false"/"true" support to kstrtobool() Message-ID: References: <20220426180203.70782-1-jvgediya@linux.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220426180203.70782-1-jvgediya@linux.ibm.com> X-Stat-Signature: susm5m1ba3oaxen3nyyup73abcgoxkpe X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: 84A3F4004C Authentication-Results: imf11.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=BJW1QGbJ; spf=none (imf11.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none X-Rspam-User: X-HE-Tag: 1651000494-996180 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Apr 26, 2022 at 11:32:02PM +0530, Jagdish Gediya wrote: > Signed-off-by: Jagdish Gediya > Reviewed-by: Matthew Wilcox (Oracle) HEY! You still have the buggy IFF -> IF change. FIX IT. My R-b was very clearly conditional on you fixing it. > - * This routine returns 0 iff the first character is one of 'Yy1Nn0', or > + * This routine returns 0 if the first character is one of 'YyTt1NnFf0', or