From: Jagdish Gediya <jvgediya@linux.ibm.com>
To: Matthew Wilcox <willy@infradead.org>
Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org,
ying.huang@intel.com, dave.hansen@intel.com,
Jonathan.Cameron@huawei.com, adobriyan@gmail.com,
akpm@linux-foundation.org, andriy.shevchenko@linux.intel.com,
rf@opensource.cirrus.com, pmladek@suse.com
Subject: Re: [PATCH v3 1/2] lib/kstrtox.c: Add "false"/"true" support to kstrtobool()
Date: Wed, 27 Apr 2022 15:51:49 +0530 [thread overview]
Message-ID: <YmkZPYqIpIOfu8Ce@li-6e1fa1cc-351b-11b2-a85c-b897023bb5f3.ibm.com> (raw)
In-Reply-To: <YmhEqCCfUvYYPmci@casper.infradead.org>
On Tue, Apr 26, 2022 at 08:14:48PM +0100, Matthew Wilcox wrote:
> On Tue, Apr 26, 2022 at 11:32:02PM +0530, Jagdish Gediya wrote:
> > Signed-off-by: Jagdish Gediya <jvgediya@linux.ibm.com>
> > Reviewed-by: Matthew Wilcox (Oracle) <willy@infradead.org>
>
> HEY! You still have the buggy IFF -> IF change. FIX IT.
> My R-b was very clearly conditional on you fixing it.
My bad, I forgot to correct it. Andrew has corrected it.
> > - * This routine returns 0 iff the first character is one of 'Yy1Nn0', or
> > + * This routine returns 0 if the first character is one of 'YyTt1NnFf0', or
next prev parent reply other threads:[~2022-04-27 10:22 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-26 18:02 [PATCH v3 1/2] lib/kstrtox.c: Add "false"/"true" support to kstrtobool() Jagdish Gediya
2022-04-26 18:02 ` [PATCH v3 2/2] mm: Convert sysfs input to bool using kstrtobool() Jagdish Gediya
2022-04-26 19:14 ` [PATCH v3 1/2] lib/kstrtox.c: Add "false"/"true" support to kstrtobool() Matthew Wilcox
2022-04-26 20:40 ` David Laight
2022-04-27 10:21 ` Jagdish Gediya [this message]
2022-04-27 15:13 ` Andy Shevchenko
2022-04-27 17:39 ` Andrew Morton
2022-04-27 18:17 ` Andy Shevchenko
2022-04-27 18:19 ` Andy Shevchenko
2022-07-25 14:55 ` Mark Rutland
2022-07-25 15:21 ` Matthew Wilcox
2022-07-25 15:36 ` Mark Rutland
2022-07-29 14:35 ` Andy Shevchenko
2022-07-29 14:36 ` Andy Shevchenko
2022-08-25 13:39 ` Petr Mladek
2022-08-26 10:35 ` Will Deacon
2022-07-29 15:17 ` Alexey Dobriyan
2022-07-29 15:32 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YmkZPYqIpIOfu8Ce@li-6e1fa1cc-351b-11b2-a85c-b897023bb5f3.ibm.com \
--to=jvgediya@linux.ibm.com \
--cc=Jonathan.Cameron@huawei.com \
--cc=adobriyan@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=andriy.shevchenko@linux.intel.com \
--cc=dave.hansen@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=pmladek@suse.com \
--cc=rf@opensource.cirrus.com \
--cc=willy@infradead.org \
--cc=ying.huang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).