From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 500F5C433F5 for ; Wed, 27 Apr 2022 18:53:47 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 77C6C6B0074; Wed, 27 Apr 2022 14:53:46 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 72AC86B0075; Wed, 27 Apr 2022 14:53:46 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 5CB126B0078; Wed, 27 Apr 2022 14:53:46 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (relay.hostedemail.com [64.99.140.27]) by kanga.kvack.org (Postfix) with ESMTP id 4B66F6B0074 for ; Wed, 27 Apr 2022 14:53:46 -0400 (EDT) Received: from smtpin14.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay13.hostedemail.com (Postfix) with ESMTP id 03BAF61526 for ; Wed, 27 Apr 2022 18:53:45 +0000 (UTC) X-FDA: 79403558052.14.AC9F200 Received: from mail-qv1-f51.google.com (mail-qv1-f51.google.com [209.85.219.51]) by imf16.hostedemail.com (Postfix) with ESMTP id 8819018006D for ; Wed, 27 Apr 2022 18:53:41 +0000 (UTC) Received: by mail-qv1-f51.google.com with SMTP id jt15so1681402qvb.13 for ; Wed, 27 Apr 2022 11:53:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cmpxchg-org.20210112.gappssmtp.com; s=20210112; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=5Bxi6KofN0Ih5O2P5EXy7XNcKRJLdVQH6xt19JcR/Cc=; b=65NapwWd4Bu52BgiMzSrFcem1E52ZJnpS0GWN6sZuF8lZ5D+NZ9Ww0Anh9KupdJguI UzAS0QkUzTyoa4mXefmL3ncFHMeJEYGiv8Y4ZWUY5GqWqlu6l8H3TeskMI6hQscaCpfY xFTNfO8WOciEzvX0JjGttg51D/9bWg1IxH7Q9heQTyN0Ax1r1H6fpSgxb1qUOYSOt4/b VLQI177Dk/OGl9IygOnXPdYVJLVXXFN59R2Qt3TQ2OMHxqMptwsfkrNXKPx5A6KaTz0c ZfjzEibO+5o5S6D/+WwZ8cM2fs2lXZy9mXt7BWxQ6A3lY0GIvJq4h5tUVYWmcEZW3FdV 8Jzw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=5Bxi6KofN0Ih5O2P5EXy7XNcKRJLdVQH6xt19JcR/Cc=; b=DMXS1JuUPJpu5FqnumIMsMriWfSHnB5e2a9fPIjaPxqa72zKtdYTcKEeHVJNFJw9fM HpJVkXAgXXLYzogqPvcI/rGSntR9mgsHxtPHq/k0pQpspxa2yx8PXFFL0wOU11Ikjx20 NJSUzvKR+oPO6CQj/e9H/11fR0Jmf7QtwBZ38UWKhY8kQdROPBMOmAMVP8ADnYMslciL Jt9c3a+iyR0c5VQ+A0B7GFZs9z9rwVwA6vsWm5lN1spjSevsNl8a5kSOJdy6VdBMD/Bj Cshnq5DmcTMgYpv/D1ifzjy2Jl+LTTFh4cfHyX3p47YRMcHYsSyUjLb8NviXMqztO85V I51w== X-Gm-Message-State: AOAM532WWpZL6wwLFYwHAYfAgQ2ywtVBNxjPN42X+J88/QAUVf+UwgHe gzOd/LAaLXWCGuADBM1mLcNMRw== X-Google-Smtp-Source: ABdhPJy8dRFnCXB+gsjhhIqlkGq+xCQRJDXI9iajkuXVfgL7CeLRLL3u3OvlYSHjyEszbXwsVMwtjg== X-Received: by 2002:a0c:c3c6:0:b0:42c:17e4:9a75 with SMTP id p6-20020a0cc3c6000000b0042c17e49a75mr21460568qvi.124.1651085624374; Wed, 27 Apr 2022 11:53:44 -0700 (PDT) Received: from localhost ([2620:10d:c091:480::1:f617]) by smtp.gmail.com with ESMTPSA id r9-20020ac85c89000000b002f378738ed4sm3690092qta.7.2022.04.27.11.53.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 27 Apr 2022 11:53:44 -0700 (PDT) Date: Wed, 27 Apr 2022 14:53:08 -0400 From: Johannes Weiner To: Andrew Morton Cc: Michal Hocko , Roman Gushchin , Shakeel Butt , Seth Jennings , Dan Streetman , linux-mm@kvack.org, cgroups@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-team@fb.com Subject: Re: [PATCH 4/5] mm: zswap: add basic meminfo and vmstat coverage Message-ID: References: <20220427160016.144237-1-hannes@cmpxchg.org> <20220427160016.144237-5-hannes@cmpxchg.org> <20220427113654.ef8f543d7ba279952deff6f7@linux-foundation.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220427113654.ef8f543d7ba279952deff6f7@linux-foundation.org> X-Stat-Signature: ooui5hg8nhjyyads7xbe6a7uzy37p9w1 X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: 8819018006D X-Rspam-User: Authentication-Results: imf16.hostedemail.com; dkim=pass header.d=cmpxchg-org.20210112.gappssmtp.com header.s=20210112 header.b=65NapwWd; dmarc=pass (policy=none) header.from=cmpxchg.org; spf=pass (imf16.hostedemail.com: domain of hannes@cmpxchg.org designates 209.85.219.51 as permitted sender) smtp.mailfrom=hannes@cmpxchg.org X-HE-Tag: 1651085621-16931 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Apr 27, 2022 at 11:36:54AM -0700, Andrew Morton wrote: > On Wed, 27 Apr 2022 12:00:15 -0400 Johannes Weiner wrote: > > > Currently it requires poking at debugfs to figure out the size and > > population of the zswap cache on a host. There are no counters for > > reads and writes against the cache. As a result, it's difficult to > > understand zswap behavior on production systems. > > > > Print zswap memory consumption and how many pages are zswapped out in > > /proc/meminfo. Count zswapouts and zswapins in /proc/vmstat. > > /proc/meminfo is rather prime real estate. Is this important enough to > be placed in there, or should it instead be in the more lowly > /proc/vmstat? The zswap pool size is capped to 20% of available RAM, and we usually have a utilization of tens of gigabytes. I think it's fair to say it's a first class memory consumer when enabled, and actually a huge hole in /proc/meminfo coverage right now. > /proc/meminfo is documented in Documentation/filesystems/proc.rst ;) > > That file appears to need a bit of updating for other things. "The following is from a 16GB PIII, which has highmem enabled." lmao. I'll send a general update for that, and a delta fixlet for 4/5. Thanks!