From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4F2E5C4332F for ; Thu, 28 Apr 2022 17:28:25 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id A3B126B00C0; Thu, 28 Apr 2022 13:28:24 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 9EB4A8D0015; Thu, 28 Apr 2022 13:28:24 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 88B1C6B00C4; Thu, 28 Apr 2022 13:28:24 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (relay.hostedemail.com [64.99.140.25]) by kanga.kvack.org (Postfix) with ESMTP id 79B116B00C0 for ; Thu, 28 Apr 2022 13:28:24 -0400 (EDT) Received: from smtpin10.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay12.hostedemail.com (Postfix) with ESMTP id 511FE1217B5 for ; Thu, 28 Apr 2022 17:28:24 +0000 (UTC) X-FDA: 79406971728.10.61F6398 Received: from mail-qv1-f51.google.com (mail-qv1-f51.google.com [209.85.219.51]) by imf25.hostedemail.com (Postfix) with ESMTP id D0693A006D for ; Thu, 28 Apr 2022 17:28:14 +0000 (UTC) Received: by mail-qv1-f51.google.com with SMTP id 1so3698326qvs.8 for ; Thu, 28 Apr 2022 10:28:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cmpxchg-org.20210112.gappssmtp.com; s=20210112; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=ywIQvVwgag1com6bDxPqmKMeB7A08MtYuevMsyOSOPQ=; b=8QDJnLhAmNHGsLaBQmDqBrcILYyDP9jv4WD9nDDyluZQ3AyEx3MdCGQSDqxW70SGO6 dHjEacPn670Cttc+vma5fsmybXQrEWDwOSriDm4M1zh/p8R0cfGR+P2UeAOOswBdPoPN UymIxmq005YN0pWaKnhy3Qt5T8fMP40inSpO/g4yKZyoeuGW2l3pub90YoPGUGQkiuLX cmUr1lNoAFW3vWIR6Ju6NmnMFVQlilVHADUJd9/Hwy6MK77xIUrA6Iyos41ScIK3y026 cbYAaiaMgarYe1E4TgstRbzWse+RFycZstcjBiJwinrr2bYwiHSWcfz1tz0VoDWKMy1B frzg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=ywIQvVwgag1com6bDxPqmKMeB7A08MtYuevMsyOSOPQ=; b=qYUC/d3/MfFeo83ghGFiHIVBCwTvRrIC7JIXkYbJU+c/w4HzMTi+2G15WfYesqAabS gViAI5thz1lBXqJ8Zr0fnXbtmTfrz+gcV3/EJYsgteUDPaqEsLPScksvHNtzA0HPmrDx FIWd76shIvV3+Uk5kMPQkeN323Mm5II0UQD74ELTJ1vAt4moH6ONYOJxOjzz8V8KI9yz /nfXQWlnPRIsc4fXr+IopF/BIY0HwJHHZdf+CHgKXsrDgel10ioqDR1tp/tJ7W9p7gGx 1uisp6t9brJFadIufD+/yeD3Ikam/wI9zB5c3t/iSxv5f+ZEGClKFCp6Y6oDDy4/ybmd 7jhg== X-Gm-Message-State: AOAM532sovmPT/STbarEfUwecggx/PWoqRP5QL/4fKiAjaJ/inhfOICM rHtgqyMWmfJQG0awr3yR4ZU6gA== X-Google-Smtp-Source: ABdhPJxRLZPBYQ+Renj2m3NAsWJcy1DxTlhIKkjU4+EhSPE4VL4dcK8UCxfEtZem5IKqTdfDjqjM5A== X-Received: by 2002:ad4:5f05:0:b0:456:306d:333d with SMTP id fo5-20020ad45f05000000b00456306d333dmr18665310qvb.16.1651166902753; Thu, 28 Apr 2022 10:28:22 -0700 (PDT) Received: from localhost ([2620:10d:c091:480::1:d588]) by smtp.gmail.com with ESMTPSA id 15-20020ac8594f000000b002f200ea2518sm327527qtz.59.2022.04.28.10.28.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 28 Apr 2022 10:28:22 -0700 (PDT) Date: Thu, 28 Apr 2022 13:27:46 -0400 From: Johannes Weiner To: Minchan Kim Cc: Andrew Morton , Michal Hocko , Roman Gushchin , Shakeel Butt , Seth Jennings , Dan Streetman , linux-mm@kvack.org, cgroups@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-team@fb.com Subject: Re: [PATCH 4/5] mm: zswap: add basic meminfo and vmstat coverage Message-ID: References: <20220427160016.144237-1-hannes@cmpxchg.org> <20220427160016.144237-5-hannes@cmpxchg.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspamd-Queue-Id: D0693A006D X-Stat-Signature: 3szo79nk3tjgm1swqyo3p971nmz7u1hn X-Rspam-User: Authentication-Results: imf25.hostedemail.com; dkim=pass header.d=cmpxchg-org.20210112.gappssmtp.com header.s=20210112 header.b=8QDJnLhA; spf=pass (imf25.hostedemail.com: domain of hannes@cmpxchg.org designates 209.85.219.51 as permitted sender) smtp.mailfrom=hannes@cmpxchg.org; dmarc=pass (policy=none) header.from=cmpxchg.org X-Rspamd-Server: rspam09 X-HE-Tag: 1651166894-522426 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Apr 28, 2022 at 10:02:46AM -0700, Minchan Kim wrote: > On Thu, Apr 28, 2022 at 10:05:13AM -0400, Johannes Weiner wrote: > > But I'd ack a patch that adds a combined "Compressed" counter for zram > > + zswap if you send it, Minchan. > > If we really want to go separate stat for zswap and zram, it would > be better to use direct name "Zram: " instead of comrpessed. That works for me as well.