From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 41C7FCCA473 for ; Thu, 9 Jun 2022 03:55:12 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id AB1506B0073; Wed, 8 Jun 2022 23:55:11 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id A60BF6B0074; Wed, 8 Jun 2022 23:55:11 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 929406B0075; Wed, 8 Jun 2022 23:55:11 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 810E86B0073 for ; Wed, 8 Jun 2022 23:55:11 -0400 (EDT) Received: from smtpin31.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay11.hostedemail.com (Postfix) with ESMTP id 57CAE803B6 for ; Thu, 9 Jun 2022 03:55:11 +0000 (UTC) X-FDA: 79557332022.31.819A435 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) by imf14.hostedemail.com (Postfix) with ESMTP id 6621F100056 for ; Thu, 9 Jun 2022 03:55:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=0YPt1S1jhSTaWf/8ZoCL0bFChcDXSklVsTmgZM2rLiI=; b=Dl8JGvKpB6vphg8GJGusCTANit 1GxyGnn679NvRWS0MV6dl/ia8FXbFkazmnr+IDjn5zzr3og7XZfjMLZjWL06OF3evRoMrBFjxFrsx Htg+vfwV+x7T9mmYPRX8P6cJKrK8y0bBndusBU0lXk/KdOK8xByq3REx/zxGsoZUuF/x5DHkNPje8 NDEHhrWuv4dfciQdbKDCDBmbUI7HxHBS2K/veQeFd3r7wooBpR0eTx87J+TG8yrH1ANVnPBJkU+b9 h1sAP8J3H9vbFRWHN3eOBnx3OSPTyjl+SZp0lSY+nu4GUzBF+V4Qw/fg17+wG32FZfTnYTo9p6g96 gaHUWy6g==; Received: from hch by bombadil.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1nz9GE-00G0Iz-DU; Thu, 09 Jun 2022 03:55:06 +0000 Date: Wed, 8 Jun 2022 20:55:06 -0700 From: Christoph Hellwig To: Matthew Wilcox Cc: Christoph Hellwig , linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, linux-ext4@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net, linux-mm@kvack.org, linux-nilfs@vger.kernel.org Subject: Re: [PATCH 03/10] ext4: Convert mpage_release_unused_pages() to use filemap_get_folios() Message-ID: References: <20220605193854.2371230-1-willy@infradead.org> <20220605193854.2371230-4-willy@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1654746910; a=rsa-sha256; cv=none; b=M9QFm1T0G0IpctF1cNikpeYY3O5ZP/4AMEwmJNyNuu7rsVCZuqLDetnt//wVZ2Q2Ae5Tuq ikvf92vEp+VqwhVjkQoobYPp6u3QvBcR8zrsKfshonaE+nd9JoBn9CgsE0BTWp/YjhfBkZ I0ifPwrryQ6PQu5SqdSqpxZ+NlADNUI= ARC-Authentication-Results: i=1; imf14.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=Dl8JGvKp; spf=none (imf14.hostedemail.com: domain of BATV+a39afe573ddbd6ff3389+6864+infradead.org+hch@bombadil.srs.infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=BATV+a39afe573ddbd6ff3389+6864+infradead.org+hch@bombadil.srs.infradead.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1654746910; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=0YPt1S1jhSTaWf/8ZoCL0bFChcDXSklVsTmgZM2rLiI=; b=y/kKuL6GOG2vv2aunjpGSLLXcE4P3iFf+nF1HC8NUcWFggTWs5w45GN9jT2wyaxhtFUZg0 BF80nn5hjnSyowMRvYC5cZF2vJLEuV5YDWneL3FrajS980pX3XR+KwnOJFHA1hMLxFoN7S JFfgf31vhn6srlP0DVuUCCd2drY3o6o= X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: 6621F100056 X-Stat-Signature: hscu7ra3ed7ga1aautb6zmymz1m9pubp X-Rspam-User: Authentication-Results: imf14.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=Dl8JGvKp; spf=none (imf14.hostedemail.com: domain of BATV+a39afe573ddbd6ff3389+6864+infradead.org+hch@bombadil.srs.infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=BATV+a39afe573ddbd6ff3389+6864+infradead.org+hch@bombadil.srs.infradead.org; dmarc=none X-HE-Tag: 1654746910-77094 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Jun 08, 2022 at 05:02:40PM +0100, Matthew Wilcox wrote: > On Wed, Jun 08, 2022 at 01:02:22AM -0700, Christoph Hellwig wrote: > > On Sun, Jun 05, 2022 at 08:38:47PM +0100, Matthew Wilcox (Oracle) wrote: > > > If the folio is large, it may overlap the beginning or end of the > > > unused range. If it does, we need to avoid invalidating it. > > > > It's never going to be larger for ext4, is it? But either way, > > those precautions looks fine. > > I don't want to say "never". Today, it's not, but if ext4 ever does > gain support for large folios, then this is a precaution it will need > to take. I'm trying not to leave traps when I do conversions. FYI, this wasn't an objection to the patch, just a hint that the commit log could spell this out a bit better.