From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5AC8AC43334 for ; Mon, 27 Jun 2022 07:57:32 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id DED696B0071; Mon, 27 Jun 2022 03:57:31 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id D74C06B0072; Mon, 27 Jun 2022 03:57:31 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id BF06F8E0001; Mon, 27 Jun 2022 03:57:31 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id AAFAF6B0071 for ; Mon, 27 Jun 2022 03:57:31 -0400 (EDT) Received: from smtpin28.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay13.hostedemail.com (Postfix) with ESMTP id 8322B60E2D for ; Mon, 27 Jun 2022 07:57:31 +0000 (UTC) X-FDA: 79623261102.28.4F16AB7 Received: from mail-pg1-f173.google.com (mail-pg1-f173.google.com [209.85.215.173]) by imf16.hostedemail.com (Postfix) with ESMTP id 7803818002F for ; Mon, 27 Jun 2022 07:57:29 +0000 (UTC) Received: by mail-pg1-f173.google.com with SMTP id q140so8376636pgq.6 for ; Mon, 27 Jun 2022 00:57:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bytedance-com.20210112.gappssmtp.com; s=20210112; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=jyqDF5Hpn2EUBCZeMxGZtJnLwcRJ4sS1ucd+2BRdDk4=; b=qzPhTTdiRDFzMFpwSdyKg8WpEavFtchGHpONzR7KAUt3FNXZ5+gup4HUqmgGm1ShjR cVmoJXM4C2NMJPbwsZxSQzBcyxRtIySH2B2CpFoa7uRPwEpPZ9UPPBOiPL0d9tccG6an 2KB8Yw46giMPSF6DpW7z7dkklmbQMOqQQylX+YZ7+yBwTP0rWPMlygxf6tm4l2R9Ior5 9LaJdfmQpr/67qZpPCmS3okU49W3CRUPsD0elkSwsH+m3Ke5+C01OnJ480UCXsUa9GMi BZm3j9qs2UeLTBZBAHXfAyFK5C3hEt4/sgzOb8d9ID0/tetPn6iUPrhRhEj1WM0k4TU1 XSaw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=jyqDF5Hpn2EUBCZeMxGZtJnLwcRJ4sS1ucd+2BRdDk4=; b=JP39FHWuiGZBOTzYRFLS0cQ10ay9HzGavGEKsIQER09QjE2aRA5y62DfkCM8W+oo9f kzF5Cbh03elNQPAvFY1KKlfYB/iRUDdi85s+g9vFHETMq7ktJjnJG99X3SjZ21DXNVgx RiWIjZB8RY1uTVai5n3hpg1NlQhZcOYyjqT9z2xDidtCvumP6r0dfwO4bpmDlJ9UwkJT QVf8H86kT7WyxNTyH31d319lvJIrshrZIzc7erPrMUZ6v7Ep2JUpNcFYWbqTxzdlpRVZ HgU+ZiWdFeYriQScwHnwx7i7CuOiYgpeP1tWKIk8NKJ7oPML4y/TL+JH/k+GKOU3ksgC rHPA== X-Gm-Message-State: AJIora8GtkRFTnazSlHisQq0sHy0okCuw0Cw1AQQBQc+q20Wdth9Im8V +LQnDDCdDgRBnHAO5JnJYhZUEA== X-Google-Smtp-Source: AGRyM1u7yUn3oLBcN0sCyNbL8gMeo0rCW5lez9SUotOMvwnCNp4G/4WfC8fpwA9lomLmUUyyAXH4fQ== X-Received: by 2002:aa7:9f9b:0:b0:525:1e0a:a6b4 with SMTP id z27-20020aa79f9b000000b005251e0aa6b4mr13623307pfr.5.1656316648483; Mon, 27 Jun 2022 00:57:28 -0700 (PDT) Received: from localhost ([139.177.225.245]) by smtp.gmail.com with ESMTPSA id f11-20020a62380b000000b0051829b1595dsm6491342pfa.130.2022.06.27.00.57.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 27 Jun 2022 00:57:28 -0700 (PDT) Date: Mon, 27 Jun 2022 15:57:25 +0800 From: Muchun Song To: Naoya Horiguchi Cc: linux-mm@kvack.org, Andrew Morton , David Hildenbrand , Mike Kravetz , Miaohe Lin , Liu Shixin , Yang Shi , Oscar Salvador , Naoya Horiguchi , linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 2/9] mm/hugetlb: separate path for hwpoison entry in copy_hugetlb_page_range() Message-ID: References: <20220623235153.2623702-1-naoya.horiguchi@linux.dev> <20220623235153.2623702-3-naoya.horiguchi@linux.dev> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220623235153.2623702-3-naoya.horiguchi@linux.dev> ARC-Authentication-Results: i=1; imf16.hostedemail.com; dkim=pass header.d=bytedance-com.20210112.gappssmtp.com header.s=20210112 header.b=qzPhTTdi; dmarc=pass (policy=none) header.from=bytedance.com; spf=pass (imf16.hostedemail.com: domain of songmuchun@bytedance.com designates 209.85.215.173 as permitted sender) smtp.mailfrom=songmuchun@bytedance.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1656316651; a=rsa-sha256; cv=none; b=j5T56iWZDEdVYX3mCz/B+vsX0kP08CVLNrTZ8+jQ7jVdxzCNukMRs+km0i8koOQU9aak4l xtVpZQWM8I6W2Ijxw9mweSklNtAgZAQlhNVGm9900FDct0hDmVHOQN6GTUae1NaAxZzCRI IGHf3uMKgOudrNHrftdIO4ZOsYZHN2w= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1656316651; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=jyqDF5Hpn2EUBCZeMxGZtJnLwcRJ4sS1ucd+2BRdDk4=; b=RoCp2iTDW+98g4dO4IvI7oe3XIKQrxZucPeejmmhhOx8jUibapm8yDH/Pn3/IldbBTLpkU /QBi70YI65RKnzXHd2/qI8TVBQn7LEDs/bW6I+tUNqcQSNpUVkKobZXkwTsOkv8IEEoz/W cvaT8Kchn734H2lVLYRzqFtWUMDTB8E= X-Stat-Signature: ycb86mahnueauksqfbpzi7ff65cjoahx X-Rspamd-Server: rspam08 X-Rspam-User: X-Rspamd-Queue-Id: 7803818002F Authentication-Results: imf16.hostedemail.com; dkim=pass header.d=bytedance-com.20210112.gappssmtp.com header.s=20210112 header.b=qzPhTTdi; dmarc=pass (policy=none) header.from=bytedance.com; spf=pass (imf16.hostedemail.com: domain of songmuchun@bytedance.com designates 209.85.215.173 as permitted sender) smtp.mailfrom=songmuchun@bytedance.com X-HE-Tag: 1656316649-690027 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, Jun 24, 2022 at 08:51:46AM +0900, Naoya Horiguchi wrote: > From: Naoya Horiguchi > > Originally copy_hugetlb_page_range() handles migration entries and hwpoisone > entries in similar manner. But recently the related code path has more code > for migration entries, and when is_writable_migration_entry() was converted > to !is_readable_migration_entry(), hwpoison entries on source processes got > to be unexpectedly updated (which is legitimate for migration entries, but > not for hwpoison entries). This results in unexpected serious issues like > kernel panic when foking processes with hwpoison entries in pmd. > > Separate the if branch into one for hwpoison entries and one for migration > entries. > > Fixes: 6c287605fd56 ("mm: remember exclusively mapped anonymous pages with PG_anon_exclusive") > Signed-off-by: Naoya Horiguchi Thanks for fixing it. Reviewed-by: Muchun Song