From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id B0A15C433EF for ; Wed, 29 Jun 2022 06:18:26 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 221A66B0071; Wed, 29 Jun 2022 02:18:26 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 1D0BF6B0072; Wed, 29 Jun 2022 02:18:26 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 0994B8E0001; Wed, 29 Jun 2022 02:18:26 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id EE72E6B0071 for ; Wed, 29 Jun 2022 02:18:25 -0400 (EDT) Received: from smtpin28.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id BDCC91393 for ; Wed, 29 Jun 2022 06:18:25 +0000 (UTC) X-FDA: 79630268970.28.EAFAC73 Received: from mail-pg1-f171.google.com (mail-pg1-f171.google.com [209.85.215.171]) by imf30.hostedemail.com (Postfix) with ESMTP id 6D12E80031 for ; Wed, 29 Jun 2022 06:18:25 +0000 (UTC) Received: by mail-pg1-f171.google.com with SMTP id 23so14353552pgc.8 for ; Tue, 28 Jun 2022 23:18:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bytedance-com.20210112.gappssmtp.com; s=20210112; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=FurANPoXFgLl4yATK+0eEznj1edHZa5nVDv5uuc4bDo=; b=SgHO+LNGTa1ZjEU1fOMIoa78TDbXDU0lSMDcOCNqg0P90+bK2g9CGB4PHOz1BHZOzU A/KQWOveXJNoOlNAY02aABLZHERdexNI663akY+LgpXN1DUAHH9eCJ+22DdUpvnI/UCu tn97Z8uK2JPGB8CY3Qw9eezEHLDyofmdFw7CNsVtAbKu2DL7KpjlMtk4wLNj6rTiWTS1 diY4j1pPbUfu+IlCcOa6XUSMqAB2FmGHRdf5SV1nzTYI0z3qx9NKXucW3idRY15a/bnv mtUybon/6E1Vyjdpvg63bGY4RbGOwHCIOjJoE7ZKmQv7MjsxaEkAm4wvkz++hcHfmYyC ebzQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=FurANPoXFgLl4yATK+0eEznj1edHZa5nVDv5uuc4bDo=; b=hh/b4gwjLPz1lqztDffoaQ0fbrq4fxpE12TVV/KwY18XpLD5MdMJv06LPhsTfODKfZ KvH3B6aFCfZvrHoYU5DiION8g6RnYl8wm3RKxM20dZsG83NwYA/eokXZYAaFf6lzJDWX 60/75MwDVto9tqJeeeh2Ml4j27dwDKStbFLBoUJIAX0e9be2Lati4jotjeYcM8D3UqPe BtaYUE6uO6xVsu0isihHdaWK3OM3mNz6W2+La9zHphrlXsJ29Nfu+lUu658UWyjo2PKe 0TrX8X3POQ8bjeSBOBMqIFVY0XtlvAnSnsu8qEhgI7aUMEhuoip9gifXkfqu/iSZSOnp 0Phw== X-Gm-Message-State: AJIora9zZJGR9/ShRHhtxtpNrGCETQ0lUDw/Vqv6RtOK02NzDLo5bIxj eN9PAdP8mNCnZJYZx3QRItM6CA== X-Google-Smtp-Source: AGRyM1vANek9OiayC/2ujEUHE3FEBKVKdj5W/Tw2CSX8G/sEnkwcrLJnI9wP1/KcysSgjag/O9gCqQ== X-Received: by 2002:a63:ee54:0:b0:3fe:30cc:899f with SMTP id n20-20020a63ee54000000b003fe30cc899fmr1703757pgk.234.1656483504443; Tue, 28 Jun 2022 23:18:24 -0700 (PDT) Received: from localhost ([139.177.225.245]) by smtp.gmail.com with ESMTPSA id q13-20020a170902a3cd00b0016403cae7desm10453132plb.276.2022.06.28.23.18.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 28 Jun 2022 23:18:24 -0700 (PDT) Date: Wed, 29 Jun 2022 14:18:20 +0800 From: Muchun Song To: James Houghton Cc: Mike Kravetz , Peter Xu , David Hildenbrand , David Rientjes , Axel Rasmussen , Mina Almasry , Jue Wang , Manish Mishra , "Dr . David Alan Gilbert" , linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [RFC PATCH 01/26] hugetlb: make hstate accessor functions const Message-ID: References: <20220624173656.2033256-1-jthoughton@google.com> <20220624173656.2033256-2-jthoughton@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220624173656.2033256-2-jthoughton@google.com> ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1656483505; a=rsa-sha256; cv=none; b=yEbUDzvbGeWX69l41dK13nCBlrKTB+CcYMiWLVQ7j5xmp6Lm8DzhzuwMJBDsgJ/axSnYEY NXS0WV7hNoXykrpgl8su/QsRlzrM1I72YA+U52XkIoxGuxtLNMD+tC/oYtvfsTjgXnrG2i gzVP4+LqmcUupjDXQHmUhU0bQh0hsQM= ARC-Authentication-Results: i=1; imf30.hostedemail.com; dkim=pass header.d=bytedance-com.20210112.gappssmtp.com header.s=20210112 header.b=SgHO+LNG; spf=pass (imf30.hostedemail.com: domain of songmuchun@bytedance.com designates 209.85.215.171 as permitted sender) smtp.mailfrom=songmuchun@bytedance.com; dmarc=pass (policy=none) header.from=bytedance.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1656483505; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=FurANPoXFgLl4yATK+0eEznj1edHZa5nVDv5uuc4bDo=; b=nhNO0U+9rNMGk5bPtaSgMdenSkhmisjZfJHO+roXbVe6PJJINuidKW2Dkc3ba0bbd1gFks Ccx8S7gdZWI7RNWwXvXYoO3K/9ag8RwEcHHET9b8BZDyA7vatbiBR9wMYaxhdgaB5Rixfv h3Swp1QtBbxRloYdKED+SlTIBj1fokc= X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: 6D12E80031 Authentication-Results: imf30.hostedemail.com; dkim=pass header.d=bytedance-com.20210112.gappssmtp.com header.s=20210112 header.b=SgHO+LNG; spf=pass (imf30.hostedemail.com: domain of songmuchun@bytedance.com designates 209.85.215.171 as permitted sender) smtp.mailfrom=songmuchun@bytedance.com; dmarc=pass (policy=none) header.from=bytedance.com X-Rspam-User: X-Stat-Signature: onz5qbu5sd9cxtftmb5obqdgqw5h5bfk X-HE-Tag: 1656483505-176351 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, Jun 24, 2022 at 05:36:31PM +0000, James Houghton wrote: > This is just a const-correctness change so that the new hugetlb_pte > changes can be const-correct too. > > Acked-by: David Rientjes > > Signed-off-by: James Houghton This is a good start. I also want to make those helpers take const type parameter. Seems you have forgotten to update them when !CONFIG_HUGETLB_PAGE. Thanks. > --- > include/linux/hugetlb.h | 12 ++++++------ > 1 file changed, 6 insertions(+), 6 deletions(-) > > diff --git a/include/linux/hugetlb.h b/include/linux/hugetlb.h > index e4cff27d1198..498a4ae3d462 100644 > --- a/include/linux/hugetlb.h > +++ b/include/linux/hugetlb.h > @@ -715,7 +715,7 @@ static inline struct hstate *hstate_vma(struct vm_area_struct *vma) > return hstate_file(vma->vm_file); > } > > -static inline unsigned long huge_page_size(struct hstate *h) > +static inline unsigned long huge_page_size(const struct hstate *h) > { > return (unsigned long)PAGE_SIZE << h->order; > } > @@ -729,27 +729,27 @@ static inline unsigned long huge_page_mask(struct hstate *h) > return h->mask; > } > > -static inline unsigned int huge_page_order(struct hstate *h) > +static inline unsigned int huge_page_order(const struct hstate *h) > { > return h->order; > } > > -static inline unsigned huge_page_shift(struct hstate *h) > +static inline unsigned huge_page_shift(const struct hstate *h) > { > return h->order + PAGE_SHIFT; > } > > -static inline bool hstate_is_gigantic(struct hstate *h) > +static inline bool hstate_is_gigantic(const struct hstate *h) > { > return huge_page_order(h) >= MAX_ORDER; > } > > -static inline unsigned int pages_per_huge_page(struct hstate *h) > +static inline unsigned int pages_per_huge_page(const struct hstate *h) > { > return 1 << h->order; > } > > -static inline unsigned int blocks_per_huge_page(struct hstate *h) > +static inline unsigned int blocks_per_huge_page(const struct hstate *h) > { > return huge_page_size(h) / 512; > } > -- > 2.37.0.rc0.161.g10f37bed90-goog > >