From: Matthew Wilcox <willy@infradead.org>
To: Johannes Weiner <hannes@cmpxchg.org>
Cc: Christoph Hellwig <hch@lst.de>, Mel Gorman <mgorman@suse.de>,
Jan Kara <jack@suse.cz>, Bob Peterson <rpeterso@redhat.com>,
Andreas Gruenbacher <agruenba@redhat.com>,
"Darrick J. Wong" <djwong@kernel.org>,
Damien Le Moal <damien.lemoal@opensource.wdc.com>,
Naohiro Aota <naohiro.aota@wdc.com>,
Vlastimil Babka <vbabka@suse.cz>,
Johannes Thumshirn <jth@kernel.org>,
cluster-devel@redhat.com, linux-xfs@vger.kernel.org,
linux-fsdevel@vger.kernel.org, linux-mm@kvack.org
Subject: Re: remove iomap_writepage v2
Date: Wed, 10 Aug 2022 21:43:58 +0100 [thread overview]
Message-ID: <YvQYjpDHH5KckCrw@casper.infradead.org> (raw)
In-Reply-To: <Yufx5jpyJ+zcSJ4e@cmpxchg.org>
On Mon, Aug 01, 2022 at 11:31:50AM -0400, Johannes Weiner wrote:
> XFS hasn't had a ->writepage call for a while. After LSF I internally
> tested dropping btrfs' callback, and the results looked good: no OOM
> kills with dirty/writeback pages remaining, performance parity. Then I
> went on vacation and Christoph beat me to the patch :)
To avoid duplicating work with you or Christoph ... it seems like the
plan is to kill ->writepage entirely soon, so there's no point in me
doing a sweep of all the filesystems to convert ->writepage to
->write_folio, correct?
I assume the plan for filesystems which have a writepage but don't have
a ->writepages (9p, adfs, affs, bfs, ecryptfs, gfs2, hostfs, jfs, minix,
nilfs2, ntfs, ocfs2, reiserfs, sysv, ubifs, udf, ufs, vboxsf) is to give
them a writepages, modelled on iomap_writepages(). Seems that adding
a block_writepages() might be a useful thing for me to do?
next prev parent reply other threads:[~2022-08-10 20:44 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20220719041311.709250-1-hch@lst.de>
2022-07-28 11:10 ` remove iomap_writepage v2 Jan Kara
2022-07-28 14:18 ` Matthew Wilcox
2022-07-28 22:48 ` Dave Chinner
2022-07-28 23:26 ` Yang Shi
2022-07-29 9:22 ` Mel Gorman
2022-07-29 14:11 ` Christoph Hellwig
2022-08-01 15:31 ` Johannes Weiner
2022-08-10 20:43 ` Matthew Wilcox [this message]
2022-08-10 21:32 ` Andreas Grünbacher
2022-08-10 23:17 ` Matthew Wilcox
2022-08-11 5:58 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YvQYjpDHH5KckCrw@casper.infradead.org \
--to=willy@infradead.org \
--cc=agruenba@redhat.com \
--cc=cluster-devel@redhat.com \
--cc=damien.lemoal@opensource.wdc.com \
--cc=djwong@kernel.org \
--cc=hannes@cmpxchg.org \
--cc=hch@lst.de \
--cc=jack@suse.cz \
--cc=jth@kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-xfs@vger.kernel.org \
--cc=mgorman@suse.de \
--cc=naohiro.aota@wdc.com \
--cc=rpeterso@redhat.com \
--cc=vbabka@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).