From: Ingo Molnar <mingo@kernel.org>
To: Mel Gorman <mgorman@suse.de>
Cc: Linus Torvalds <torvalds@linux-foundation.org>,
David Hildenbrand <david@redhat.com>,
linux-kernel@vger.kernel.org, linux-mm@kvack.org,
stable@vger.kernel.org, Andrew Morton <akpm@linux-foundation.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Axel Rasmussen <axelrasmussen@google.com>,
Peter Xu <peterx@redhat.com>, Hugh Dickins <hughd@google.com>,
Andrea Arcangeli <aarcange@redhat.com>,
Matthew Wilcox <willy@infradead.org>,
Vlastimil Babka <vbabka@suse.cz>,
John Hubbard <jhubbard@nvidia.com>,
Jason Gunthorpe <jgg@nvidia.com>,
Peter Zijlstra <peterz@infradead.org>,
Juri Lelli <juri.lelli@redhat.com>,
Vincent Guittot <vincent.guittot@linaro.org>,
Dietmar Eggemann <dietmar.eggemann@arm.com>,
Steven Rostedt <rostedt@goodmis.org>
Subject: Re: [PATCH v2] sched/all: Change all BUG_ON() instances in the scheduler to WARN_ON_ONCE()
Date: Sun, 21 Aug 2022 13:28:58 +0200 [thread overview]
Message-ID: <YwIW+mVeZoTOxn/4@gmail.com> (raw)
In-Reply-To: <20220815144143.zjsiamw5y22bvgki@suse.de>
* Mel Gorman <mgorman@suse.de> wrote:
> For the rest, I didn't see obvious recovery paths that would allow the
> system to run predictably. Any of them firing will have unpredictable
> consequences (e.g. move_queued_task firing would be fun if it was a
> per-cpu kthread). Depending on which warning triggers, the remaining life
> of the system may be very short but maybe long enough to be logged even
> if system locks up shortly afterwards.
Correct. I'd prefer to keep all these warnings 'simple' - i.e. no attempted
recovery & control flow, unless we ever expect these to trigger.
I.e. instead of adding a 'goto' I'd prefer if we removed most of the ones
you highlighted. But wanted to keep this first patch simple.
Thanks,
Ingo
next prev parent reply other threads:[~2022-08-21 11:29 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-08 7:32 [PATCH v1] mm/gup: fix FOLL_FORCE COW security issue and remove FOLL_COW David Hildenbrand
2022-08-08 16:02 ` David Hildenbrand
2022-08-09 18:27 ` Linus Torvalds
2022-08-09 18:45 ` David Hildenbrand
2022-08-09 18:59 ` Linus Torvalds
2022-08-09 19:07 ` Jason Gunthorpe
2022-08-09 19:21 ` Linus Torvalds
2022-08-09 21:16 ` David Laight
2022-08-11 7:13 ` [PATCH] sched/all: Change BUG_ON() instances to WARN_ON() Ingo Molnar
2022-08-11 20:43 ` Linus Torvalds
2022-08-11 21:28 ` Matthew Wilcox
2022-08-11 23:22 ` Jason Gunthorpe
2022-08-14 1:10 ` John Hubbard
2022-08-12 9:29 ` [PATCH v2] sched/all: Change all BUG_ON() instances in the scheduler to WARN_ON_ONCE() Ingo Molnar
[not found] ` <20220815144143.zjsiamw5y22bvgki@suse.de>
2022-08-15 22:12 ` John Hubbard
2022-08-21 11:28 ` Ingo Molnar [this message]
2022-08-09 18:40 ` [PATCH v1] mm/gup: fix FOLL_FORCE COW security issue and remove FOLL_COW Linus Torvalds
2022-08-09 18:48 ` Jason Gunthorpe
2022-08-09 18:53 ` David Hildenbrand
2022-08-09 19:07 ` Linus Torvalds
2022-08-09 19:20 ` David Hildenbrand
2022-08-09 18:48 ` Linus Torvalds
2022-08-09 19:09 ` David Hildenbrand
2022-08-09 20:00 ` Linus Torvalds
2022-08-09 20:06 ` David Hildenbrand
2022-08-09 20:07 ` David Hildenbrand
2022-08-09 20:14 ` Linus Torvalds
2022-08-09 20:20 ` David Hildenbrand
2022-08-09 20:30 ` Linus Torvalds
2022-08-09 20:38 ` Linus Torvalds
2022-08-09 20:42 ` David Hildenbrand
2022-08-09 20:20 ` Linus Torvalds
2022-08-09 20:23 ` David Hildenbrand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YwIW+mVeZoTOxn/4@gmail.com \
--to=mingo@kernel.org \
--cc=aarcange@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=axelrasmussen@google.com \
--cc=david@redhat.com \
--cc=dietmar.eggemann@arm.com \
--cc=gregkh@linuxfoundation.org \
--cc=hughd@google.com \
--cc=jgg@nvidia.com \
--cc=jhubbard@nvidia.com \
--cc=juri.lelli@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mgorman@suse.de \
--cc=peterx@redhat.com \
--cc=peterz@infradead.org \
--cc=rostedt@goodmis.org \
--cc=stable@vger.kernel.org \
--cc=torvalds@linux-foundation.org \
--cc=vbabka@suse.cz \
--cc=vincent.guittot@linaro.org \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).