From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id D55FAC04AA5 for ; Thu, 25 Aug 2022 00:34:41 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 6333D6B0074; Wed, 24 Aug 2022 20:34:41 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 5E280940008; Wed, 24 Aug 2022 20:34:41 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 48457940007; Wed, 24 Aug 2022 20:34:41 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 38DF16B0074 for ; Wed, 24 Aug 2022 20:34:41 -0400 (EDT) Received: from smtpin02.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 124011203DF for ; Thu, 25 Aug 2022 00:34:41 +0000 (UTC) X-FDA: 79836244362.02.893F4AC Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by imf10.hostedemail.com (Postfix) with ESMTP id B00A3C0036 for ; Thu, 25 Aug 2022 00:34:40 +0000 (UTC) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 1659AB826C6; Thu, 25 Aug 2022 00:34:39 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id DE545C433C1; Thu, 25 Aug 2022 00:34:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1661387677; bh=6rO/XxD//LiN2RORNhJRyZlrqCjCiNFU5ZqLFHkHtNw=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=B3p67HJkV0EKVu9Ql4aU6rN4FWSudcUq8hTiKSO6udZF3bH7AGH1nWFY1y5lHwjj3 EstmZVfWlFeJzSmjMnbbfRCB84S1fglxGWbzlS4gwUTGwjHM0LFuZ+Z5ai2T7N4Wrg KTC+WzypNZQc4+CLSsjGf9qJRoEV4R9sUaoodN8sRM4Z2wbesK6dIYkOVTKnxwrSRO a91HqRTnBUa9Ov9lf2TDzKl/RPBCbztStS2gbhBAzLUYYXlwG9Yt9vh11j2qoMFMsS R5PCjMjwRy7qtEbL9ErJIgzvwxYUVKfu5s/S8vVRR9j2PQDTJotJs03StTU0SXMKUh ckM2AOQ1j2ZaQ== Date: Thu, 25 Aug 2022 01:34:32 +0100 From: Mark Brown To: Liam Howlett , Catalin Marinas , Will Deacon Cc: "maple-tree@lists.infradead.org" , "linux-mm@kvack.org" , "linux-kernel@vger.kernel.org" , Andrew Morton , "Matthew Wilcox (Oracle)" , linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH v13 57/70] mm/mlock: use vma iterator and maple state instead of vma linked list Message-ID: References: <20220822150128.1562046-1-Liam.Howlett@oracle.com> <20220822150128.1562046-58-Liam.Howlett@oracle.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="3kTHvGW/5bDFz7Zb" Content-Disposition: inline In-Reply-To: <20220822150128.1562046-58-Liam.Howlett@oracle.com> X-Cookie: Who is John Galt? ARC-Authentication-Results: i=1; imf10.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=B3p67HJk; spf=pass (imf10.hostedemail.com: domain of broonie@kernel.org designates 145.40.68.75 as permitted sender) smtp.mailfrom=broonie@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1661387680; a=rsa-sha256; cv=none; b=IFHwe2RCxTrMWMxPh564MGreoGrCdqCEUDusDNPDsvrrO0lfDWVh9CAXPJgEXrYnZZdxxZ gWz1j3+TcmPY1ENHN2gK5QWMvQ3dMYXgrQ2ODyvPprgabhjnw3GQOuIHWpW5DV+53DbKlT aWlz+HV2gTmzvE696DrI5sjMFPLfUOI= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1661387680; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Hs09tMixXhJbSuyUDl3OAbgZ4IbtZfhdZ6lGIhdQ00Y=; b=msJRqUwrsH211brMVQ2Kar/uSpdhxer+c5AnGnLX4NZ0P6ok+XzK8Rd+HIiq2Ywq9WsXmA Cn1W2eh//Yzz4LtkTHpiY1TQKinNDY3XC4lxS6Ui7GHZHqWbaMLpJejCT/pzToxMYBVmHO hhvgyz9X+h//8F7gyqZ4edKg10mX8mY= Authentication-Results: imf10.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=B3p67HJk; spf=pass (imf10.hostedemail.com: domain of broonie@kernel.org designates 145.40.68.75 as permitted sender) smtp.mailfrom=broonie@kernel.org; dmarc=pass (policy=none) header.from=kernel.org X-Stat-Signature: yc356bg86h6yu9t1p413ogrr8azcxno8 X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: B00A3C0036 X-Rspam-User: X-HE-Tag: 1661387680-481783 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: --3kTHvGW/5bDFz7Zb Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Aug 22, 2022 at 03:06:30PM +0000, Liam Howlett wrote: > From: "Matthew Wilcox (Oracle)" >=20 > Handle overflow checking in count_mm_mlocked_page_nr() differently. Our QA team found that since next-20220823 we're seeing a couple of test failures in the check_mmap_options kselftest on arm64 platforms with MTE that aren't present in mainline: # # FAIL: mprotect not ignoring clear PROT_MTE property # not ok 21 Check clear PROT_MTE flags with private mapping, sync error mod= e and mmap memory # # FAIL: mprotect not ignoring clear PROT_MTE property # not ok 22 Check clear PROT_MTE flags with private mapping and sync error = mode and mmap/mprotect memory I bisected this using qemu[1] which landed on 4ceb4bca479d41a ("mm/mprotect: use maple tree navigation instead of vma linked list"), though I'm not 100% sure I trust the specific identification of the commit I'm pretty confident it's at the very least in this series. I've not done any analysis of the failure beyond getting this bisect result. [1] qemu -smp cpus=3D4 -cpu max -machine virt,gic-version=3D3,mte=3Don --3kTHvGW/5bDFz7Zb Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAmMGw5cACgkQJNaLcl1U h9CETwf+LuiyCa2vnhNkK0FYpnS/7LqL3rzOSWV7goeH7LToVBr2BjbzSjnGlxIO BJ9L4MP6RC8a/0ss3fPm36g/IwOB/aSaHfsmseWji86aUFb6XonfAKj6qugMsNwe LWEcjrMSj3RSLXfNfAdI0M0OLBfJ04VkFLrJABQYl48Yrb2QwMQlvgWvwSokHM84 f5QNWnlcvS1o58/QVZhwn7kk/JvFVIrX3Fuiae6L+nLSfEVPCeOwJohjyCZB9+3m z7YIA89zBRIeVJUpDIGvGKHAX8RovKSrlMWKsW8vhbffjp4c7Td9VYG3wP7GfFAU t3xQm17IiUShPZga22HlekJlUr+USg== =DFuJ -----END PGP SIGNATURE----- --3kTHvGW/5bDFz7Zb--