From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id AF334ECAAD5 for ; Tue, 6 Sep 2022 18:23:44 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 3A0DA8D0001; Tue, 6 Sep 2022 14:23:44 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 351316B0074; Tue, 6 Sep 2022 14:23:44 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 2195E8D0001; Tue, 6 Sep 2022 14:23:44 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 1318D6B0072 for ; Tue, 6 Sep 2022 14:23:44 -0400 (EDT) Received: from smtpin12.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id A9CD616075C for ; Tue, 6 Sep 2022 18:23:43 +0000 (UTC) X-FDA: 79882483926.12.A2E3014 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) by imf27.hostedemail.com (Postfix) with ESMTP id 876FE400B0 for ; Tue, 6 Sep 2022 18:23:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=Sender:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=1ejsbWc7jxzdVv9EfTlV6LG/ILo5vqEFK0R9Sl/pPsw=; b=RcFeeBEBSNmBmJhbE5bo1gSZ/S Q0PPGU/Y24JkA4LbeK/L6cNKW9pN+rJSZKAS/PLfwAxf70EubNOTY90DX//vg7TDOnbRcuEC1kqJ6 yyfyXhPPAeEEq+FEcfE4nY/EZcL8lcm5GviAzxj13p8uBlJleJo+geC8AMCgpLmRnmRy/UBRw75GZ WbQ9ldohcl0U82HjcvImBEgkHAZulUrCLUbI0o8ZhQ2qqYufjlPRz0X1HR3cAITvHUNPnYYl9VhTh euUoKXcggwKM34/V9DgpcyCiZOguaWuyI6Ult8FqgoT1LKR08JkecWnw1wJyvv1V6yCbS9zp1R9I1 xx1W8P1g==; Received: from mcgrof by bombadil.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1oVdDz-00GKFq-Le; Tue, 06 Sep 2022 18:23:03 +0000 Date: Tue, 6 Sep 2022 11:23:03 -0700 From: Luis Chamberlain To: Wupeng Ma Cc: akpm@linux-foundation.org, david@redhat.com, npiggin@suse.de, ying.huang@intel.com, hannes@cmpxchg.org, corbet@lwn.net, mgorman@suse.de, keescook@chromium.org, yzaikin@google.com, songmuchun@bytedance.com, mike.kravetz@oracle.com, osalvador@suse.de, surenb@google.com, rppt@kernel.org, charante@codeaurora.org, jsavitz@redhat.com, linux-kernel@vger.kernel.org, linux-mm@kvack.org, kernel test robot Subject: Re: [PATCH -next v3 2/2] mm: sysctl: Introduce per zone watermark_scale_factor Message-ID: References: <20220905032858.1462927-1-mawupeng1@huawei.com> <20220905032858.1462927-3-mawupeng1@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220905032858.1462927-3-mawupeng1@huawei.com> ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1662488623; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=1ejsbWc7jxzdVv9EfTlV6LG/ILo5vqEFK0R9Sl/pPsw=; b=BduLr/BXdczCpO1Tgjm778F/8OL3t1HydBiNnNYXKztjKl6ag9h0+7VEOhkIDbrMZ7kLRS J5gnUxlIl0+H5e7YgspceFHyRwhCiPjF5yNXAXUxpM11AqYE5xZGBEvObD2gwNWJ8MTttK LXwcURH2upfTqXno/mINZJ9x/6dmLTQ= ARC-Authentication-Results: i=1; imf27.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=RcFeeBEB; spf=none (imf27.hostedemail.com: domain of mcgrof@infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=mcgrof@infradead.org; dmarc=fail reason="No valid SPF, DKIM not aligned (relaxed)" header.from=kernel.org (policy=none) ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1662488623; a=rsa-sha256; cv=none; b=RunPAGa0F1VBJxTyy6KSIW4t0AL1z4b/lgcPXUEEIFsKTXbi3ePbI4+czVEQtXkgkALEqA 2fsaJ2AHs+NEykZ0ztKy2EO8ER2aEXHciBjik10y19013FILJ2hSiKC3tK3Vu6dIN/LkMp h2ZbEFbPk7Od/qeeR2NnP1PDf18eSOQ= X-Stat-Signature: m6eb8xkc9dmqjmq16wba78w17xadzmz5 X-Rspam-User: X-Rspamd-Queue-Id: 876FE400B0 Authentication-Results: imf27.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=RcFeeBEB; spf=none (imf27.hostedemail.com: domain of mcgrof@infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=mcgrof@infradead.org; dmarc=fail reason="No valid SPF, DKIM not aligned (relaxed)" header.from=kernel.org (policy=none) X-Rspamd-Server: rspam01 X-HE-Tag: 1662488622-304802 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Sep 05, 2022 at 11:28:58AM +0800, Wupeng Ma wrote: > diff --git a/kernel/sysctl.c b/kernel/sysctl.c > index 205d605cacc5..d16d06c71e5a 100644 > --- a/kernel/sysctl.c > +++ b/kernel/sysctl.c > @@ -2251,8 +2251,6 @@ static struct ctl_table vm_table[] = { > .maxlen = sizeof(watermark_scale_factor), > .mode = 0644, > .proc_handler = watermark_scale_factor_sysctl_handler, > - .extra1 = SYSCTL_ONE, > - .extra2 = SYSCTL_THREE_THOUSAND, > }, > { > .procname = "percpu_pagelist_high_fraction", Please move the sysctl from kernel/sysctl.c to mm/page_alloc.c while at it, you can git log the kernel/sysctl.c for prior moves and for the motivations. No need to keep expanding on the existing table. Luis