From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id A4308C38145 for ; Wed, 7 Sep 2022 15:45:19 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 13A2E6B0072; Wed, 7 Sep 2022 11:45:19 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 0E9DB8D0001; Wed, 7 Sep 2022 11:45:19 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id EF3556B0074; Wed, 7 Sep 2022 11:45:18 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id DF7EB6B0072 for ; Wed, 7 Sep 2022 11:45:18 -0400 (EDT) Received: from smtpin16.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id AFD2380AD6 for ; Wed, 7 Sep 2022 15:45:18 +0000 (UTC) X-FDA: 79885713516.16.6A0D0AE Received: from mail-pl1-f178.google.com (mail-pl1-f178.google.com [209.85.214.178]) by imf30.hostedemail.com (Postfix) with ESMTP id EC4F28009A for ; Wed, 7 Sep 2022 15:45:17 +0000 (UTC) Received: by mail-pl1-f178.google.com with SMTP id p18so14977494plr.8 for ; Wed, 07 Sep 2022 08:45:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:sender:from:to:cc:subject:date; bh=2Bs5WeryLUwa4Em1EtgsOFsgucZrdl6s2s+rxtjCKv0=; b=GxZU/LPMUM2KaQzz22yGfVZ0We3v/2AvN6pejZw2UwV51PxFDYfmieeDwxAEIBEbCe FQ72oqE3rYDNlKuQBtdr6/CLx48G2JCzMLv/Sa0M9GDF54vR4yoAeJeHyrM7R86jGHa6 2+w3e5Ntk8A04yteNqP3T/ta9icCvGnrcwvuI0UuKUcr2RGXcULYUEdOcHFphnDLPUsK GnbL5qo3awvEkIfiBOSJXiOfkERKwb9ES7IZLbTNMwFWimoAS1+h7t9SatGqjur9L5Ev GIDbpI9wn5g/vtaZeKua6lIh8BgDP+2yocrlNWS9DJ70hRjjf2vmPNSyNvV5Bnd9ld4g RMdg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:sender:x-gm-message-state:from:to:cc :subject:date; bh=2Bs5WeryLUwa4Em1EtgsOFsgucZrdl6s2s+rxtjCKv0=; b=a/SjfELTSWFUL03q4mbNt2zAriGRZDRa9Yw6qWDRB+neZzyC/pv5UvyPT7hWzFcBpI /8FbNadf92mNDIxxjekytJtoD/p3Klk6OWFccssiyC8mbkw0H46UPwmCNmlsJNtNADGK CjHSjzxl5slZdRKX2HggIaIClzArnZFjcK2rLvneqNbcGNgf0GrRhuLgZ9qWI8YaJ7xr vHdqFKwG1SBDsqlFW6F/vhWpEmfxSD6+YH317sjuIge9a+yOHIt23Gh/7yKrKKLuKFEK zU6TpdQ+i85gYqbSoH/+a3aOx8RGP72VtmtuGz8ltJkdwJqpJy5FKz5dhccSTy0GHgIb bUjA== X-Gm-Message-State: ACgBeo03AQFvXeqd9VTwVWsXFeFW3EvrTx6GilqwCnwjk7XUalpNbzVl KrNiBgT9Zl7jKJjtK3fKZgg= X-Google-Smtp-Source: AA6agR6i5fmZcERBsBE/o4wuPIE+v1IqIaxzMYQsvK1QTKGQ/xkfOPZ+F7IgGN7ueffOchvyeQOiPQ== X-Received: by 2002:a17:90b:4b08:b0:1fe:54ac:6b6 with SMTP id lx8-20020a17090b4b0800b001fe54ac06b6mr4794370pjb.208.1662565516758; Wed, 07 Sep 2022 08:45:16 -0700 (PDT) Received: from localhost (2603-800c-1a02-1bae-a7fa-157f-969a-4cde.res6.spectrum.com. [2603:800c:1a02:1bae:a7fa:157f:969a:4cde]) by smtp.gmail.com with ESMTPSA id 125-20020a620483000000b0053dea60f3c8sm5793866pfe.87.2022.09.07.08.45.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 07 Sep 2022 08:45:16 -0700 (PDT) Date: Wed, 7 Sep 2022 05:45:15 -1000 From: Tejun Heo To: Yafang Shao Cc: ast@kernel.org, daniel@iogearbox.net, andrii@kernel.org, kafai@fb.com, songliubraving@fb.com, yhs@fb.com, john.fastabend@gmail.com, kpsingh@kernel.org, sdf@google.com, haoluo@google.com, jolsa@kernel.org, hannes@cmpxchg.org, mhocko@kernel.org, roman.gushchin@linux.dev, shakeelb@google.com, songmuchun@bytedance.com, akpm@linux-foundation.org, lizefan.x@bytedance.com, cgroups@vger.kernel.org, netdev@vger.kernel.org, bpf@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH bpf-next v3 00/13] bpf: Introduce selectable memcg for bpf map Message-ID: References: <20220902023003.47124-1-laoar.shao@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: ARC-Authentication-Results: i=1; imf30.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b="GxZU/LPM"; spf=pass (imf30.hostedemail.com: domain of htejun@gmail.com designates 209.85.214.178 as permitted sender) smtp.mailfrom=htejun@gmail.com; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=kernel.org (policy=none) ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1662565517; a=rsa-sha256; cv=none; b=BFuRdDwedwKXiBFrDXT4RdFItMa+ERxkJodGBoirwqNRmzUF6QLlHvZ7u6W+dswICRH8P8 K0WyT0nwZE5fgtAtvnKBjKS0TMMg6dzkfD6q5Pw3Bo9AjmJMwP4hm8Ad/maRJykhpFZvKO WeV0IGv1Fvyt7sSk1q4rHIYXnbn1lz4= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1662565517; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=2Bs5WeryLUwa4Em1EtgsOFsgucZrdl6s2s+rxtjCKv0=; b=cxG9wT+GBdQdMn5bOPu4I1OUOc0CKQKYOl3eyBOiLmhKbbaxD1DRgBQfBtdif08HfBD96v 0y5s960Ctckc6vnJ3aDMcAnA2jGxwI+5mRkNgwfmDX0NySqEUZ+Nt7oZwG+Lkx8MMk7kNr O/oQgVHmG2DTfRKc1+WLM5OYfJnlfro= Authentication-Results: imf30.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b="GxZU/LPM"; spf=pass (imf30.hostedemail.com: domain of htejun@gmail.com designates 209.85.214.178 as permitted sender) smtp.mailfrom=htejun@gmail.com; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=kernel.org (policy=none) X-Rspam-User: X-Rspamd-Queue-Id: EC4F28009A X-Rspamd-Server: rspam10 X-Stat-Signature: 11jyedwrkmb8xmfdip1fn6xig7jtg9to X-HE-Tag: 1662565517-439181 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Sep 07, 2022 at 05:43:31AM -1000, Tejun Heo wrote: > Hello, > > On Fri, Sep 02, 2022 at 02:29:50AM +0000, Yafang Shao wrote: > ... > > This patchset tries to resolve the above two issues by introducing a > > selectable memcg to limit the bpf memory. Currently we only allow to > > select its ancestor to avoid breaking the memcg hierarchy further. > > Possible use cases of the selectable memcg as follows, > > As discussed in the following thread, there are clear downsides to an > interface which requires the users to specify the cgroups directly. > > https://lkml.kernel.org/r/YwNold0GMOappUxc@slm.duckdns.org > > So, I don't really think this is an interface we wanna go for. I was hoping > to hear more from memcg folks in the above thread. Maybe ping them in that > thread and continue there? Ah, another thing. If the memcg accounting is breaking things right now, we can easily introduce a memcg disable flag for bpf memory. That should help alleviating the immediate breakage while we figure this out. Thanks. -- tejun