From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Lukas Bulwahn <lukas.bulwahn@gmail.com>
Cc: Russell King <linux@armlinux.org.uk>,
linux-arm-kernel@lists.infradead.org,
Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
Dave Hansen <dave.hansen@linux.intel.com>,
x86@kernel.org, Mauro Carvalho Chehab <mchehab@kernel.org>,
linux-media@vger.kernel.org, Peter Chen <peter.chen@kernel.org>,
linux-usb@vger.kernel.org,
Andrew Morton <akpm@linux-foundation.org>,
Mike Rapoport <rppt@linux.ibm.com>,
linux-mm@kvack.org, Masahiro Yamada <masahiroy@kernel.org>,
linux-kbuild@vger.kernel.org, kernel-janitors@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 4/6] usb: chipidea: make configs for glue drivers visible with EXPERT
Date: Thu, 8 Sep 2022 13:33:55 +0200 [thread overview]
Message-ID: <YxnTI927V0hGs+kz@kroah.com> (raw)
In-Reply-To: <20220908104337.11940-5-lukas.bulwahn@gmail.com>
On Thu, Sep 08, 2022 at 12:43:35PM +0200, Lukas Bulwahn wrote:
> Commit 6a108a14fa35 ("kconfig: rename CONFIG_EMBEDDED to CONFIG_EXPERT")
> introduces CONFIG_EXPERT to carry the previous intent of CONFIG_EMBEDDED
> and just gives that intent a much better name. That has been clearly a good
> and long overdue renaming, and it is clearly an improvement to the kernel
> build configuration that has shown to help managing the kernel build
> configuration in the last decade.
>
> However, rather than bravely and radically just deleting CONFIG_EMBEDDED,
> this commit gives CONFIG_EMBEDDED a new intended semantics, but keeps it
> open for future contributors to implement that intended semantics:
>
> A new CONFIG_EMBEDDED option is added that automatically selects
> CONFIG_EXPERT when enabled and can be used in the future to isolate
> options that should only be considered for embedded systems (RISC
> architectures, SLOB, etc).
>
> Since then, this CONFIG_EMBEDDED implicitly had two purposes:
>
> - It can make even more options visible beyond what CONFIG_EXPERT makes
> visible. In other words, it may introduce another level of enabling the
> visibility of configuration options: always visible, visible with
> CONFIG_EXPERT and visible with CONFIG_EMBEDDED.
>
> - Set certain default values of some configurations differently,
> following the assumption that configuring a kernel build for an
> embedded system generally starts with a different set of default values
> compared to kernel builds for all other kind of systems.
>
> Considering the first purpose, at the point in time where CONFIG_EMBEDDED
> was renamed to CONFIG_EXPERT, CONFIG_EXPERT already made 130 more options
> become visible throughout all different menus for the kernel configuration.
> Over the last decade, this has gradually increased, so that currently, with
> CONFIG_EXPERT, roughly 170 more options become visible throughout all
> different menus for the kernel configuration. In comparison, currently with
> CONFIG_EMBEDDED enabled, just seven more options are visible, one in x86,
> one in arm, and five for the ChipIdea Highspeed Dual Role Controller.
>
> As the numbers suggest, these two levels of enabling the visibility of even
> more configuration options---beyond what CONFIG_EXPERT enables---never
> evolved to a good solution in the last decade. In other words, this
> additional level of visibility of configuration option with CONFIG_EMBEDDED
> compared to CONFIG_EXPERT has since its introduction never become really
> valuable. It requires quite some investigation to actually understand what
> is additionally visible and it does not differ significantly in complexity
> compared to just enabling CONFIG_EXPERT. This CONFIG_EMBEDDED---or any
> other config to show more detailed options beyond CONFIG_EXPERT---is
> unlikely to be valuable unless somebody puts significant effort in
> identifying how such visibility options can be properly split and creating
> clear criteria, when some config option is visible with CONFIG_EXPERT and
> when some config option is visible only with some further option enabled
> beyond CONFIG_EXPERT, such as CONFIG_EMBEDDED attempted to do. For now, it
> is much more reasonable to simply make those additional seven options that
> visible with CONFIG_EMBEDDED, visible with CONFIG_EXPERT, and then remove
> CONFIG_EMBEDDED. If anyone spends significant effort in structuring the
> visibility of config options, they may re-introduce suitable new config
> options simply as they see fit.
>
> Make the configs for usb chipidea glue drivers visible when CONFIG_EXPERT
> is enabled.
>
> Signed-off-by: Lukas Bulwahn <lukas.bulwahn@gmail.com>
> ---
> drivers/usb/chipidea/Kconfig | 10 +++++-----
> 1 file changed, 5 insertions(+), 5 deletions(-)
Now queued up in my USB tree, thanks.
greg k-h
next prev parent reply other threads:[~2022-09-08 11:33 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-08 10:43 [PATCH 0/6] Remove CONFIG_EMBEDDED Lukas Bulwahn
2022-09-08 10:43 ` [PATCH 1/6] arm: make config ARM_PATCH_PHYS_VIRT visible with EXPERT Lukas Bulwahn
2022-09-09 6:21 ` Masahiro Yamada
2022-09-08 10:43 ` [PATCH 2/6] x86: make config X86_FEATURE_NAMES " Lukas Bulwahn
2022-09-09 6:22 ` Masahiro Yamada
2022-09-08 10:43 ` [PATCH 3/6] media: remove reference to CONFIG_EMBEDDED in MEDIA_SUPPORT_FILTER Lukas Bulwahn
2022-09-08 11:13 ` Mauro Carvalho Chehab
2022-09-08 16:20 ` Mauro Carvalho Chehab
2022-09-09 6:22 ` Masahiro Yamada
2022-09-08 10:43 ` [PATCH 4/6] usb: chipidea: make configs for glue drivers visible with EXPERT Lukas Bulwahn
2022-09-08 11:33 ` Greg Kroah-Hartman [this message]
2022-09-09 6:22 ` Masahiro Yamada
2022-09-08 10:43 ` [PATCH 5/6] mm: Kconfig: make config SECRETMEM " Lukas Bulwahn
2022-09-08 11:24 ` Mike Rapoport
2022-09-09 6:22 ` Masahiro Yamada
2022-09-08 10:43 ` [PATCH 6/6] init/Kconfig: remove confusing config EMBEDDED Lukas Bulwahn
2022-09-09 6:24 ` Masahiro Yamada
2022-09-09 9:23 ` Christophe Leroy
2022-09-09 9:47 ` Lukas Bulwahn
2022-09-08 15:21 ` [PATCH 0/6] Remove CONFIG_EMBEDDED Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YxnTI927V0hGs+kz@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=akpm@linux-foundation.org \
--cc=bp@alien8.de \
--cc=dave.hansen@linux.intel.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-usb@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=lukas.bulwahn@gmail.com \
--cc=masahiroy@kernel.org \
--cc=mchehab@kernel.org \
--cc=mingo@redhat.com \
--cc=peter.chen@kernel.org \
--cc=rppt@linux.ibm.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).