From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id A7F57C38145 for ; Thu, 8 Sep 2022 16:54:07 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 25C316B0072; Thu, 8 Sep 2022 12:54:07 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 20BD06B0073; Thu, 8 Sep 2022 12:54:07 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 0D3EB8D0002; Thu, 8 Sep 2022 12:54:07 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id EEBE56B0072 for ; Thu, 8 Sep 2022 12:54:06 -0400 (EDT) Received: from smtpin08.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id C4266C09A8 for ; Thu, 8 Sep 2022 16:54:06 +0000 (UTC) X-FDA: 79889515692.08.ACAFB70 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf22.hostedemail.com (Postfix) with ESMTP id 6A467C008F for ; Thu, 8 Sep 2022 16:54:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=Wbmln1kNR8hccItKJCnaBOvzDTVXLhiF2eeXL7RfOdI=; b=kNBPUJoYroA5CfTIFh1rNg8JFg zvLWUK9xW6DknydoZv0ZcuDLCxx6OVKDkzFzsJ3O31nnfOApNaKIKoniPycWmIj7V9R68Lrck5ocI z02G3Kbb+maqNEAj/Drn9u6GGvvG8nuoUZlEMnPvOSVGk+Pt2w3u7tOLfNmqQzWRTSn1qkELxrDbB HR7hM7o6IgwIClt7nXDgK9wqY8ZcOuD857XMNUxEFbOpDy0KLaTdq520qith2gdKh4KyURGg+PlVj 63j0OML/QTh4q7ZWc3etjWlvfzVweV3yLhLrwIaSnQQjtZ0J/GjguY2kw8ZCtCGWvB+W4qHfcryOx KMyRAYYg==; Received: from willy by casper.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1oWKmb-00CVbD-Tc; Thu, 08 Sep 2022 16:53:41 +0000 Date: Thu, 8 Sep 2022 17:53:41 +0100 From: Matthew Wilcox To: "Aneesh Kumar K.V" Cc: linuxppc-dev@lists.ozlabs.org, mpe@ellerman.id.au, npiggin@gmail.com, christophe.leroy@csgroup.eu, linux-mm@kvack.org, akpm@linux-foundation.org, David Howells , linux-fsdevel@vger.kernel.org, Al Viro Subject: Re: [RFC PATCH] fs/hugetlb: Fix UBSAN warning reported on hugetlb Message-ID: References: <20220908072659.259324-1-aneesh.kumar@linux.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220908072659.259324-1-aneesh.kumar@linux.ibm.com> ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1662656046; a=rsa-sha256; cv=none; b=75f3y3W5Rse6Xmcta+T/i8uH9LZxLxdhsr3s4MOSO/mA3+dBqLFu0xMt6zdllFC2LfgX6L TZfuVAH/QvzelPChcZIelURXLUT1Z5hcZWugwX7Y4QrZkka940VWFr9bauHKmg2af408pU 8UcJo57n8MDdU/3opETMSYf0DPxZkH8= ARC-Authentication-Results: i=1; imf22.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=kNBPUJoY; spf=none (imf22.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1662656046; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Wbmln1kNR8hccItKJCnaBOvzDTVXLhiF2eeXL7RfOdI=; b=Iquc0Zk1YYuDqFAXmWv7VXhvMChmGU9UplwgilhjPd0t0qYZdLE7GZND6YgB14T3F3MuqJ 31aY75UpBe7jODfW/ny5r03zFSjmyhJvq0zxrcbm9Ix+X0JoAoEcb+ArIQEYpuhFtIM3FJ /sDcdxV4BWTN+q7ugKKAsgTC6Dd7kns= X-Stat-Signature: m8h5ktpc4idi3qhoqbykfnd4p1658rs5 X-Rspamd-Queue-Id: 6A467C008F X-Rspamd-Server: rspam11 X-Rspam-User: Authentication-Results: imf22.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=kNBPUJoY; spf=none (imf22.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none X-HE-Tag: 1662656045-33176 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Sep 08, 2022 at 12:56:59PM +0530, Aneesh Kumar K.V wrote: > +++ b/fs/dax.c > @@ -1304,7 +1304,7 @@ EXPORT_SYMBOL_GPL(dax_zero_range); > int dax_truncate_page(struct inode *inode, loff_t pos, bool *did_zero, > const struct iomap_ops *ops) > { > - unsigned int blocksize = i_blocksize(inode); > + size_t blocksize = i_blocksize(inode); > unsigned int off = pos & (blocksize - 1); If blocksize is larger than 4GB, then off also needs to be size_t. > +++ b/fs/iomap/buffered-io.c > @@ -955,7 +955,7 @@ int > iomap_truncate_page(struct inode *inode, loff_t pos, bool *did_zero, > const struct iomap_ops *ops) > { > - unsigned int blocksize = i_blocksize(inode); > + size_t blocksize = i_blocksize(inode); > unsigned int off = pos & (blocksize - 1); Ditto. (maybe there are others; I didn't check closely)