From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 23581ECAAD3 for ; Fri, 9 Sep 2022 08:30:33 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 8C8A08D0007; Fri, 9 Sep 2022 04:30:32 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 878D48D0002; Fri, 9 Sep 2022 04:30:32 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 740D38D0007; Fri, 9 Sep 2022 04:30:32 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 64CED8D0002 for ; Fri, 9 Sep 2022 04:30:32 -0400 (EDT) Received: from smtpin06.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id CFDCE1A0A69 for ; Fri, 9 Sep 2022 08:30:31 +0000 (UTC) X-FDA: 79891875462.06.0BE9162 Received: from mail-pj1-f49.google.com (mail-pj1-f49.google.com [209.85.216.49]) by imf27.hostedemail.com (Postfix) with ESMTP id 78D04400D0 for ; Fri, 9 Sep 2022 08:30:31 +0000 (UTC) Received: by mail-pj1-f49.google.com with SMTP id o4so860769pjp.4 for ; Fri, 09 Sep 2022 01:30:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date; bh=Ou6wa1PVBMpfkqq+3IOtn1cL4mqN7hg0CTIQr6+JHrE=; b=k29S8AxGMHFWQb8aV9I9jiOP+bcF2zGv0IToTdNBof3ybIaNO4T6jnm1tS6/8PRK5h 3d/fYkpeUDTrLk8Ce9Pq4l80ZF7UWQlvgqCy1KGM7ZC2+o5myGT6mfr6UnHP+3Dqp9aA JUz/khEdoZI7lF6+uXIfRouWlO4OLPMQC8HPk= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date; bh=Ou6wa1PVBMpfkqq+3IOtn1cL4mqN7hg0CTIQr6+JHrE=; b=er7pG3dHnqfJBMIDR2xJUGCtEwwoEhWpqlPLinv9mnjh9h+340+h0Nh8fs5BvDW08a Bf4UgZDXnSb0neQjYAqlv1ZJ4gO68IIMBNR6pg8ukwReWyo4ynExZdqToNTNvV7zYHhQ F3Tpnz0EcK0Lb1iUufMagUXPAJ7h/DeZgX6FK4122A3Vh6ScMtc9htTBuZsVVoLclFCt 3X+7gy7h9j3nsvw55Q2mpRatAtlyOhxsZR6KLEV4XRs1eu4pAeD8n39Ko5Ml+TwIueHI XwKh3MCaYECuHrL0x5FIRieC2JoIrBcRh/hhb2braT7h/z6A4kXVPNqEtOMKFErv8DxT UXWg== X-Gm-Message-State: ACgBeo0ubA0pz/Z3KNbwz5DYrfUzYVikSCdDuavc0QoJDulZ1RK24Haz SGYFIbEGcNpuuh1IeY2Zw/Sigw== X-Google-Smtp-Source: AA6agR4REQKERpKP0UCk9dLv0Tcg8I1xeCZhKyCdHUjFT3qh8cSkvjXT/9g5ibSPuPgdd7nAKJ1YNQ== X-Received: by 2002:a17:902:d58a:b0:177:f86c:4456 with SMTP id k10-20020a170902d58a00b00177f86c4456mr5545162plh.171.1662712230384; Fri, 09 Sep 2022 01:30:30 -0700 (PDT) Received: from google.com ([240f:75:7537:3187:48ca:975b:3395:bf]) by smtp.gmail.com with ESMTPSA id e125-20020a621e83000000b0052dbad1ea2esm1054354pfe.6.2022.09.09.01.30.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 09 Sep 2022 01:30:29 -0700 (PDT) Date: Fri, 9 Sep 2022 17:30:24 +0900 From: Sergey Senozhatsky To: Brian Geffon , Minchan Kim Cc: Andrew Morton , Nitin Gupta , Sergey Senozhatsky , linux-kernel@vger.kernel.org, Suleiman Souhlal , Rom Lemarchand , linux-mm@kvack.org Subject: Re: [RESEND RFC] zram: Allow rw_page when page isn't written back. Message-ID: References: <20220908125037.1119114-1-bgeffon@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220908125037.1119114-1-bgeffon@google.com> ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1662712231; a=rsa-sha256; cv=none; b=FtTPfVqc+GOwvyjtTZ2wPpFRuZt+56jSXtXtIjd53HzVkNAHh8wG/9gyAqJqRjOzkghR7r Yfs+VPHGpchnQIpK+8IyCR9LnTqO5xs643HxLlONBusZISkpI8TLORwlT2fxoILlucz5YS nSKvlsWvcP/ubgM7Bya5WJu4XcOIy+Y= ARC-Authentication-Results: i=1; imf27.hostedemail.com; dkim=pass header.d=chromium.org header.s=google header.b=k29S8AxG; spf=pass (imf27.hostedemail.com: domain of senozhatsky@chromium.org designates 209.85.216.49 as permitted sender) smtp.mailfrom=senozhatsky@chromium.org; dmarc=pass (policy=none) header.from=chromium.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1662712231; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Ou6wa1PVBMpfkqq+3IOtn1cL4mqN7hg0CTIQr6+JHrE=; b=OcojffwLuFTGtYCX6BivYaqhwzUjC+N9jA3P0Lwci0Zv/ZbuRhT9CFVV05sqyk11DTMyYq 8GWcD0Sa300tsxHqafURTuBeigGUwEiFAwM0HsnPkTGbbFZfeUZH0gXXMUWtllAf+CBO+8 WLoLCCT2F00ep5fKqAZvfNeMa9kdlGo= X-Stat-Signature: pkeskjmbth4brrkhnx57kiyw68z1oew1 X-Rspamd-Queue-Id: 78D04400D0 X-Rspamd-Server: rspam11 X-Rspam-User: Authentication-Results: imf27.hostedemail.com; dkim=pass header.d=chromium.org header.s=google header.b=k29S8AxG; spf=pass (imf27.hostedemail.com: domain of senozhatsky@chromium.org designates 209.85.216.49 as permitted sender) smtp.mailfrom=senozhatsky@chromium.org; dmarc=pass (policy=none) header.from=chromium.org X-HE-Tag: 1662712231-188878 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000012, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On (22/09/08 08:50), Brian Geffon wrote: [..] > +++ b/drivers/block/zram/zram_drv.h > @@ -50,6 +50,7 @@ enum zram_pageflags { > ZRAM_UNDER_WB, /* page is under writeback */ > ZRAM_HUGE, /* Incompressible page */ > ZRAM_IDLE, /* not accessed page since last idle marking */ > + ZRAM_NO_WB, /* Do not allow page to be written back */ > > __NR_ZRAM_PAGEFLAGS, > }; Unrelated but somehow related. I wonder if it's time for us to introduce a dedicated, say u16, flags member to struct zram_table_entry. Unless my calculations are extremely wrong, we are about to run out of spare bits in zram_table_entry::flags on 32-bit systems.