From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id D9A7BECAAD8 for ; Tue, 13 Sep 2022 23:35:02 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 2603F8D0001; Tue, 13 Sep 2022 19:35:02 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 20EFE6B0073; Tue, 13 Sep 2022 19:35:02 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 0D8168D0001; Tue, 13 Sep 2022 19:35:02 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id EFF726B0071 for ; Tue, 13 Sep 2022 19:35:01 -0400 (EDT) Received: from smtpin13.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id C9689140591 for ; Tue, 13 Sep 2022 23:35:01 +0000 (UTC) X-FDA: 79908670002.13.C9AE383 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf21.hostedemail.com (Postfix) with ESMTP id 45DAC1C00AF for ; Tue, 13 Sep 2022 23:35:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=/9i0RT8xYnvhhYLydSNCy5w2V2bVU0zcdBS2b/Mx3KU=; b=t4p3qotLpiXBOK695FV6Av3c7P V9ch6wXoz1ze/fCRWkrmnKtiyv6PaIrGIqra//NJzO/QtAuQ55T8o35R8QevMFZ/1RRuhOIdBe0Pb avPTqmgXSgQ1OqwAURW4GVR+y4TIRhuAIq14QtDmIXoVDxzd3jv5vBBLC5789Wo00msxADOfYqo6d IP7LviZekrBf8W8u1g4RbQ1Bpc1F0suAv1V7jHk0oBFLZ2XyQNjY80HoVM4apaNTL112jO+GQTaU6 lzWwjEfT/q37SX/2QQDb5Eon30dK0Xg8IzwevJjJleospvIdLzX/LFXnkA3JNVm5WeLcfH8+OuinY ThNQ8k1A==; Received: from willy by casper.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1oYFQ0-00HI4E-6B; Tue, 13 Sep 2022 23:34:16 +0000 Date: Wed, 14 Sep 2022 00:34:16 +0100 From: Matthew Wilcox To: Doug Berger Cc: Andrew Morton , Jonathan Corbet , Rob Herring , Krzysztof Kozlowski , Frank Rowand , Mike Kravetz , Muchun Song , Mike Rapoport , Christoph Hellwig , Marek Szyprowski , Robin Murphy , Borislav Petkov , "Paul E. McKenney" , Neeraj Upadhyay , Randy Dunlap , Damien Le Moal , Florian Fainelli , David Hildenbrand , Zi Yan , Oscar Salvador , Hari Bathini , Kees Cook , - , KOSAKI Motohiro , Mel Gorman , linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linux-mm@kvack.org, iommu@lists.linux.dev Subject: Re: [PATCH 03/21] mm/hugetlb: correct demote page offset logic Message-ID: References: <20220913195508.3511038-1-opendmb@gmail.com> <20220913195508.3511038-4-opendmb@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220913195508.3511038-4-opendmb@gmail.com> ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1663112101; a=rsa-sha256; cv=none; b=BWfh8q99GHEdXiDR93ZrbQLjFfrqYgNu7HVHNK1vyDSHoOBgJgl/ibLzpglBmhU986J72d a11Q1Yv96hEB8O52UkUw7CTmSa+2jkI//fYXBAw6jrDNRbmznG15o5u5No5VJc7LKBi6d7 SbJSDNz/6M81kF46aiBVudi3RFWeT+8= ARC-Authentication-Results: i=1; imf21.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=t4p3qotL; spf=none (imf21.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1663112101; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=/9i0RT8xYnvhhYLydSNCy5w2V2bVU0zcdBS2b/Mx3KU=; b=Cq82l/40ghfKRjJsAVC2MJ4sbwh/+SVGIe0zRk99erystRzh3o0XDkmWKFuB9URrNZ+I4P UfP0TXaC1/OLg4aHlU4bWYeWjYZy/5HtvSE/SlS7lBha64WNwf7icEisGwHDsE1abNbaAu SVm/GlChaYn1qYh5REohMndAzGJDOoo= X-Rspam-User: Authentication-Results: imf21.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=t4p3qotL; spf=none (imf21.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none X-Rspamd-Server: rspam02 X-Stat-Signature: d45nq9iuzow4i8sko3qwftc4fu1o9pia X-Rspamd-Queue-Id: 45DAC1C00AF X-HE-Tag: 1663112100-48931 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Sep 13, 2022 at 12:54:50PM -0700, Doug Berger wrote: > With gigantic pages it may not be true that struct page structures > are contiguous across the entire gigantic page. The mem_map_offset > function is used here in place of direct pointer arithmetic to > correct for this. We're just eliminating mem_map_offset(). Please use nth_page() instead. > for (i = 0; i < pages_per_huge_page(h); > i += pages_per_huge_page(target_hstate)) { > + subpage = mem_map_offset(page, i); > if (hstate_is_gigantic(target_hstate))