From: Mike Kravetz <mike.kravetz@oracle.com>
To: Sidhartha Kumar <sidhartha.kumar@oracle.com>
Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org,
akpm@linux-foundation.org, songmuchun@bytedance.com,
willy@infradead.org, vbabka@suse.cz,
william.kucharski@oracle.com, dhowells@redhat.com,
peterx@redhat.com, arnd@arndb.de, ccross@google.com,
hughd@google.com, ebiederm@xmission.com
Subject: Re: [PATCH v3 4/6] mm/hugetlb: add hugetlb_set_folio_subpool() helper
Date: Mon, 19 Sep 2022 15:26:43 -0700 [thread overview]
Message-ID: <Yyjso0kmBD0U4RMv@monkey> (raw)
In-Reply-To: <20220908193706.1716548-5-sidhartha.kumar@oracle.com>
On 09/08/22 12:37, Sidhartha Kumar wrote:
> Allows hugetlb subpool information to be set through a folio.
>
> Signed-off-by: Sidhartha Kumar <sidhartha.kumar@oracle.com>
> ---
> fs/hugetlbfs/inode.c | 4 ++--
> include/linux/hugetlb.h | 8 +++++++-
> 2 files changed, 9 insertions(+), 3 deletions(-)
As previously mentioned, I would suggest just combining this with the
previous patch. Changes look fine.
--
Mike Kravetz
>
> diff --git a/fs/hugetlbfs/inode.c b/fs/hugetlbfs/inode.c
> index c2e9c0cdbd81..d9e08c445e2f 100644
> --- a/fs/hugetlbfs/inode.c
> +++ b/fs/hugetlbfs/inode.c
> @@ -1152,9 +1152,9 @@ static int hugetlbfs_migrate_folio(struct address_space *mapping,
> return rc;
>
> if (hugetlb_folio_subpool(src)) {
> - hugetlb_set_page_subpool(&dst->page,
> + hugetlb_set_folio_subpool(dst,
> hugetlb_folio_subpool(src));
> - hugetlb_set_page_subpool(&src->page, NULL);
> + hugetlb_set_folio_subpool(src, NULL);
> }
>
> if (mode != MIGRATE_SYNC_NO_COPY)
> diff --git a/include/linux/hugetlb.h b/include/linux/hugetlb.h
> index 1e7c4007386e..0bcaca694ab7 100644
> --- a/include/linux/hugetlb.h
> +++ b/include/linux/hugetlb.h
> @@ -757,10 +757,16 @@ static inline struct hugepage_subpool *hugetlb_page_subpool(struct page *hpage)
> return hugetlb_folio_subpool(page_folio(hpage));
> }
>
> +static inline void hugetlb_set_folio_subpool(struct folio *folio,
> + struct hugepage_subpool *subpool)
> +{
> + folio_set_private_1(folio, (unsigned long)subpool);
> +}
> +
> static inline void hugetlb_set_page_subpool(struct page *hpage,
> struct hugepage_subpool *subpool)
> {
> - set_page_private(hpage + SUBPAGE_INDEX_SUBPOOL, (unsigned long)subpool);
> + hugetlb_set_folio_subpool(page_folio(hpage), subpool);
> }
>
> static inline struct hstate *hstate_file(struct file *f)
> --
> 2.31.1
>
next prev parent reply other threads:[~2022-09-19 22:26 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-08 19:37 [PATCH v3 0/6] begin converting hugetlb code to folios Sidhartha Kumar
2022-09-08 19:37 ` [PATCH v3 1/6] mm/hugetlb: add folio support to hugetlb specific flag macros Sidhartha Kumar
2022-09-19 22:09 ` Mike Kravetz
2022-09-08 19:37 ` [PATCH v3 2/6] mm: add private field of first tail to struct page and struct folio Sidhartha Kumar
2022-09-19 22:14 ` Mike Kravetz
2022-09-08 19:37 ` [PATCH v3 3/6] mm/hugetlb: add hugetlb_folio_subpool() helper Sidhartha Kumar
2022-09-19 22:24 ` Mike Kravetz
2022-09-08 19:37 ` [PATCH v3 4/6] mm/hugetlb: add hugetlb_set_folio_subpool() helper Sidhartha Kumar
2022-09-19 22:26 ` Mike Kravetz [this message]
2022-09-08 19:37 ` [PATCH v3 5/6] hugetlbfs: convert hugetlb_delete_from_page_cache() to use folios Sidhartha Kumar
2022-09-19 22:33 ` Mike Kravetz
2022-09-08 19:37 ` [PATCH v3 6/6] mm/hugetlb: add folio_hstate() Sidhartha Kumar
2022-09-19 22:43 ` Mike Kravetz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Yyjso0kmBD0U4RMv@monkey \
--to=mike.kravetz@oracle.com \
--cc=akpm@linux-foundation.org \
--cc=arnd@arndb.de \
--cc=ccross@google.com \
--cc=dhowells@redhat.com \
--cc=ebiederm@xmission.com \
--cc=hughd@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=peterx@redhat.com \
--cc=sidhartha.kumar@oracle.com \
--cc=songmuchun@bytedance.com \
--cc=vbabka@suse.cz \
--cc=william.kucharski@oracle.com \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).