From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 31549C07E9D for ; Mon, 26 Sep 2022 07:49:23 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 7CE9F900012; Mon, 26 Sep 2022 03:49:22 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 77E30900002; Mon, 26 Sep 2022 03:49:22 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 6457E900012; Mon, 26 Sep 2022 03:49:22 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 5268D900002 for ; Mon, 26 Sep 2022 03:49:22 -0400 (EDT) Received: from smtpin02.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 1A67040742 for ; Mon, 26 Sep 2022 07:49:22 +0000 (UTC) X-FDA: 79953461364.02.31B9908 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by imf24.hostedemail.com (Postfix) with ESMTP id A977A180007 for ; Mon, 26 Sep 2022 07:49:21 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 5B2BD21BE3; Mon, 26 Sep 2022 07:49:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1664178560; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=VX6pvgjSa7xlYXLMPzQ/q5ZL0MRRPIMy0fepPqULx5Q=; b=FgNrf41ceAn1rqG7vRjTqnABF8p9/tkXtTle8rW4fPX2ERr+MxyFtdostCF89SZ5BtR3va EbfT535YnHU4Ut8AggUnUtbvQFKsVdWW76IzXrRRpAp/LEOI+AT0MgjPpHhq7ByYsyowLY 6ltnMMNQp/e4Xp0yYPYoSKc+ALz+b04= Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 38D64139BD; Mon, 26 Sep 2022 07:49:20 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id oiKSC4BZMWOnQwAAMHmgww (envelope-from ); Mon, 26 Sep 2022 07:49:20 +0000 Date: Mon, 26 Sep 2022 09:49:19 +0200 From: Michal Hocko To: Florian Westphal Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, vbabka@suse.cz, akpm@linux-foundation.org, urezki@gmail.com, netdev@vger.kernel.org, netfilter-devel@vger.kernel.org, Martin Zaharinov Subject: Re: [PATCH mm] mm: fix BUG with kvzalloc+GFP_ATOMIC Message-ID: References: <20220923103858.26729-1-fw@strlen.de> <20220923133512.GE22541@breakpoint.cc> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220923133512.GE22541@breakpoint.cc> ARC-Authentication-Results: i=1; imf24.hostedemail.com; dkim=pass header.d=suse.com header.s=susede1 header.b=FgNrf41c; spf=pass (imf24.hostedemail.com: domain of mhocko@suse.com designates 195.135.220.28 as permitted sender) smtp.mailfrom=mhocko@suse.com; dmarc=pass (policy=quarantine) header.from=suse.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1664178561; a=rsa-sha256; cv=none; b=omH2C8l3wSLSwDvB0MMkUp+KLC8FZbtkXMUlEivq4AW1o1pgqgK/cesOwwfNdnW3Gm6g+E Sgvx0Wo/1SiEddP79dyaIvKg2PF4I0JlGzX04T44yDUcTyVOmEZIXZMZHXqhq8TV/LXL7o SKDUqgZrv+cmHyb08Zb+aIsy+y63sHw= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1664178561; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=VX6pvgjSa7xlYXLMPzQ/q5ZL0MRRPIMy0fepPqULx5Q=; b=7C9LrMRA1iydCF5RGRXBCf5/7/sdrFebuDrl1IplEnHf6F8srJC77mS7nysRh3HBuzFU/s aVW7jbz53YXPx4FZkUXzGEUO4XwvDI+C8AZg9dOy8/4qTpStsPuGO0cwYa6MEN7CRvk4J9 tim/xxjPG0SiTG/3Vb5FSEm8rn4Y814= X-Stat-Signature: yjx4poy9ahfgbsibi6bg7w7dy7oehreb X-Rspamd-Queue-Id: A977A180007 Authentication-Results: imf24.hostedemail.com; dkim=pass header.d=suse.com header.s=susede1 header.b=FgNrf41c; spf=pass (imf24.hostedemail.com: domain of mhocko@suse.com designates 195.135.220.28 as permitted sender) smtp.mailfrom=mhocko@suse.com; dmarc=pass (policy=quarantine) header.from=suse.com X-Rspam-User: X-Rspamd-Server: rspam03 X-HE-Tag: 1664178561-442881 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri 23-09-22 15:35:12, Florian Westphal wrote: > Michal Hocko wrote: > > On Fri 23-09-22 12:38:58, Florian Westphal wrote: > > > Martin Zaharinov reports BUG() in mm land for 5.19.10 kernel: > > > kernel BUG at mm/vmalloc.c:2437! > > > invalid opcode: 0000 [#1] SMP > > > CPU: 28 PID: 0 Comm: swapper/28 Tainted: G W O 5.19.9 #1 > > > [..] > > > RIP: 0010:__get_vm_area_node+0x120/0x130 > > > __vmalloc_node_range+0x96/0x1e0 > > > kvmalloc_node+0x92/0xb0 > > > bucket_table_alloc.isra.0+0x47/0x140 > > > rhashtable_try_insert+0x3a4/0x440 > > > rhashtable_insert_slow+0x1b/0x30 > > > [..] > > > > > > bucket_table_alloc uses kvzallocGPF_ATOMIC). If kmalloc fails, this now > > > falls through to vmalloc and hits code paths that assume GFP_KERNEL. > > > > > > Revert the problematic change and stay with slab allocator. > > > > Why don't you simply fix the caller? > > Uh, not following? > > kvzalloc(GFP_ATOMIC) was perfectly fine, is this illegal again? kvmalloc has never really supported GFP_ATOMIC semantic. > I can revert 93f976b5190df32793908d49165f78e67fcb66cf instead > but that change is from 2018. Yeah I would just revert this one as it relies on internal details of kvmalloc doing or not doing a fallback. -- Michal Hocko SUSE Labs