From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id A5BABC61DA4 for ; Wed, 15 Mar 2023 16:12:31 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 3B2CE6B0071; Wed, 15 Mar 2023 12:12:31 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 363336B0072; Wed, 15 Mar 2023 12:12:31 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 229C46B0075; Wed, 15 Mar 2023 12:12:31 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 121B96B0071 for ; Wed, 15 Mar 2023 12:12:31 -0400 (EDT) Received: from smtpin18.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id DF1E1AB83E for ; Wed, 15 Mar 2023 16:12:30 +0000 (UTC) X-FDA: 80571625260.18.1260F97 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf20.hostedemail.com (Postfix) with ESMTP id AE9341C0016 for ; Wed, 15 Mar 2023 16:12:27 +0000 (UTC) Authentication-Results: imf20.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=keEczDye; spf=none (imf20.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1678896747; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=cCW7axuUfgTUO6O263OSKMwVHUkLkmelwIVXmpc1WJQ=; b=t0gB4o+KHzkTf8ycJMgj0DlkW2JvlNneE1REVtjTbFXc6pmfcTGJiCytNeqEIhyQuc+N0e VUVbSMMyFHG84XXRRRymV7HxWIrribhRPLH24Lztj7MUqVpGH/q69UIDxyakzFHSNC2JuF lHkiygEf58tunLEhBOp2z8LdvcZQewY= ARC-Authentication-Results: i=1; imf20.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=keEczDye; spf=none (imf20.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1678896747; a=rsa-sha256; cv=none; b=PR7hOjFQozU/9ebYvsIgF63SKIcORLwQMiCzQsQZcn0L8GqBuuDrfodwP8BpmY443PQMrm VgAEuDkF1BNtI5jz/LoorEuXCa2mDXqoL9WbnZTQ31kMPm9FVZJZuML0ubp18Y8W94qZtP DxeA+xEQa9thBBwLUA565+QRCSALJIg= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=cCW7axuUfgTUO6O263OSKMwVHUkLkmelwIVXmpc1WJQ=; b=keEczDyeAJz4CTyMgdmjHNLJji tlZVcxG3jY9teZ1rL+FUsyT7ix2zDn23oalr1sEmolShALWOIS3jMo9bzv1d1PE0JNv/r+vF3PdCb otX4eDzoawS8lsC7rMipIc532u55ey7MLVjK9bUCTrgaTS8H9KxkvxbHGqZPoqGZ7kmj2NTlED8lW pSILl7cUhzdL4ANpx1LLPFYTpxcQrawP9FvgP0utshVAzl9AbAYJK1aEDlYvVjAhdW01Ip6FFez7Q lbWZHz55SzIU2dyVkelEWJVmYlX5JR4Cub+sEk95ideeAkpf9uxb1wEUuHEqVZbXU8rygUf90IKva JEQagxlw==; Received: from willy by casper.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1pcTjf-00DyaW-BQ; Wed, 15 Mar 2023 16:12:19 +0000 Date: Wed, 15 Mar 2023 16:12:19 +0000 From: Matthew Wilcox To: Peter Zijlstra Cc: Mike Rapoport , linux-arch@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , x86@kernel.org, "H. Peter Anvin" Subject: Re: [PATCH v4 27/36] x86: Implement the new page table range API Message-ID: References: <20230315051444.3229621-1-willy@infradead.org> <20230315051444.3229621-28-willy@infradead.org> <20230315103436.GA2006103@hirez.programming.kicks-ass.net> <20230315111941.GC2006103@hirez.programming.kicks-ass.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230315111941.GC2006103@hirez.programming.kicks-ass.net> X-Rspam-User: X-Rspamd-Server: rspam03 X-Stat-Signature: 91ncequ6oe1yuosjce9jeuz61zwa4p54 X-Rspamd-Queue-Id: AE9341C0016 X-HE-Tag: 1678896747-481737 X-HE-Meta: U2FsdGVkX1+P7/bWG1Xn7y2buRAoGZEPRuvPpF6ZkiCJKiNQvgXgLwPXzmh4Iuyh1FbYaaR27WvmkDVOarNNysQd6ksmD5lvb9ekGHw0lYZxKXopu0IUi2i5knnizn8BAAURQmrhqeYzioB/vBlw0FZKCe0CXP04OGK4lXX/4dkKTlhs8kE0/h7tGJndT/wQz/Dd1+loDuo5HqbdeGZ2LtOOdMNAYqTgVH8USzg2MyiSc9S8Aa0k1CxVbIMBIRWKKuQZSY/++Cga7WbNnnWuMhynHCuJ2c3otUDYBlLjsoIw//dRjdhTPiB88u9Ac12yCmLFekINce8jP28XsGZrk3RUOvOwAvloO06LCntmxvm51Ctx7aF+nHurfK9JIKCF+oUAFjJYNDLweOU3gnZXFOLc0LtvraO33xDrl8VBwXDuiU+/pfvOLGeygUVKWYRoBjR/teWCywn3AOdBsj/Ye1zmezlVU0sFKBT5/vttLZz7SZMlL70BIl58l8cXX7WsjiptXfNMcOoC2nZ/THVnAMideeBljIJb9+b/vOof/oTsrs41yH4vYmFUk4ExzEaatoVjFmqBRglBWaiPZPq39AgNXM+XtWuzMQKB3p8vQH9LhaNmwZhPDIC5Rpm8C5jP+a+2DkxGoCYo9qZauL+SY0YUP7eCVURf1Olc8naHUnQpvObPeey32dZINuIeaf9KGH1Vi6wrGby9PEd3i85tUNhG+drshgbWnyFUUKamxbUURaOGKqfFb7xUW7NUkbMxbY0huZOR9MGeFGeAfilcOJCv/7GCltvX6ZHaJaUEV4IHTmyPBBNTiiC17GOySwyscUgkyOi6YXL4HWsv9bIr56sbElmRMAQvhfBsCb4Sw7b2PRqgsDdNU/0gBOOXqv0+9o1t0JQFQCoY3P1BeK7d9X3g7tMdU/kNSXEO99p54hvYez3+tZPzWVzEhOsB0GCirgPQr7iDcWOLMCvQ4tI vOyg2nKc tMhLZ7vQGZfUJOoVWq27JEsIZM6F+rIzX/jNvl77c5kRJ8ILoj0FJJZm4q2HRgNag9jW10/k1doC9p7FMh3sVAEVAQbCKDu2q8nXKOTBBTvMq+NdwOkscXQT3L3kDp9uz7y6Ew/s6lWwiWCQqKXFH7H7AdCYkHNbGfD1hLz8wJ3g2O6xliY9bXsdBiAVPJPuF6EEjyx0w3cN45uL4SjHmYx1vFXlkqAm32y9/tn1y0XUTLLMg2/+zMTn9JTjcWotCDj9KBFv/Swr2HbxvTitoUxS5+9swGAr5aGATXznoLk/RKfMlGhLqvK9mWYbrWhZwY3lNVrGkKrv7UAO9Clpq/B0jZ27lUfck8rw9UuoJyRFVnsUo2OvI07Qr3cUMJLmSDfxq X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Mar 15, 2023 at 12:19:41PM +0100, Peter Zijlstra wrote: > On Wed, Mar 15, 2023 at 01:16:24PM +0200, Mike Rapoport wrote: > > On Wed, Mar 15, 2023 at 11:34:36AM +0100, Peter Zijlstra wrote: > > > On Wed, Mar 15, 2023 at 05:14:35AM +0000, Matthew Wilcox (Oracle) wrote: > > > > Add PFN_PTE_SHIFT and a noop update_mmu_cache_range(). > > > > > > > > Signed-off-by: Matthew Wilcox (Oracle) > > > > Cc: Thomas Gleixner > > > > Cc: Ingo Molnar > > > > Cc: Borislav Petkov > > > > Cc: Dave Hansen > > > > Cc: x86@kernel.org > > > > Cc: "H. Peter Anvin" > > > > --- > > > > arch/x86/include/asm/pgtable.h | 13 ++++++------- > > > > 1 file changed, 6 insertions(+), 7 deletions(-) > > > > > > > > diff --git a/arch/x86/include/asm/pgtable.h b/arch/x86/include/asm/pgtable.h > > > > index 1031025730d0..b237878061c4 100644 > > > > --- a/arch/x86/include/asm/pgtable.h > > > > +++ b/arch/x86/include/asm/pgtable.h > > > > @@ -184,6 +184,8 @@ static inline int pte_special(pte_t pte) > > > > > > > > static inline u64 protnone_mask(u64 val); > > > > > > > > +#define PFN_PTE_SHIFT PAGE_SHIFT > > > > + > > > > static inline unsigned long pte_pfn(pte_t pte) > > > > { > > > > phys_addr_t pfn = pte_val(pte); > > > > @@ -1019,13 +1021,6 @@ static inline pud_t native_local_pudp_get_and_clear(pud_t *pudp) > > > > return res; > > > > } > > > > > > > > -static inline void set_pte_at(struct mm_struct *mm, unsigned long addr, > > > > - pte_t *ptep, pte_t pte) > > > > -{ > > > > - page_table_check_ptes_set(mm, addr, ptep, pte, 1); > > > > - set_pte(ptep, pte); > > > > -} > > > > - > > > > > > And remove set_pte_at() apparently.. whut?!? > > > > It's now in include/linux/pgtable.h > > All I have is this one patch -- and the changelog doesn't mention this. > HTF am I supposed to know that? You should be subscribed to linux-arch. I literally can't cc all arch maintainers on every patch; many of the mailing lists will reject the emails based on "too many recipients". That's what linux-arch is _for_.