From: Matthew Wilcox <willy@infradead.org>
To: Lorenzo Stoakes <lstoakes@gmail.com>
Cc: Mike Rapoport <rppt@kernel.org>,
Andrew Morton <akpm@linux-foundation.org>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mm: move get_page_from_free_area() to mm/page_alloc.c
Date: Sun, 19 Mar 2023 20:22:14 +0000 [thread overview]
Message-ID: <ZBdu9oOyWP+NdO4P@casper.infradead.org> (raw)
In-Reply-To: <0020b728-724d-4206-8768-ec94d5628b34@lucifer.local>
On Sun, Mar 19, 2023 at 12:07:43PM +0000, Lorenzo Stoakes wrote:
> On Sun, Mar 19, 2023 at 01:42:14PM +0200, Mike Rapoport wrote:
> > From: "Mike Rapoport (IBM)" <rppt@kernel.org>
> >
> > The get_page_from_free_area() helper is only used in mm/page_alloc.c so
> > move it there to reduce noise in include/linux/mmzone.h
Reviewed-by: Matthew Wilcox (Oracle) <willy@infradead.org>
> Good catch, I wonder if there are more functions like this that can be dropped
> from headers?
I don't think anything outside mm/ has any reason to see 'struct
free_area'. Unfortunately, it's a field in struct zone, so moving
it out of mmzone.h will be hard (unless we can move struct zone out of
mmzone.h?)
free_area_empty() can move to mm/internal.h though
next prev parent reply other threads:[~2023-03-19 20:22 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-19 11:42 [PATCH] mm: move get_page_from_free_area() to mm/page_alloc.c Mike Rapoport
2023-03-19 12:07 ` Lorenzo Stoakes
2023-03-19 20:22 ` Matthew Wilcox [this message]
2023-03-19 20:52 ` Mike Rapoport
2023-03-19 14:16 ` Kirill A. Shutemov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZBdu9oOyWP+NdO4P@casper.infradead.org \
--to=willy@infradead.org \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=lstoakes@gmail.com \
--cc=rppt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).