From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id CDD3BC6FD1D for ; Mon, 20 Mar 2023 14:44:05 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 4451D6B0074; Mon, 20 Mar 2023 10:44:05 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 3F5586B0078; Mon, 20 Mar 2023 10:44:05 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 297116B007B; Mon, 20 Mar 2023 10:44:05 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 1CACA6B0074 for ; Mon, 20 Mar 2023 10:44:05 -0400 (EDT) Received: from smtpin18.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 91BC940E0C for ; Mon, 20 Mar 2023 14:44:04 +0000 (UTC) X-FDA: 80589546408.18.8BE4FB8 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf17.hostedemail.com (Postfix) with ESMTP id A3D7B4001F for ; Mon, 20 Mar 2023 14:44:01 +0000 (UTC) Authentication-Results: imf17.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=IGD2j+Pg; spf=pass (imf17.hostedemail.com: domain of peterx@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=peterx@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1679323441; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=MkxAqySEXMl0R33PqRVjUbl51OSwhSQixWd8OI14xk4=; b=CAsQsJrTDp++wJXOf/BQcnYU2qWpTrjWZJ4QT2E3FdIhz82hAyu05mgyHBt7feHPy+bVBq LrH1KDIhfNcIsTnOEME/Zwedob2/Hp4cy1T+F63Caf91rFJ89CQExkcZdpSx5aXyLxE64s DSVnmvsHrC+5wokHUnnYW6wiW1be2Ok= ARC-Authentication-Results: i=1; imf17.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=IGD2j+Pg; spf=pass (imf17.hostedemail.com: domain of peterx@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=peterx@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1679323441; a=rsa-sha256; cv=none; b=jKOi3GYJjusQj67uuJNuwPsbxztRHzG5ZirecuupH/cFSr2jMcV/ORIUEpdFQEoC42ZOtv SZneRwShLe1fWK6PnXETaAEVi92wya+gjSU3oMs/XLahzYiwPO8smkGiXWWZWLXDl1xSu6 skZBfG37sT93VZ/natGnOOGHz+MtE84= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1679323441; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=MkxAqySEXMl0R33PqRVjUbl51OSwhSQixWd8OI14xk4=; b=IGD2j+PgHuXYRynnM2NkzkVyo8/L5j/SWC972HOOVDmIYhgcFvmzzDY4A83j9hLviGxeIN TgM75TSCNCL7XM26LS8+xTbl1GXFLRaFC1+D7+3MjsBM0hF8QcX42ZXUYTnA4YjoBxNEBl iB96oHJf5ScDYF5/GuaqevxYKagiu3s= Received: from mail-qt1-f198.google.com (mail-qt1-f198.google.com [209.85.160.198]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-531-8iGWoUlDOneZgt9QOoVKPQ-1; Mon, 20 Mar 2023 10:43:58 -0400 X-MC-Unique: 8iGWoUlDOneZgt9QOoVKPQ-1 Received: by mail-qt1-f198.google.com with SMTP id l17-20020ac84cd1000000b003bfbae42753so6949127qtv.12 for ; Mon, 20 Mar 2023 07:43:58 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1679323438; x=1681915438; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=MkxAqySEXMl0R33PqRVjUbl51OSwhSQixWd8OI14xk4=; b=ymJSJkW+mz7Zf82nBvFh/UFNWFN10fvx9vYh1EnH6f/0lApRUDLrm/BOh0yCgnQuox Qc1tGFoZNgqb9VAnHne3acLbKzcSU+szLmfrhKgV03lD/MTvi4YPT2drIB7F/HRCGjSF QkETBudmS4XhglRUiYphHrS8nj4Dnet7YHkU+KEaT9tdLN28/dB4sRGs2kEZX4QSabgB cRYnYnpqlo3EPQ3WtGPcy46RvtLkqw+dwXP1EtZuPApWOmPPh/wv+I4FkXn4jtxvXebr UmR8gF7mXhLcSDW/ub++5AjNbADEUWFsBXcPKCK7dOlCtP/4C/ANwh0bsAnXPI5tYcsG tnkg== X-Gm-Message-State: AO0yUKUAb/oiKhl8LcJ9+7vzUVO9vsvLU+LP2FahsgOODp8zvTBQq3Ki QDdb9edt/Dot4x/lySlAmvwJERI3y4l8wYHbnx0v1PHZpCFnpAOwpjwguCp23rvyarrqWxDTtdT mYZ2v7mxBde4= X-Received: by 2002:a05:6214:224f:b0:5ab:af50:eb45 with SMTP id c15-20020a056214224f00b005abaf50eb45mr33845739qvc.3.1679323438487; Mon, 20 Mar 2023 07:43:58 -0700 (PDT) X-Google-Smtp-Source: AK7set94Mxdb5LXI5fakGqoQUEz6o2Jw3M+bhIYPR7UKsBQKN5OuQZCRLIwwCui0WSKxTLGej/NOBg== X-Received: by 2002:a05:6214:224f:b0:5ab:af50:eb45 with SMTP id c15-20020a056214224f00b005abaf50eb45mr33845711qvc.3.1679323438265; Mon, 20 Mar 2023 07:43:58 -0700 (PDT) Received: from x1n (bras-base-aurron9127w-grc-56-70-30-145-63.dsl.bell.ca. [70.30.145.63]) by smtp.gmail.com with ESMTPSA id g2-20020a37b602000000b0071aacb2c76asm7262870qkf.132.2023.03.20.07.43.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 20 Mar 2023 07:43:57 -0700 (PDT) Date: Mon, 20 Mar 2023 10:43:56 -0400 From: Peter Xu To: David Hildenbrand Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, Nadav Amit , Axel Rasmussen , Paul Gofman , Muhammad Usama Anjum , Mike Rapoport , Andrea Arcangeli , Andrew Morton Subject: Re: [PATCH v4 2/2] selftests/mm: Smoke test UFFD_FEATURE_WP_UNPOPULATED Message-ID: References: <20230309223711.823547-1-peterx@redhat.com> <20230309223711.823547-3-peterx@redhat.com> <4ab36009-51c0-6583-4948-b267f8fbf32a@redhat.com> MIME-Version: 1.0 In-Reply-To: <4ab36009-51c0-6583-4948-b267f8fbf32a@redhat.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Disposition: inline X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: A3D7B4001F X-Rspam-User: X-Stat-Signature: 8t53aguiaccrjztaznf9ruqx44mwxi4b X-HE-Tag: 1679323441-946951 X-HE-Meta: U2FsdGVkX1//QJyp0Dxt098sfYGMv01lVMiqnxxG6k6u2KXWfh+fhSfBsbSF5nydXj72Pk4HSunMjDzDHdlRFTEVNR4udT6vXsATbN8aNh6DS6EmEJXt5u+/uAozxbH6K8mNnwVNZKYOt0P4SbjeWhRSun06/QUUBUf4sonUpQ5C1ciiy0VFAiCSvDdnPzCIIhTf+x3BIuTCsCv8bzKzW9/r0tMPaoNIwkCdgtkhA7T0bcNsd0nLeyIOEhMpI1U/6TThvPKV03TQPf46T3eNvPRZEMRL8JHrmBZtR2Y95pUMn1XZZjEghVItrmZej490kNv6KxgMuOMOKNgeD2TN5YUVnPh5eCo7NV7jRjHK7JrayaWsISGGBuvNHiJoi5lOCivmZCnVwiHw/MgJa7+x/376qgBDSpdpKWXMEtgYDepI3UUVkzUI3fo8GC0l96b4PgCXGtYfnp4oaw+LhI/IhPHW21NnJvW5WYQv0n57gtNV907+M+r84bzN8fW+pNoNJvOsScRsMZQ1euXkPvoIFdZieFLXNAGF9Xs4BFcOxX8EqLqP4/UOMmcKHj4YokEDgdkAmB7TdcmQD0StS5zCctXg9/ntFoHZk+Djz8Ys9NrFtxY8/iXf8bjXoCIHvmEAy/VGbq0fqxFcmhUvBsmZOmITJ2FIjKfR94aO42fkrGsoUIfvxpFMKPvUdVO7QGBzja68tNQrtgUepAPqVst3PXfOCucYrrIq8FrSTRXBXzPO+Fwg9nEmct1P7Jjwa1O9lm268oKiZJH5gw8k72hhZ+8P0/ATl4tx2H+wO+ip6uqW9El57R8sk9Opm1RQRPNjSB2Gj3HRbEcGQGSaHG3w4MRpaVysYc3yFD0J0+eVSPKqlCrBB2MGQ0hThijlEZU4SBf6ecVRY5DYIHTGygDsc1+rcOfQeA7aRPFAO7gyOaUQfO9oQW9744wcT2RpGYYjt0p3NM1QPOjpGj1eknb mTC8ZU0y eFmKoPA2PtBN2elvhSPMHqoeyhpjFjIwJmevn33iBHUwxpIrWZrYL58E5wC5XGhXIEFAeYbnLo6rm64HIVwFVQpVoGHSSotX61D2XfxJ0bQXIJG6PvjAiH8p6VrkbqjFluq1v0cd059b6WqLK/bH9037qkg4npCjCX1tohf4Xf7tDKlXJgbLPjg0ZLDeSXLpasPtcM/hGuJYMgSq3YmksHQNcIrDAaJne+SNBIbFEYlY1mlkDe8qLQzxwwh2zaeH++l3IKOlllUvyXv/S+dhrGjWsK2HnfNI0RhXVcBkm5YDt4EjlUzIQ7O64lqCQEgZKDVJfLHjCaZcDP/ulOtSrReDJAr3L1IgplmICGVC/Oa1vKS+PKqtWTIaHif9OlLJx7/28aS7s7L2TNHKinrVIhkZAT/B86xOW7VzEKZY2tQQrbh7+E+GhC9f8szlIDwtJRQw+BYHy4Ms8wIeXdCsF90GqxKEjo1bRptli88Fu7BpJa9a75T7qmqYE3g== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Mar 20, 2023 at 11:25:43AM +0100, David Hildenbrand wrote: > On 09.03.23 23:37, Peter Xu wrote: > > Enable it by default on the stress test, and add some smoke tests for the > > pte markers on anonymous. > > Would it make sense to make kernel support optional and test both paths -- > once with the feature enabled (if available on the kernel we're testing) and > once with the feature disabled? Yeah, I think the current uffd selftest is not friendly to old kernels so I made it simple - IOW the test should fail already on old kernels AFAIK. Maybe I can prepare some patches this week or next to cleanup some parts of it. Thanks, -- Peter Xu