From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id AA55FC6FD20 for ; Tue, 21 Mar 2023 19:25:36 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id E7474900002; Tue, 21 Mar 2023 15:25:35 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id E243E6B007D; Tue, 21 Mar 2023 15:25:35 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id CEB6A900002; Tue, 21 Mar 2023 15:25:35 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id BF3856B007B for ; Tue, 21 Mar 2023 15:25:35 -0400 (EDT) Received: from smtpin15.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 8E36D1C253C for ; Tue, 21 Mar 2023 19:25:35 +0000 (UTC) X-FDA: 80593884630.15.4186BB0 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf14.hostedemail.com (Postfix) with ESMTP id 7C133100016 for ; Tue, 21 Mar 2023 19:25:33 +0000 (UTC) Authentication-Results: imf14.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=Qzn5PZNo; spf=pass (imf14.hostedemail.com: domain of peterx@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=peterx@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1679426733; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=85m7idf7+4iCJskalXeMQ1A6vtydsiefpfGzk6u9aGk=; b=IfgFX/+WEAX4B2LDTaf3HgIZ8MGNrDg5xxepMgzD4A2TEiUNFq6DPVmF0kbOeEH1S6Nir4 etVpwVGf+d4ZzkD8c5Nl4F/hDAg+9XYPZUWGuOVqHTaHxJJ2vUwJw5bPV4bltuwp072sHX ijRO1BIa0trT/zurTHb/tjBn+aLBalw= ARC-Authentication-Results: i=1; imf14.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=Qzn5PZNo; spf=pass (imf14.hostedemail.com: domain of peterx@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=peterx@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1679426733; a=rsa-sha256; cv=none; b=BpQPUaXTcTRgRPDEvW/o84Ht5BYBYM1Pozget2+70b+kwZP4juAYW3ErMpLAxBfoIdeyPo ycsKIXEoP9APFCpYQt7q5NTKab7L+zOZlo4aKs+BhNh8qxYRPMVSXo049v0l3sgYU3C63I 6bdo9lG2mjxSAsqnz2Aop08lANY0x2c= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1679426732; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=85m7idf7+4iCJskalXeMQ1A6vtydsiefpfGzk6u9aGk=; b=Qzn5PZNoueTewL7xK2MeNnlLYmVNNYldV/kBklk2HCRYn8dY/g9vbBOGWWdSZ3rPQSFe5Z fr/5YN1wM3zQY2M0KNPaWmEs34pjDKd6aEuepAhw+a9CcvXmuj8Rg+Jkrgu4uFj7aOpHHa RZpTOpDQy7PwHnKVdMvjbyy1MX2aOZI= Received: from mail-qt1-f197.google.com (mail-qt1-f197.google.com [209.85.160.197]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-626-jhRG8_maMNeR2p0oyvi6ZA-1; Tue, 21 Mar 2023 15:25:29 -0400 X-MC-Unique: jhRG8_maMNeR2p0oyvi6ZA-1 Received: by mail-qt1-f197.google.com with SMTP id t22-20020ac86a16000000b003bd1c0f74cfso9428071qtr.20 for ; Tue, 21 Mar 2023 12:25:29 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1679426729; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=85m7idf7+4iCJskalXeMQ1A6vtydsiefpfGzk6u9aGk=; b=3CzlQhUrHQ6nwOxmqQ29luzfd3yLZKlxzLT32Q+N/5kA5+Vs0805gVvSf/H7UiWL1f frKaHFilW3Veenrhv3XoS53+PWIwKgcFk+L0Fy78yG7nvNAcZc6urclIKHMgzzqlPzXd IhS4NMrYAiF6/WH1AePCJLfdrckskDcYVrrbv8GogCht6lKw+jpYJTJ+pWIZ99uGPpWC OMAjr2KeBPa/9Ug7wk1UgX2qNGND28YLfYqZQ/8obxQbZ0yvByXk7qKznOz6v4Zj/MyA YrZqst0Ic8jGuSPBwhzhZJP30NuivYCcOBKuVDMCMM7Q9pY3Xv18kKxiJhMSw5pg+Ej+ aWXw== X-Gm-Message-State: AO0yUKVxNVaRrVUxHfR+ZaQdAAXF+x6O+VhTOLMVNzg2Y8TsThXiGYVa l8txhlgnnlyqyJzflVyrCphyQGdO6gcMyM/6Q4fgM9cLn0qdUFUODDxEo7cnKrM/IuVdeoJi8bQ FCoFlZW7AXvw= X-Received: by 2002:a05:622a:1ba6:b0:3c0:40c3:b8fd with SMTP id bp38-20020a05622a1ba600b003c040c3b8fdmr6057130qtb.6.1679426729257; Tue, 21 Mar 2023 12:25:29 -0700 (PDT) X-Google-Smtp-Source: AK7set+9iqNdU6v9wQzdMs3AczgBSXHN3PRvEEclpNBfmVrHlftA95NuuUy9gB8wfKiTRndykR9lzQ== X-Received: by 2002:a05:622a:1ba6:b0:3c0:40c3:b8fd with SMTP id bp38-20020a05622a1ba600b003c040c3b8fdmr6057082qtb.6.1679426728928; Tue, 21 Mar 2023 12:25:28 -0700 (PDT) Received: from x1n (bras-base-aurron9127w-grc-40-70-52-229-124.dsl.bell.ca. [70.52.229.124]) by smtp.gmail.com with ESMTPSA id 77-20020a370650000000b007458c5a807csm9774944qkg.83.2023.03.21.12.25.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 21 Mar 2023 12:25:28 -0700 (PDT) Date: Tue, 21 Mar 2023 15:25:26 -0400 From: Peter Xu To: Muhammad Usama Anjum Cc: David Hildenbrand , Andrew Morton , =?utf-8?B?TWljaGHFgiBNaXJvc8WCYXc=?= , Andrei Vagin , Danylo Mocherniuk , Paul Gofman , Cyrill Gorcunov , Mike Rapoport , Nadav Amit , Alexander Viro , Shuah Khan , Christian Brauner , Yang Shi , Vlastimil Babka , "Liam R . Howlett" , Yun Zhou , Suren Baghdasaryan , Alex Sierra , Matthew Wilcox , Pasha Tatashin , Axel Rasmussen , "Gustavo A . R . Silva" , Dan Williams , linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-kselftest@vger.kernel.org, Greg KH , kernel@collabora.com Subject: Re: [PATCH v11 1/7] userfaultfd: Add UFFD WP Async support Message-ID: References: <20230309135718.1490461-1-usama.anjum@collabora.com> <20230309135718.1490461-2-usama.anjum@collabora.com> <1b78ee32-003d-5645-c223-619b66d41733@collabora.com> MIME-Version: 1.0 In-Reply-To: <1b78ee32-003d-5645-c223-619b66d41733@collabora.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Disposition: inline X-Rspam-User: X-Rspamd-Server: rspam03 X-Stat-Signature: i47hge6s6oqtreymqfrxjfiq5turfzib X-Rspamd-Queue-Id: 7C133100016 X-HE-Tag: 1679426733-673884 X-HE-Meta: U2FsdGVkX18/2GwdVGb+aETQ3a9qugZsiPp8eMXOLG7odOCtnI/1bjynEPqm3W+x0QkoXB43TG6/ptUKv7CCmasOP8MFD6cHDcgD3UIW8hl3inV/LHWB7fTxRqgWApGac4Pb+X06pERjbd04DEmns3Q+tIinPYGTSEwyivTzM/iEcYcJKzD3PE1gcMITIs5vKRsOOCAyaJouU9j1RrqkLH4TwnGUGKlsr5LtoyWu7TliFvROU87ZnOaYCG+PBpliL9deIKwMqrzpPtB4MQsFHes6HCzSOpLQaYg0h28qmYbk09uCgHNJzzx09fVwWpj+8F55nHBoSqlkxnmX3/XSVDeFjzjUORMHF3XMzqpqo5EZip2ezo8WLkhYt+Fki1qYldtWbIb/gqJ39CWV8ZWNngycfFzvBJn/0Uy3QVCwyckc0cokwT9ga6qxTiA7LEsadMDhJEaRLxa1QIXiecdSUZ88l7oW92Yq9slGcSlKVoBVngNHC5qxfvTw+Om52AQlrmqQmRJL2spdEL0PfkJbnaSwEna17bPdB8EPjEr1NHQoLksHivZtqq/IoLg3diuW5NA03pL5fgcumhaf4OnQNpNqG0cxY7J5FhpDHLYCt3Y4bDKdmoHzWecSjv77sHQbzDemmDwhn2EZTh0hHNxJgvdjRcZq3YxDbKms9lyMVDnfQ+VDGk6fLZfUbiV6KNmpcEEDvTjNTtbRI07dE2AG4MfjrWkhECX/oJPFFo1eK3fQ+dqj7glZuVdIHNBoZDD/eiDr0BaIQUq/WGuXveLNi1VatXnRD94NXxxtgAlWA9SZL+PaWT4niOsiLG33OCCrIbYeZ0/68xrOQk/kGzb5TF/kz4MTDWtmLgJUKzIJrNwi0ft3r5NqUn2fn2leu9n+2yWszCimB/Wr8lMYNJO/YBi02JQDfY/anaKGisq+qA7Q5aipcIuMF4FJJu2uc+eFnqlvj9Win6FlayeYSVe 6aEX3ITv zH17UarlQKuyehcrOpJHdt3I9lq7GMDnDNJv2HGqrdsYLNSvA5kn0NlGbFcghnMny6qWHv0e6aAA2p8VcRPVGJtlLqUf684o4TX88UjAKdS+dbKjGwn1tv0qMv8wcEcguzh9asC/XJN3XWj15l4URxreJstaH8bVRMyFXoD3rbR3eKqK/fLnCH0NYCPhC09eIVSg5D2WeZIGVBvcc7NNABT7vpPyyc14hNNCv9Uqy8A3Mw5SM+5oW428ghbFw3dd91g5GwgN6oc1ho0yEBse95To4AOMH6lVl+T7dv+PUdBJ7D2la/jWQpZsw6H+mGJrUR8UIsifC09KGUPOCZf92C8yw40w7axDv7XONy+KtlE6YPsjY2kZRGj+QDa15+LrfLPC2pSGUr/RwgCH3BR2vHm0w/8gnHb+mMGsAMsW8axM8iGJHbauETfL0IItIk15ELjHYr8zGuJpnv8gy7vYD9OYhk/5cJzhb/RTlWFi/jeuhJModGuJ+Mgits9AccGa8kAsR X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Hi, Muhammad, On Tue, Mar 21, 2023 at 05:21:15PM +0500, Muhammad Usama Anjum wrote: > Thank you so much for the patch. I've tested hugetlb mem. This patch is > working fine for hugetlb shmem: > *shmid = shmget(2, size, SHM_HUGETLB | IPC_CREAT | SHM_R | SHM_W); > mem = shmat(*shmid, 0, 0); > > I've found slight issue with hugetlb mem which has been mmaped: > mem = mmap(NULL, size, PROT_READ | PROT_WRITE, > MAP_ANONYMOUS | MAP_HUGETLB | MAP_PRIVATE, -1, 0); > The issue is that even after witting to this memory, the wp flag is still > present there and memory doesn't appear to be dirty when it should have > been dirty. The temporary fix is to write to memory and write protect the > memory one extra time. I looked into this today and found it's an existing bug that can trigger with sync mode too.. as long as protection applied to unpopulated hugetlb private mappings, then write to it. I've sent a fix for it here and have you copied: https://lore.kernel.org/linux-mm/20230321191840.1897940-1-peterx@redhat.com/T/#u Please have a look and see whether it also fixes your issue. PS: recently I added a warning in commit c2da319c2e2789 and that can indeed capture this one when verifying using pagemap. I'd guess your dmesg should also contain something dumped. Thanks, -- Peter Xu