From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9297DC7EE32 for ; Thu, 25 May 2023 04:06:26 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 214236B0075; Thu, 25 May 2023 00:06:26 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 1C4386B0078; Thu, 25 May 2023 00:06:26 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 0B365900003; Thu, 25 May 2023 00:06:26 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id EC1096B0075 for ; Thu, 25 May 2023 00:06:25 -0400 (EDT) Received: from smtpin28.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id AF9AF40AC6 for ; Thu, 25 May 2023 04:06:25 +0000 (UTC) X-FDA: 80827440330.28.B35ABC8 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf27.hostedemail.com (Postfix) with ESMTP id 0DBDB4000C for ; Thu, 25 May 2023 04:06:23 +0000 (UTC) Authentication-Results: imf27.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=l6Ua4MgY; dmarc=none; spf=none (imf27.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1684987584; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=6udzwAg9K4Zo17ilvfnqobn9xHwMSG5Rs7tEzcXAEiI=; b=uBLM9EmfSKxAU5WL9a+YZ7VqNMij8ONVhZ2HekFrvb2tSOwuVnPAnfRLftsb6KToihVS8H Utoj4cbABgbQXhNUrqRV/li6p76U06zdTlDm05VQOKC0ChriIvwm5IXnKyFvCTqsOf4RL+ 7qLiSUI38v8zeBl3+lbIy4RgySHMs8Q= ARC-Authentication-Results: i=1; imf27.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=l6Ua4MgY; dmarc=none; spf=none (imf27.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1684987584; a=rsa-sha256; cv=none; b=1GbGhj7cK5aFRCi3WoAqa+x1dxM7xVq+5go4hj8Wpo9Tsguzj8pSYCZoXfyBxCo9P8UiH1 szx1lU6HnBxDzgT4JoIjq8t4ZePGzFNerNUJgKuEEQ1ajDEs7bQnpyUfuyC1/lwSV6GWYy GNsAku3u3xisOVvkytKsv1PkZ9sMcJc= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=6udzwAg9K4Zo17ilvfnqobn9xHwMSG5Rs7tEzcXAEiI=; b=l6Ua4MgYnFd3mbz5UFnWznqeqa aagYos/M7qRPH6QcdREjzrKkxKTQZjwVtjFhnAviSoDuXIfKw8dLIoSH5beMQnn/PizLRHOnz0ntS +LXDUFKgQPfvWQSLMeuis0pQxYxGZ5/Zr+ALFMvK2So3uDcp2NqRQBNDX1u4toIi864UB+EqUmUD9 BiqHDiXQhI/ZdjDmmoU1IZRxSqkabm3+PEJ45yaI23M7eB3CXcgSnRv9joInATNwdE+8q2M5VXqJ/ iAatOmqEM6GCNzeGlLyc+Cazbq8chA5jsvRZm31M0UQn3EexEb4OlHt2fNHZW7oxWeab+SWZLaNKQ 6exQRc6A==; Received: from willy by casper.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1q22F2-00BpOP-FC; Thu, 25 May 2023 04:06:20 +0000 Date: Thu, 25 May 2023 05:06:20 +0100 From: Matthew Wilcox To: Anshuman Khandual Cc: linux-arch@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, Mike Rapoport Subject: Re: [PATCH v4 05/36] mm: Add default definition of set_ptes() Message-ID: References: <20230315051444.3229621-1-willy@infradead.org> <20230315051444.3229621-6-willy@infradead.org> <10c85f5c-3332-9130-c6f0-d36b9ea4b549@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <10c85f5c-3332-9130-c6f0-d36b9ea4b549@arm.com> X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: 0DBDB4000C X-Stat-Signature: 5akddrq4mctm9jxuwcj9dda695oi43ez X-Rspam-User: X-HE-Tag: 1684987583-983562 X-HE-Meta: U2FsdGVkX1+HMiEBdtKvxrt433d9nlrLDZB1fAevhaz7OtxFVxpw9SSCir40YsS4QXg4XLXJ+adXh1fh87NoaE5peQNAO6foLAbBjEjPUCid51kBsp9aRbJ+TIEEUF25Kku7qdHDlo4Gn+z1Qmkc6T2TVAnvcziFdKKcpfqDlBKMvBdNnOwQr7gstBuOh/X2XUexWK2Kl8D+67ton5WD28pjkM68RhxBFtaif6HU9u8vhhqhmMRM0Ft/ri/GMy2wYJuZiszFH6hV6m/D3RIYrvPbaylgLMCCitWWNV47Aw2yzi/DHCfJcc4r+APEX6Nt5XfVrStfXdHgopqHJcPFjsP6LKipN2uNLA5Ecp4vuJLFqdjhbIvoK0CkzYpRlYUo1pUuPhCZ9oefq1smnTr5oHqXW2Oy9zaZixHijD3xOcskeNvkkJJrfEATumiRLpkeTAbdMnhJKmFWKILco3Ix8BpicDkO9OMbLxRHe7KMmICMJRt0ijzw2t8ZhTiDLXnt8tvsqmNyN6gMme6o0Ogz+98M78cDWSfzCmjFK302V+5R0NtIsYdQY6/Ck1YBu/A8/YfDyLelJPA+k8QTwYLwMzNDXB3BEKpSK7d528eFyHvURgT+RSQglOHM1cXUq++3zJoaYdZf9o9QkO1EVGuu2MPuqBSl0SqKle7w7jm4y0solt9X6rzVxUDEgiMzqBHqERN1YVveHFxccZDztZXMGqKZMrz+YSgCuGVUOQWXJjFJ45ooRz/PMIivC0XUWL/o+n1E+rUCin3rt4ODdbmsMUu+x/o/GcuywEo3XPXLoD7oNZ5O/52GtznyS98UNlu01E7/wWPmGJ7+/kCy6KtCsNNnKdAYQeX4KdBk29SlUfIAe0WTBAR2cKHul5V8sgKSJIyCmBMaL0AraToXDJBshR3kmxB1O/Jm1itXzt/w6TZ8T4xtYA4FExJAC1xbnnLE3QrtDu0F12ifWyq6H9g lVdASgvC PkUSQ7yKTmNyuN/iq/+Z7WjNqcpBwyhurvRbLEeD3kyVmRBZe/qDtDzr2AEQb/2UJzWVJzsTUyVfhzZSsu11u/2G4CWwG7z/HNE88EVhXRQoSqhYRZfOAg3dmPiaOu1mT7nKSQufAEQBBDlqSPt3x+H1FoxLAwVe9ODFky9BjBklJ8Vt6qI55FwMMhQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, May 25, 2023 at 08:31:14AM +0530, Anshuman Khandual wrote: > > +#ifndef set_ptes > > +#ifdef PFN_PTE_SHIFT > > +/** > > + * set_ptes - Map consecutive pages to a contiguous range of addresses. > > + * @mm: Address space to map the pages into. > > + * @addr: Address to map the first page at. > > + * @ptep: Page table pointer for the first entry. > > + * @pte: Page table entry for the first page. > > + * @nr: Number of pages to map. > > + * > > + * May be overridden by the architecture, or the architecture can define > > + * set_pte() and PFN_PTE_SHIFT. > > + * > > + * Context: The caller holds the page table lock. The pages all belong > > + * to the same folio. The PTEs are all in the same PMD. > > + */ > > +static inline void set_ptes(struct mm_struct *mm, unsigned long addr, > > + pte_t *ptep, pte_t pte, unsigned int nr) > > +{ > > + page_table_check_ptes_set(mm, addr, ptep, pte, nr); > > + > > + for (;;) { > > + set_pte(ptep, pte); > > + if (--nr == 0) > > + break; > > + ptep++; > > + pte = __pte(pte_val(pte) + (1UL << PFN_PTE_SHIFT)); > > + } > > +} > > +#ifndef set_pte_at > > +#define set_pte_at(mm, addr, ptep, pte) set_ptes(mm, addr, ptep, pte, 1) > > +#endif > > Should not there be a build phase call out when both set_ptes() and PFN_PTE_SHIFT > are not defined on a given platform ? How does that help? Either way you get a clear build error.