From: Catalin Marinas <catalin.marinas@arm.com>
To: Yicong Yang <yangyicong@huawei.com>
Cc: akpm@linux-foundation.org, linux-mm@kvack.org,
linux-arm-kernel@lists.infradead.org, x86@kernel.org,
mark.rutland@arm.com, ryan.roberts@arm.com, will@kernel.org,
anshuman.khandual@arm.com, linux-doc@vger.kernel.org,
corbet@lwn.net, peterz@infradead.org, arnd@arndb.de,
punit.agrawal@bytedance.com, linux-kernel@vger.kernel.org,
darren@os.amperecomputing.com, yangyicong@hisilicon.com,
huzhanyuan@oppo.com, lipeifeng@oppo.com, zhangshiming@oppo.com,
guojian@oppo.com, realmz6@gmail.com, linux-mips@vger.kernel.org,
openrisc@lists.librecores.org, linuxppc-dev@lists.ozlabs.org,
linux-riscv@lists.infradead.org, linux-s390@vger.kernel.org,
Barry Song <21cnbao@gmail.com>,
wangkefeng.wang@huawei.com, xhao@linux.alibaba.com,
prime.zeng@hisilicon.com, Jonathan.Cameron@huawei.com,
Barry Song <v-songbaohua@oppo.com>, Nadav Amit <namit@vmware.com>,
Mel Gorman <mgorman@suse.de>
Subject: Re: [RESEND PATCH v9 2/2] arm64: support batched/deferred tlb shootdown during page reclamation/migration
Date: Thu, 29 Jun 2023 17:31:36 +0100 [thread overview]
Message-ID: <ZJ2x6DlmyA3kVh1n@arm.com> (raw)
In-Reply-To: <20230518065934.12877-3-yangyicong@huawei.com>
On Thu, May 18, 2023 at 02:59:34PM +0800, Yicong Yang wrote:
> From: Barry Song <v-songbaohua@oppo.com>
>
> on x86, batched and deferred tlb shootdown has lead to 90%
> performance increase on tlb shootdown. on arm64, HW can do
> tlb shootdown without software IPI. But sync tlbi is still
> quite expensive.
[...]
> .../features/vm/TLB/arch-support.txt | 2 +-
> arch/arm64/Kconfig | 1 +
> arch/arm64/include/asm/tlbbatch.h | 12 ++++
> arch/arm64/include/asm/tlbflush.h | 33 ++++++++-
> arch/arm64/mm/flush.c | 69 +++++++++++++++++++
> arch/x86/include/asm/tlbflush.h | 5 +-
> include/linux/mm_types_task.h | 4 +-
> mm/rmap.c | 12 ++--
First of all, this patch needs to be split in some preparatory patches
introducing/renaming functions with no functional change for x86. Once
done, you can add the arm64-only changes.
Now, on the implementation, I had some comments on v7 but we didn't get
to a conclusion and the thread eventually died:
https://lore.kernel.org/linux-mm/Y7cToj5mWd1ZbMyQ@arm.com/
I know I said a command line argument is better than Kconfig or some
random number of CPUs heuristics but it would be even better if we don't
bother with any, just make this always on. Barry had some comments
around mprotect() being racy and that's why we have
flush_tlb_batched_pending() but I don't think it's needed (or, for
arm64, it can be a DSB since this patch issues the TLBIs but without the
DVM Sync). So we need to clarify this (see Barry's last email on the
above thread) and before attempting new versions of this patchset. With
flush_tlb_batched_pending() removed (or DSB), I have a suspicion such
implementation would be faster on any SoC irrespective of the number of
CPUs.
--
Catalin
next prev parent reply other threads:[~2023-06-29 16:31 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-18 6:59 [RESEND PATCH v9 0/2] arm64: support batched/deferred tlb shootdown during page reclamation/migration Yicong Yang
2023-05-18 6:59 ` [RESEND PATCH v9 1/2] mm/tlbbatch: Introduce arch_tlbbatch_should_defer() Yicong Yang
2023-05-18 6:59 ` [RESEND PATCH v9 2/2] arm64: support batched/deferred tlb shootdown during page reclamation/migration Yicong Yang
2023-06-29 16:31 ` Catalin Marinas [this message]
2023-06-29 17:26 ` Catalin Marinas
2023-07-04 14:36 ` Yicong Yang
2023-07-05 8:43 ` Barry Song
2023-07-05 10:24 ` Yicong Yang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZJ2x6DlmyA3kVh1n@arm.com \
--to=catalin.marinas@arm.com \
--cc=21cnbao@gmail.com \
--cc=Jonathan.Cameron@huawei.com \
--cc=akpm@linux-foundation.org \
--cc=anshuman.khandual@arm.com \
--cc=arnd@arndb.de \
--cc=corbet@lwn.net \
--cc=darren@os.amperecomputing.com \
--cc=guojian@oppo.com \
--cc=huzhanyuan@oppo.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-riscv@lists.infradead.org \
--cc=linux-s390@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=lipeifeng@oppo.com \
--cc=mark.rutland@arm.com \
--cc=mgorman@suse.de \
--cc=namit@vmware.com \
--cc=openrisc@lists.librecores.org \
--cc=peterz@infradead.org \
--cc=prime.zeng@hisilicon.com \
--cc=punit.agrawal@bytedance.com \
--cc=realmz6@gmail.com \
--cc=ryan.roberts@arm.com \
--cc=v-songbaohua@oppo.com \
--cc=wangkefeng.wang@huawei.com \
--cc=will@kernel.org \
--cc=x86@kernel.org \
--cc=xhao@linux.alibaba.com \
--cc=yangyicong@hisilicon.com \
--cc=yangyicong@huawei.com \
--cc=zhangshiming@oppo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).