From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 19047CD98C6 for ; Tue, 10 Oct 2023 21:45:07 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id A34B98D00E5; Tue, 10 Oct 2023 17:45:06 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 9E3888D0002; Tue, 10 Oct 2023 17:45:06 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 8D3028D00E5; Tue, 10 Oct 2023 17:45:06 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 79C718D0002 for ; Tue, 10 Oct 2023 17:45:06 -0400 (EDT) Received: from smtpin16.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 48167B4C90 for ; Tue, 10 Oct 2023 21:45:06 +0000 (UTC) X-FDA: 81330882612.16.39038D7 Received: from mail-ed1-f49.google.com (mail-ed1-f49.google.com [209.85.208.49]) by imf16.hostedemail.com (Postfix) with ESMTP id 3A4C718001C for ; Tue, 10 Oct 2023 21:45:04 +0000 (UTC) Authentication-Results: imf16.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=jm00kD6H; spf=pass (imf16.hostedemail.com: domain of mingo.kernel.org@gmail.com designates 209.85.208.49 as permitted sender) smtp.mailfrom=mingo.kernel.org@gmail.com; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=kernel.org (policy=none) ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1696974304; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=RAWJva6tWSY0k+gPfLrvQkq9uvUdgcqwh9Gj/RrjVLc=; b=emREaRPSdEVZJRzlQepiH9+o+3l1OatbOzh2RDfyW5oksy2yKx9NA2qW1l0r1hL90mGG8i MECT9immjjwntTGBwMQlZrKErFlfcsS999hHsqZdLptwPgiC7f1CBvVkP4Ns0U2Nvn68s2 ENyADLMX4ZYDxoqYa+OB7D5DP0Fgvrs= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1696974304; a=rsa-sha256; cv=none; b=cGxkjWnMH/if/bHBczsEH/T33Vj0UuJNHTNf7t6JW8Noy3mgGRP1snAKFTuaHfoOctryB6 g4SBYqF5wEoP0nf2oLb5gzdo5V7dZrjHltYB5DmDern5dHAEO05WF7D+e/OZ5D3p0mnfVa sDNzY+clIP3PU4IF4tHq6MEK3rdezws= ARC-Authentication-Results: i=1; imf16.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=jm00kD6H; spf=pass (imf16.hostedemail.com: domain of mingo.kernel.org@gmail.com designates 209.85.208.49 as permitted sender) smtp.mailfrom=mingo.kernel.org@gmail.com; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=kernel.org (policy=none) Received: by mail-ed1-f49.google.com with SMTP id 4fb4d7f45d1cf-53d8320f0easo1773195a12.3 for ; Tue, 10 Oct 2023 14:45:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1696974303; x=1697579103; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:sender:from:to:cc:subject:date:message-id :reply-to; bh=RAWJva6tWSY0k+gPfLrvQkq9uvUdgcqwh9Gj/RrjVLc=; b=jm00kD6HCcYWEqAm4l/Pg2iLKGr5Wkt9pfcKLwvnQPauUSvHhXxcAFOZqoUn59WdvB AT6Tpls3MIY3/k9ny62whqBNPo/i77bTx1uEiaoDVcpHMfK/MzU5SKIHrep595AVW7Nn SQWnqHw0Lku73CP3WFNejKBXj/JUy8SR/6awEfksQuisfUmza9YH01Qr1VLMC60h7NE0 1K0Ql/fU+X19mVhMRv+ZmjT9qijPbldZfe12qzr/x8NUwNRPILhKob5zWMQaImpqpSeV b5HxrcJVnNagFOX85zGe+xCArbKSbZaaA0xYCR/9uAAagtF8Jj1Vu4U1eOXrUEDUSrHl YunA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1696974303; x=1697579103; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:sender:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=RAWJva6tWSY0k+gPfLrvQkq9uvUdgcqwh9Gj/RrjVLc=; b=edZVYoLrSlsMly9qoPAAVTZoWUm646Zu111ahH0YfX7OYoeTjbtYpY0lni/VWM4JDa 2UveSPSBuXn9+WQGBBMP1GVcDOf/RFgQX4gFaoZe7XY3Bs2o3TffFTHEJt7LokHZQwY2 GoV2jTBtMQELHFhcqWltwNy9NUlWSaaBjwB6cUc2/bB7be0TkeEQY1MqJtlBGtdeU6Xi ly2TkPrx8Byy6a/srHj7TaPu2QTx4m82lRjkcraz/iAR9IJd1TEPH2dCzKXxXeJBVLOd L7ZWDVo4pMUiNB0r0cORtmw/DKpXVz3+CtoLGiafgkcIzBVVPu8AGP8N81dA6GFGAJtq zouw== X-Gm-Message-State: AOJu0YzL3xtUAHw8Qh9bcvoWSroboZqyGlIeyzvJ7vHom6y1aovmIUlI VboG6VFfujK57ESlCfiWiB4= X-Google-Smtp-Source: AGHT+IGbMDNQ0zVsUjnpGSsTngnE24exVfG0GDRbi7Mwq4Facud21y7kuRRY0iirEUBaM/nmjdndyw== X-Received: by 2002:aa7:c74a:0:b0:525:7234:52b7 with SMTP id c10-20020aa7c74a000000b00525723452b7mr16719670eds.19.1696974302584; Tue, 10 Oct 2023 14:45:02 -0700 (PDT) Received: from gmail.com (1F2EF405.nat.pool.telekom.hu. [31.46.244.5]) by smtp.gmail.com with ESMTPSA id d15-20020a056402516f00b0051e1660a34esm8190759ede.51.2023.10.10.14.45.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 10 Oct 2023 14:45:02 -0700 (PDT) Date: Tue, 10 Oct 2023 23:45:00 +0200 From: Ingo Molnar To: Raghavendra K T Cc: Mel Gorman , Peter Zijlstra , K Prateek Nayak , Bharata B Rao , Ingo Molnar , LKML , Linux-MM Subject: Re: [PATCH 0/6] sched/numa: Complete scanning of partial and inactive VMAs Message-ID: References: <20231010083143.19593-1-mgorman@techsingularity.net> <793eaa1a-c836-3f0d-7443-b2165a9c6ab9@amd.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <793eaa1a-c836-3f0d-7443-b2165a9c6ab9@amd.com> X-Rspamd-Queue-Id: 3A4C718001C X-Rspam-User: X-Stat-Signature: n64kbeizupk4p3h8r36jb3zfnaci8hfj X-Rspamd-Server: rspam03 X-HE-Tag: 1696974304-883959 X-HE-Meta: U2FsdGVkX1+aeBFee3QgceRXOpcCr06aevhwoaXp2pfn6WgYde7s+Q3+Z/Vit2xF5T8DqdOSFiCnq8LaG8zcBTMpuRxcgU9pGLMAvstYK0w5cCrE3CsmTAdrkK3DcxAO44J/UcaVWZQ2Wz3VPYwVYjKeVqccxOXXIoUyQovGvjTvVzF3/HsS7B9lrTRI9BM3umCUVYmt8B5KXM0vHG9HP4jagjcpDb65D6atUQ72hzm8Mzt5RiIzsnkLkCR10nvCz3nnSkcNmPXYtFtZE1UzGgQR0QdFLIceVXL/9jGozB5wjDxNkGjNbpR/nZHgD1cW313BYrZwxZS9AvedftM67aXAlWLvHYO5ndptzxnFcyZMnrqp62G4/B3lgEJxqQJk35KdlSGoIWSIgHSWdKW6rJ5Q+GfzRb2WJ1GMvJ0I2DU77j0EVrF9Vpn3QWZ7lhmo3udIWpbjh7ZUtnFz/SmjdoLz430mg4AuNjfPoOg+o5lOy2MR+rFoB3NpCsz7Yk0Jw0EcZ2JSBsA+ibrM736jKhrbj6+CPUIIWFbCASrDViaNQ2B50wphzU/W9toJeLoPkEjQS2RHz7blUGcho+tbEBMTuRjArUL+c6St67zIRXfsV+EZDGuweiXnO/7Unzgoi5+jrXOH3pMhAb9EhkA7boibpLNKyxCQQWACzFkGI/Qd+29iyPMk1TrgzurItuCoiIhxwaR12jqMwYdwRezA/iAXmgRtYPj/gr62pyum+yqZgimelUE+eXNh26LU7+g9L9z6jONKZ/y3sUYZTPG5rMAIc18dALhoBsE3B+b02d20I21R+XaYBUartYDVz49NVh5LgomwRXzjq52XHJ3w5JwOSmJgzs96nYSY8JM4whuvkwUFPTcsMhH8UJLMtc9DbHf0Rp2/Qay6k6RfyVpPYIFT/hKjKm/7YgE+KctchO4DlHEEUkm7jZIbdN8S3r0GW/TACHdts/wqgklNspd 3d6w/fHx dKwbmyYU7mFZsHqr+EtT+nWYnTOgGoc5eqq+DHf2RSKztbglqiwK+YtMdsQRWGYydgXAca2Ux38QPa9MuRY9+gmHGGAC+05cEMfHuNU+nCbC3hC5fdvXZ+ScN2SK6Xx5gBMStvDWs/km/j4gAGwRFdXtLvyYfDhy9RtPHLNfZUiWAUi5q98xRkwLcb6mX1AFNDK6AgSUqY94TbLmGRs4xmQEP3ixMAnbCTQF307qVQL2S1qOvA0sN+B3ppU4/v7X3hYSrWj1hTj2d5nanF53A08DQGWN5Fh1Rejqw8hFRGnQXvXPqWSQHuljV0j8FiqzalI85hHLz0cQ7DDCcRt2xdy5OkC03sCfBw5sMUTFCou0cj7Nu/NE0gjDeK+lOxG4A2bFwUpzysKsng+0KpLf/7kOoth6J/eDEU+Nvyv6dN6QfVmJdyPwE1euWrblHTVB2qC2Qyeq9wMtC3xv09k6zGQ8tSJghsMGs9AR14P8n+OM7g1WDOieZqvfK7z70laA9rzcnWgSjoJYTYUARF+XXiLkexlcB377osBDZ X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: * Raghavendra K T wrote: > On 10/10/2023 2:01 PM, Mel Gorman wrote: > > NUMA Balancing currently uses PID fault activity within a VMA to > > determine if it is worth updating PTEs to trap NUMA hinting faults. > > While this is reduces overhead, it misses two important corner case. > > The first is that if Task A partially scans a VMA that is active and > > Task B resumes the scan but is inactive, then the remainder of the VMA > > may be missed. Similarly, if a VMA is inactive for a period of time then > > it may never be scanned again. > > > > Patches 1-3 improve the documentation of the current per-VMA tracking > > and adds a trace point for scan activity. Patch 4 addresses a corner > > case where the PID activity information may not be reset after the > > expected timeout. Patches 5-6 complete the scanning of partial and > > inactive VMAs within the scan sequence. > > > > This could be improved further but it would deserve a separate series on > > top with supporting data justifying the change. Otherwise and gain/loss > > due to the additional changes could be masked by this series on its own. > > > > Thank you Mel for the patches. I see Ingo already took to sched/core. > Here is my testing detail FWIW. Thank you for testing the series, I've added your Tested-by to the final two patches that change behavior materially: Tested-by: Raghavendra K T Thanks, Ingo