From: Michal Hocko <mhocko@suse.com>
To: Dan Schatzberg <schatzberg.dan@gmail.com>
Cc: Johannes Weiner <hannes@cmpxchg.org>,
Roman Gushchin <roman.gushchin@linux.dev>,
Yosry Ahmed <yosryahmed@google.com>, Huan Yang <link@vivo.com>,
linux-kernel@vger.kernel.org, cgroups@vger.kernel.org,
linux-mm@kvack.org, Tejun Heo <tj@kernel.org>,
Zefan Li <lizefan.x@bytedance.com>,
Jonathan Corbet <corbet@lwn.net>,
Shakeel Butt <shakeelb@google.com>,
Muchun Song <muchun.song@linux.dev>,
Andrew Morton <akpm@linux-foundation.org>,
Kefeng Wang <wangkefeng.wang@huawei.com>,
SeongJae Park <sj@kernel.org>,
"Vishal Moola (Oracle)" <vishal.moola@gmail.com>,
Nhat Pham <nphamcs@gmail.com>, Yue Zhao <findns94@gmail.com>
Subject: Re: [PATCH v5 2/2] mm: add swapiness= arg to memory.reclaim
Date: Wed, 3 Jan 2024 09:59:04 +0100 [thread overview]
Message-ID: <ZZUhBoTNgL3AUK3f@tiehlicka> (raw)
In-Reply-To: <ZZRLVYeTjljn0dO5@dschatzberg-fedora-PF3DHTBV>
On Tue 02-01-24 12:43:49, Dan Schatzberg wrote:
> On Thu, Dec 21, 2023 at 10:29:59AM +0100, Michal Hocko wrote:
[...]
> Thanks for the review Michal and sorry for the delayed response. Your
> patch looks reasonable to me but I'm a bit unclear about the need for
> #ifdef - mem_cgroup_swappiness already works correctly regardless of
> CONFIG_MEMCG or not - why not make sc->swappiness and sc_swappiness()
> unconditional?
We do not have a different user than memcg pro-active reclaim. Making
that conditional makes that more explicit. Nothing that I would insist
on of course.
--
Michal Hocko
SUSE Labs
next prev parent reply other threads:[~2024-01-03 8:59 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-20 15:26 [PATCH v5 0/2] Add swappiness argument to memory.reclaim Dan Schatzberg
2023-12-20 15:26 ` [PATCH v5 1/2] mm: add defines for min/max swappiness Dan Schatzberg
2023-12-21 2:01 ` Nhat Pham
2023-12-22 4:38 ` David Rientjes
2023-12-24 17:14 ` Chris Li
2023-12-20 15:26 ` [PATCH v5 2/2] mm: add swapiness= arg to memory.reclaim Dan Schatzberg
2023-12-21 9:29 ` Michal Hocko
2024-01-02 17:43 ` Dan Schatzberg
2024-01-03 8:59 ` Michal Hocko [this message]
2023-12-22 4:38 ` David Rientjes
2023-12-22 5:31 ` Yu Zhao
2024-01-02 15:21 ` Dan Schatzberg
2024-01-03 0:27 ` Yu Zhao
2024-01-03 15:19 ` Dan Schatzberg
2024-01-03 9:03 ` Michal Hocko
2023-12-24 17:21 ` Chris Li
2024-01-02 22:42 ` Nhat Pham
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZZUhBoTNgL3AUK3f@tiehlicka \
--to=mhocko@suse.com \
--cc=akpm@linux-foundation.org \
--cc=cgroups@vger.kernel.org \
--cc=corbet@lwn.net \
--cc=findns94@gmail.com \
--cc=hannes@cmpxchg.org \
--cc=link@vivo.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=lizefan.x@bytedance.com \
--cc=muchun.song@linux.dev \
--cc=nphamcs@gmail.com \
--cc=roman.gushchin@linux.dev \
--cc=schatzberg.dan@gmail.com \
--cc=shakeelb@google.com \
--cc=sj@kernel.org \
--cc=tj@kernel.org \
--cc=vishal.moola@gmail.com \
--cc=wangkefeng.wang@huawei.com \
--cc=yosryahmed@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).