From: Herbert Xu <herbert@gondor.apana.org.au>
To: Barry Song <21cnbao@gmail.com>
Cc: akpm@linux-foundation.org, davem@davemloft.net,
hannes@cmpxchg.org, linux-crypto@vger.kernel.org,
linux-mm@kvack.org, nphamcs@gmail.com, yosryahmed@google.com,
zhouchengming@bytedance.com, chriscli@google.com,
chrisl@kernel.org, ddstreet@ieee.org,
linux-kernel@vger.kernel.org, sjenning@redhat.com,
vitaly.wool@konsulko.com, Barry Song <v-songbaohua@oppo.com>
Subject: Re: [PATCH v5 1/3] crypto: introduce: acomp_is_async to expose if comp drivers might sleep
Date: Wed, 21 Feb 2024 13:31:59 +0800 [thread overview]
Message-ID: <ZdWKz43tTz2XY4ca@gondor.apana.org.au> (raw)
In-Reply-To: <20240220064414.262582-2-21cnbao@gmail.com>
On Tue, Feb 20, 2024 at 07:44:12PM +1300, Barry Song wrote:
> From: Barry Song <v-songbaohua@oppo.com>
>
> acomp's users might want to know if acomp is really async to
> optimize themselves. One typical user which can benefit from
> exposed async stat is zswap.
>
> In zswap, zsmalloc is the most commonly used allocator for
> (and perhaps the only one). For zsmalloc, we cannot sleep
> while we map the compressed memory, so we copy it to a
> temporary buffer. By knowing the alg won't sleep can help
> zswap to avoid the need for a buffer. This shows noticeable
> improvement in load/store latency of zswap.
>
> Signed-off-by: Barry Song <v-songbaohua@oppo.com>
> ---
> include/crypto/acompress.h | 6 ++++++
> 1 file changed, 6 insertions(+)
Acked-by: Herbert Xu <herbert@gondor.apana.org.au>
Thanks,
--
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
next prev parent reply other threads:[~2024-02-21 5:32 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-20 6:44 [PATCH v5 0/3] mm/zswap & crypto/compress: remove a couple of memcpy Barry Song
2024-02-20 6:44 ` [PATCH v5 1/3] crypto: introduce: acomp_is_async to expose if comp drivers might sleep Barry Song
2024-02-21 5:31 ` Herbert Xu [this message]
2024-02-20 6:44 ` [PATCH v5 2/3] mm/zswap: remove the memcpy if acomp is not sleepable Barry Song
2024-02-20 6:44 ` [PATCH v5 3/3] crypto: scompress: remove memcpy if sg_nents is 1 Barry Song
2024-02-21 5:35 ` Herbert Xu
2024-02-21 5:55 ` Barry Song
2024-02-21 6:10 ` Barry Song
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZdWKz43tTz2XY4ca@gondor.apana.org.au \
--to=herbert@gondor.apana.org.au \
--cc=21cnbao@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=chriscli@google.com \
--cc=chrisl@kernel.org \
--cc=davem@davemloft.net \
--cc=ddstreet@ieee.org \
--cc=hannes@cmpxchg.org \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=nphamcs@gmail.com \
--cc=sjenning@redhat.com \
--cc=v-songbaohua@oppo.com \
--cc=vitaly.wool@konsulko.com \
--cc=yosryahmed@google.com \
--cc=zhouchengming@bytedance.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).